address review

Author: sleepyStick

test/asynchronous/test_client_metadata.py

@@ -49,7 +49,7 @@
     )
 
 # Generate unified tests.
-globals().update(generate_test_classes(_TEST_PATH, module=__name__, RUN_ON_SERVERLESS=True))
+globals().update(generate_test_classes(_TEST_PATH, module=__name__))
 
 
 def _get_handshake_driver_info(request):

test/asynchronous/unified_format.py

@@ -704,7 +704,6 @@ async def _collectionOperation_createChangeStream(self, target, *args, **kwargs)
     async def _databaseOperation_runCommand(self, target, **kwargs):
         self.__raise_if_unsupported("runCommand", target, AsyncDatabase)
         # Ensure the first key is the command name.
-        print(kwargs)
         ordered_command = SON([(kwargs.pop("command_name"), 1)])
         ordered_command.update(kwargs["command"])
         kwargs["command"] = ordered_command
@@ -843,8 +842,6 @@ async def _cursor_close(self, target, *args, **kwargs):
         return await target.close()
 
     async def _clientOperation_appendMetadata(self, target, *args, **kwargs):
-        print("IN MY FUNC")
-        print(kwargs)
         info_opts = kwargs["driver_info_options"]
         driver_info = DriverInfo(info_opts["name"], info_opts["version"], info_opts["platform"])
         target.append_metadata(driver_info)
@@ -938,7 +935,6 @@ async def run_entity_operation(self, spec):
             method_name = f"_clientOperation_{opname}"
         elif isinstance(target, AsyncDatabase):
             method_name = f"_databaseOperation_{opname}"
-            print(f"{method_name=}")
         elif isinstance(target, AsyncCollection):
             method_name = f"_collectionOperation_{opname}"
             # contentType is always stored in metadata in pymongo.
@@ -985,7 +981,6 @@ async def run_entity_operation(self, spec):
                 with pymongo.timeout(timeout):
                     result = await cmd(**dict(arguments))
             else:
-                print(f"{cmd=} {dict=} {arguments=}")
                 result = await cmd(**dict(arguments))
         except Exception as exc:
             # Ignore all operation errors but to avoid masking bugs don't
@@ -1248,7 +1243,6 @@ async def run_special_operation(self, spec):
 
     async def run_operations(self, spec):
         for op in spec:
-            print(f"{op=}")
             if op["object"] == "testRunner":
                 await self.run_special_operation(op)
             else:
@@ -1451,7 +1445,6 @@ async def _run_scenario(self, spec, uri=None):
             await self.check_log_messages(spec["operations"], expect_log_messages)
         else:
             # process operations
-            print(f"{spec['operations']=}")
             await self.run_operations(spec["operations"])
 
         # process expectEvents

test/test_client_metadata.py

@@ -49,7 +49,7 @@
     )
 
 # Generate unified tests.
-globals().update(generate_test_classes(_TEST_PATH, module=__name__, RUN_ON_SERVERLESS=True))
+globals().update(generate_test_classes(_TEST_PATH, module=__name__))
 
 
 def _get_handshake_driver_info(request):

test/unified_format.py

@@ -701,7 +701,6 @@ def _collectionOperation_createChangeStream(self, target, *args, **kwargs):
     def _databaseOperation_runCommand(self, target, **kwargs):
         self.__raise_if_unsupported("runCommand", target, Database)
         # Ensure the first key is the command name.
-        print(kwargs)
         ordered_command = SON([(kwargs.pop("command_name"), 1)])
         ordered_command.update(kwargs["command"])
         kwargs["command"] = ordered_command
@@ -840,8 +839,6 @@ def _cursor_close(self, target, *args, **kwargs):
         return target.close()
 
     def _clientOperation_appendMetadata(self, target, *args, **kwargs):
-        print("IN MY FUNC")
-        print(kwargs)
         info_opts = kwargs["driver_info_options"]
         driver_info = DriverInfo(info_opts["name"], info_opts["version"], info_opts["platform"])
         target.append_metadata(driver_info)
@@ -929,7 +926,6 @@ def run_entity_operation(self, spec):
             method_name = f"_clientOperation_{opname}"
         elif isinstance(target, Database):
             method_name = f"_databaseOperation_{opname}"
-            print(f"{method_name=}")
         elif isinstance(target, Collection):
             method_name = f"_collectionOperation_{opname}"
             # contentType is always stored in metadata in pymongo.
@@ -976,7 +972,6 @@ def run_entity_operation(self, spec):
                 with pymongo.timeout(timeout):
                     result = cmd(**dict(arguments))
             else:
-                print(f"{cmd=} {dict=} {arguments=}")
                 result = cmd(**dict(arguments))
         except Exception as exc:
             # Ignore all operation errors but to avoid masking bugs don't
@@ -1235,7 +1230,6 @@ def run_special_operation(self, spec):
 
     def run_operations(self, spec):
         for op in spec:
-            print(f"{op=}")
             if op["object"] == "testRunner":
                 self.run_special_operation(op)
             else:
@@ -1436,7 +1430,6 @@ def _run_scenario(self, spec, uri=None):
             self.check_log_messages(spec["operations"], expect_log_messages)
         else:
             # process operations
-            print(f"{spec['operations']=}")
             self.run_operations(spec["operations"])
 
         # process expectEvents