return_exceptions=True for gather calls

Author: NoahStapp

pymongo/asynchronous/mongo_client.py

@@ -1567,7 +1567,8 @@ async def close(self) -> None:
         self._closed = True
         if not _IS_SYNC:
             await asyncio.gather(
-                *[self._topology.cleanup_monitors(), self._kill_cursors_executor.join()]  # type: ignore[func-returns-value]
+                *[self._topology.cleanup_monitors(), self._kill_cursors_executor.join()],  # type: ignore[func-returns-value]
+                return_exceptions=True,
             )
 
     if not _IS_SYNC:

pymongo/asynchronous/monitor.py

@@ -190,7 +190,9 @@ def gc_safe_close(self) -> None:
         self.cancel_check()
 
     async def join(self) -> None:
-        await asyncio.gather(*[self._executor.join(), self._rtt_monitor.join()])  # type: ignore[func-returns-value]
+        await asyncio.gather(
+            *[self._executor.join(), self._rtt_monitor.join()], return_exceptions=True
+        )  # type: ignore[func-returns-value]
 
     async def close(self) -> None:
         self.gc_safe_close()

pymongo/asynchronous/topology.py

@@ -1056,7 +1056,7 @@ async def cleanup_monitors(self) -> None:
                 tasks.append(self._monitor_tasks.pop())
         except IndexError:
             pass
-        await asyncio.gather(*[t.join() for t in tasks])  # type: ignore[func-returns-value]
+        await asyncio.gather(*[t.join() for t in tasks], return_exceptions=True)  # type: ignore[func-returns-value]
 
     def __repr__(self) -> str:
         msg = ""

pymongo/synchronous/mongo_client.py

@@ -1561,7 +1561,8 @@ def close(self) -> None:
         self._closed = True
         if not _IS_SYNC:
             asyncio.gather(
-                *[self._topology.cleanup_monitors(), self._kill_cursors_executor.join()]  # type: ignore[func-returns-value]
+                *[self._topology.cleanup_monitors(), self._kill_cursors_executor.join()],  # type: ignore[func-returns-value]
+                return_exceptions=True,
             )
 
     if not _IS_SYNC:

pymongo/synchronous/monitor.py

@@ -190,7 +190,7 @@ def gc_safe_close(self) -> None:
         self.cancel_check()
 
     def join(self) -> None:
-        asyncio.gather(*[self._executor.join(), self._rtt_monitor.join()])  # type: ignore[func-returns-value]
+        asyncio.gather(*[self._executor.join(), self._rtt_monitor.join()], return_exceptions=True)  # type: ignore[func-returns-value]
 
     def close(self) -> None:
         self.gc_safe_close()

pymongo/synchronous/topology.py

@@ -1054,7 +1054,7 @@ def cleanup_monitors(self) -> None:
                 tasks.append(self._monitor_tasks.pop())
         except IndexError:
             pass
-        asyncio.gather(*[t.join() for t in tasks])  # type: ignore[func-returns-value]
+        asyncio.gather(*[t.join() for t in tasks], return_exceptions=True)  # type: ignore[func-returns-value]
 
     def __repr__(self) -> str:
         msg = ""