Skip to content

Commit 3d13cf5

Browse files
committed
address review
1 parent bd540aa commit 3d13cf5

File tree

4 files changed

+2
-26
lines changed

4 files changed

+2
-26
lines changed

test/__init__.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,6 @@ def is_topology_type(self, topologies):
678678
"single",
679679
"replicaset",
680680
"sharded",
681-
"sharded-replicaset",
682681
"load-balanced",
683682
}
684683
if unknown:
@@ -693,16 +692,6 @@ def is_topology_type(self, topologies):
693692
return True
694693
if "sharded" in topologies and self.is_mongos:
695694
return True
696-
if "sharded-replicaset" in topologies and self.is_mongos:
697-
shards = client_context.client.config.shards.find().to_list()
698-
for shard in shards:
699-
# For a 3-member RS-backed sharded cluster, shard['host']
700-
# will be 'replicaName/ip1:port1,ip2:port2,ip3:port3'
701-
# Otherwise it will be 'ip1:port1'
702-
host_spec = shard["host"]
703-
if not len(host_spec.split("/")) > 1:
704-
return False
705-
return True
706695
return False
707696

708697
def require_cluster_type(self, topologies=None):

test/asynchronous/__init__.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,6 @@ async def is_topology_type(self, topologies):
680680
"single",
681681
"replicaset",
682682
"sharded",
683-
"sharded-replicaset",
684683
"load-balanced",
685684
}
686685
if unknown:
@@ -695,16 +694,6 @@ async def is_topology_type(self, topologies):
695694
return True
696695
if "sharded" in topologies and self.is_mongos:
697696
return True
698-
if "sharded-replicaset" in topologies and self.is_mongos:
699-
shards = await async_client_context.client.config.shards.find().to_list()
700-
for shard in shards:
701-
# For a 3-member RS-backed sharded cluster, shard['host']
702-
# will be 'replicaName/ip1:port1,ip2:port2,ip3:port3'
703-
# Otherwise it will be 'ip1:port1'
704-
host_spec = shard["host"]
705-
if not len(host_spec.split("/")) > 1:
706-
return False
707-
return True
708697
return False
709698

710699
def require_cluster_type(self, topologies=None):

test/discovery_and_monitoring/unified/serverMonitoringMode.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
{
66
"topologies": [
77
"single",
8-
"sharded",
9-
"sharded-replicaset"
8+
"sharded"
109
],
1110
"serverless": "forbid"
1211
}

test/run_command/unified/runCommand.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@
229229
{
230230
"topologies": [
231231
"replicaset",
232-
"sharded-replicaset",
233232
"load-balanced",
234233
"sharded"
235234
]
@@ -493,7 +492,7 @@
493492
{
494493
"minServerVersion": "4.2",
495494
"topologies": [
496-
"sharded-replicaset",
495+
"sharded",
497496
"load-balanced"
498497
]
499498
}

0 commit comments

Comments
 (0)