Skip to content

Commit 511fcc4

Browse files
committed
bringing back a previously deleted test
1 parent 4c06dec commit 511fcc4

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

test/asynchronous/test_client.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,6 +1074,13 @@ async def test_uri_connect_option(self):
10741074
kc_task = client._kill_cursors_executor._task
10751075
self.assertTrue(kc_task and not kc_task.done())
10761076

1077+
async def test_close_does_not_open_servers(self):
1078+
client = await self.async_rs_client(connect=False)
1079+
topology = client._topology
1080+
self.assertEqual(topology._servers, {})
1081+
await client.close()
1082+
self.assertEqual(topology._servers, {})
1083+
10771084
async def test_close_closes_sockets(self):
10781085
client = await self.async_rs_client()
10791086
await client.test.test.find_one()
@@ -1891,7 +1898,7 @@ async def test_service_name_from_kwargs(self):
18911898
client = AsyncMongoClient(
18921899
"mongodb+srv://user:[email protected]",
18931900
srvServiceName="customname",
1894-
connect=False,
1901+
connect=True,
18951902
)
18961903
await client.aconnect()
18971904
self.assertEqual(client._topology_settings.srv_service_name, "customname")

test/test_client.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1047,6 +1047,13 @@ def test_uri_connect_option(self):
10471047
kc_task = client._kill_cursors_executor._task
10481048
self.assertTrue(kc_task and not kc_task.done())
10491049

1050+
def test_close_does_not_open_servers(self):
1051+
client = self.rs_client(connect=False)
1052+
topology = client._topology
1053+
self.assertEqual(topology._servers, {})
1054+
client.close()
1055+
self.assertEqual(topology._servers, {})
1056+
10501057
def test_close_closes_sockets(self):
10511058
client = self.rs_client()
10521059
client.test.test.find_one()
@@ -1848,7 +1855,7 @@ def test_service_name_from_kwargs(self):
18481855
client = MongoClient(
18491856
"mongodb+srv://user:[email protected]",
18501857
srvServiceName="customname",
1851-
connect=False,
1858+
connect=True,
18521859
)
18531860
client._connect()
18541861
self.assertEqual(client._topology_settings.srv_service_name, "customname")

0 commit comments

Comments
 (0)