Skip to content

Commit 58a58a0

Browse files
committed
more cleanup
1 parent 57edcbc commit 58a58a0

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

test/asynchronous/test_client.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -824,11 +824,9 @@ async def test_init_disconnected(self):
824824
c = await self.async_rs_or_single_client(connect=False)
825825
self.assertEqual(c.codec_options, CodecOptions())
826826
c = await self.async_rs_or_single_client(connect=False)
827-
await c.aconnect()
828827
self.assertFalse(await c.primary)
829828
self.assertFalse(await c.secondaries)
830829
c = await self.async_rs_or_single_client(connect=False)
831-
await c.aconnect()
832830
self.assertIsInstance(c.topology_description, TopologyDescription)
833831
self.assertEqual(c.topology_description, c._topology._description)
834832
if async_client_context.is_rs:
@@ -860,17 +858,13 @@ async def test_equality(self):
860858
self.assertTrue(async_client_context.client != c)
861859

862860
c1 = self.simple_client("a", connect=False)
863-
await c1.aconnect()
864861
c2 = self.simple_client("b", connect=False)
865-
await c2.aconnect()
866862

867863
# Seeds differ:
868864
self.assertNotEqual(c1, c2)
869865

870866
c1 = self.simple_client(["a", "b", "c"], connect=False)
871-
await c1.aconnect()
872867
c2 = self.simple_client(["c", "a", "b"], connect=False)
873-
await c2.aconnect()
874868

875869
# Same seeds but out of order still compares equal:
876870
self.assertEqual(c1, c2)
@@ -910,9 +904,7 @@ async def test_repr(self):
910904
self.assertIn("replicaset='replset'", the_repr)
911905
self.assertIn("w=1", the_repr)
912906
self.assertIn("wtimeoutms=100", the_repr)
913-
await client.close()
914907
async with eval(the_repr) as client_two:
915-
await client_two.aconnect()
916908
self.assertEqual(client_two, client)
917909

918910
client = self.simple_client(
@@ -934,7 +926,6 @@ async def test_repr(self):
934926
self.assertIn("wtimeoutms=100", the_repr)
935927

936928
async with eval(the_repr) as client_two:
937-
await client_two.aconnect()
938929
self.assertEqual(client_two, client)
939930

940931
async def test_getters(self):

test/test_client.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -799,11 +799,9 @@ def test_init_disconnected(self):
799799
c = self.rs_or_single_client(connect=False)
800800
self.assertEqual(c.codec_options, CodecOptions())
801801
c = self.rs_or_single_client(connect=False)
802-
c._connect()
803802
self.assertFalse(c.primary)
804803
self.assertFalse(c.secondaries)
805804
c = self.rs_or_single_client(connect=False)
806-
c._connect()
807805
self.assertIsInstance(c.topology_description, TopologyDescription)
808806
self.assertEqual(c.topology_description, c._topology._description)
809807
if client_context.is_rs:
@@ -835,17 +833,13 @@ def test_equality(self):
835833
self.assertTrue(client_context.client != c)
836834

837835
c1 = self.simple_client("a", connect=False)
838-
c1._connect()
839836
c2 = self.simple_client("b", connect=False)
840-
c2._connect()
841837

842838
# Seeds differ:
843839
self.assertNotEqual(c1, c2)
844840

845841
c1 = self.simple_client(["a", "b", "c"], connect=False)
846-
c1._connect()
847842
c2 = self.simple_client(["c", "a", "b"], connect=False)
848-
c2._connect()
849843

850844
# Same seeds but out of order still compares equal:
851845
self.assertEqual(c1, c2)
@@ -885,9 +879,7 @@ def test_repr(self):
885879
self.assertIn("replicaset='replset'", the_repr)
886880
self.assertIn("w=1", the_repr)
887881
self.assertIn("wtimeoutms=100", the_repr)
888-
client.close()
889882
with eval(the_repr) as client_two:
890-
client_two._connect()
891883
self.assertEqual(client_two, client)
892884

893885
client = self.simple_client(
@@ -909,7 +901,6 @@ def test_repr(self):
909901
self.assertIn("wtimeoutms=100", the_repr)
910902

911903
with eval(the_repr) as client_two:
912-
client_two._connect()
913904
self.assertEqual(client_two, client)
914905

915906
def test_getters(self):

0 commit comments

Comments
 (0)