Skip to content

Commit 6184475

Browse files
committed
use tailored list of skips
1 parent 7a316f7 commit 6184475

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

test/asynchronous/unified_format.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -533,14 +533,21 @@ def maybe_skip_test(self, spec):
533533
class_name = self.__class__.__name__.lower()
534534
description = spec["description"].lower()
535535
if "csot" in class_name:
536-
if "gridfs" in class_name and sys.platform == "win32":
537-
self.skipTest("PYTHON-3522 CSOT GridFS tests are flaky on Windows")
538-
if (
536+
slow_win32 = [
537+
"maxTimeMS value in the command is less than timeoutMS",
538+
"Non-tailable cursor lifetime remaining timeoutMS applied to getMore if timeoutMode is unset",
539+
"timeoutMS applied to update during a rename",
540+
"timeoutMS applied to find to get chunks",
541+
"test timeoutMS applied to find to get files document",
542+
"test timeoutMS applied to find command",
543+
]
544+
slow_macos = [
539545
"Non-tailable cursor lifetime remaining timeoutMS applied to getMore if timeoutMode is unset"
540-
in description
541-
and sys.platform != "linux"
542-
):
543-
self.skipTest("PYTHON-3522 CSOT test is flaky on Windows and MacOS")
546+
]
547+
if sys.platform == "win32" and description in slow_win32:
548+
self.skipTest("PYTHON-3522 CSOT test run too slow on Windows")
549+
if sys.platform == "darwin" and description in slow_macos:
550+
self.skipTest("PYTHON-3522 CSOT test runs too slow on MacOS")
544551
if async_client_context.storage_engine == "mmapv1":
545552
self.skipTest(
546553
"MMAPv1 does not support retryable writes which is required for CSOT tests"

test/unified_format.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -532,14 +532,21 @@ def maybe_skip_test(self, spec):
532532
class_name = self.__class__.__name__.lower()
533533
description = spec["description"].lower()
534534
if "csot" in class_name:
535-
if "gridfs" in class_name and sys.platform == "win32":
536-
self.skipTest("PYTHON-3522 CSOT GridFS tests are flaky on Windows")
537-
if (
535+
slow_win32 = [
536+
"maxTimeMS value in the command is less than timeoutMS",
537+
"Non-tailable cursor lifetime remaining timeoutMS applied to getMore if timeoutMode is unset",
538+
"timeoutMS applied to update during a rename",
539+
"timeoutMS applied to find to get chunks",
540+
"test timeoutMS applied to find to get files document",
541+
"test timeoutMS applied to find command",
542+
]
543+
slow_macos = [
538544
"Non-tailable cursor lifetime remaining timeoutMS applied to getMore if timeoutMode is unset"
539-
in description
540-
and sys.platform != "linux"
541-
):
542-
self.skipTest("PYTHON-3522 CSOT test is flaky on Windows and MacOS")
545+
]
546+
if sys.platform == "win32" and description in slow_win32:
547+
self.skipTest("PYTHON-3522 CSOT test run too slow on Windows")
548+
if sys.platform == "darwin" and description in slow_macos:
549+
self.skipTest("PYTHON-3522 CSOT test runs too slow on MacOS")
543550
if client_context.storage_engine == "mmapv1":
544551
self.skipTest(
545552
"MMAPv1 does not support retryable writes which is required for CSOT tests"

0 commit comments

Comments
 (0)