Skip to content

Commit 85e59fd

Browse files
committed
Revert back to using the default executor
1 parent 5e3bc65 commit 85e59fd

File tree

6 files changed

+8
-45
lines changed

6 files changed

+8
-45
lines changed

pymongo/_asyncio_executor.py

Lines changed: 0 additions & 22 deletions
This file was deleted.

pymongo/asynchronous/helpers.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import asyncio
1919
import builtins
20-
import functools
2120
import socket
2221
import sys
2322
from typing import (
@@ -27,7 +26,6 @@
2726
cast,
2827
)
2928

30-
from pymongo._asyncio_executor import _PYMONGO_EXECUTOR
3129
from pymongo.errors import (
3230
OperationFailure,
3331
)
@@ -85,9 +83,7 @@ async def getaddrinfo(
8583
]:
8684
if not _IS_SYNC:
8785
loop = asyncio.get_running_loop()
88-
return await loop.run_in_executor( # type: ignore[return-value]
89-
_PYMONGO_EXECUTOR, functools.partial(socket.getaddrinfo, host, port, **kwargs)
90-
)
86+
return await loop.getaddrinfo(host, port, **kwargs) # type: ignore[return-value]
9187
else:
9288
return socket.getaddrinfo(host, port, **kwargs)
9389

pymongo/asynchronous/pool.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939

4040
from bson import DEFAULT_CODEC_OPTIONS
4141
from pymongo import _csot, helpers_shared
42-
from pymongo._asyncio_executor import _PYMONGO_EXECUTOR
4342
from pymongo.asynchronous.client_session import _validate_session_write_concern
4443
from pymongo.asynchronous.helpers import _handle_reauth, getaddrinfo
4544
from pymongo.asynchronous.network import command, receive_message
@@ -884,7 +883,7 @@ async def _configured_socket(
884883
else:
885884
loop = asyncio.get_running_loop()
886885
ssl_sock = await loop.run_in_executor(
887-
_PYMONGO_EXECUTOR,
886+
None,
888887
functools.partial(ssl_context.wrap_socket, sock, server_hostname=host), # type: ignore[assignment, misc]
889888
)
890889
else:
@@ -895,9 +894,7 @@ async def _configured_socket(
895894
ssl_sock = await ssl_context.a_wrap_socket(sock) # type: ignore[assignment, misc]
896895
else:
897896
loop = asyncio.get_running_loop()
898-
ssl_sock = await loop.run_in_executor(
899-
_PYMONGO_EXECUTOR, ssl_context.wrap_socket, sock
900-
) # type: ignore[assignment, misc]
897+
ssl_sock = await loop.run_in_executor(None, ssl_context.wrap_socket, sock) # type: ignore[assignment, misc]
901898
except _CertificateError:
902899
sock.close()
903900
# Raise _CertificateError directly like we do after match_hostname

pymongo/pyopenssl_context.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
from OpenSSL import SSL as _SSL
3232
from OpenSSL import crypto as _crypto
3333

34-
from pymongo._asyncio_executor import _PYMONGO_EXECUTOR
3534
from pymongo.errors import ConfigurationError as _ConfigurationError
3635
from pymongo.errors import _CertificateError # type:ignore[attr-defined]
3736
from pymongo.ocsp_cache import _OCSPCache
@@ -406,15 +405,15 @@ async def a_wrap_socket(
406405
ssl_conn.set_tlsext_host_name(server_hostname.encode("idna"))
407406
if self.verify_mode != _stdlibssl.CERT_NONE:
408407
# Request a stapled OCSP response.
409-
await loop.run_in_executor(_PYMONGO_EXECUTOR, ssl_conn.request_ocsp)
408+
await loop.run_in_executor(None, ssl_conn.request_ocsp)
410409
ssl_conn.set_connect_state()
411410
# If this wasn't true the caller of wrap_socket would call
412411
# do_handshake()
413412
if do_handshake_on_connect:
414413
# XXX: If we do hostname checking in a callback we can get rid
415414
# of this call to do_handshake() since the handshake
416415
# will happen automatically later.
417-
await loop.run_in_executor(_PYMONGO_EXECUTOR, ssl_conn.do_handshake)
416+
await loop.run_in_executor(None, ssl_conn.do_handshake)
418417
# XXX: Do this in a callback registered with
419418
# SSLContext.set_info_callback? See Twisted for an example.
420419
if self.check_hostname and server_hostname is not None:

pymongo/synchronous/helpers.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import asyncio
1919
import builtins
20-
import functools
2120
import socket
2221
import sys
2322
from typing import (
@@ -27,7 +26,6 @@
2726
cast,
2827
)
2928

30-
from pymongo._asyncio_executor import _PYMONGO_EXECUTOR
3129
from pymongo.errors import (
3230
OperationFailure,
3331
)
@@ -85,9 +83,7 @@ def getaddrinfo(
8583
]:
8684
if not _IS_SYNC:
8785
loop = asyncio.get_running_loop()
88-
return loop.run_in_executor( # type: ignore[return-value]
89-
_PYMONGO_EXECUTOR, functools.partial(socket.getaddrinfo, host, port, **kwargs)
90-
)
86+
return loop.getaddrinfo(host, port, **kwargs) # type: ignore[return-value]
9187
else:
9288
return socket.getaddrinfo(host, port, **kwargs)
9389

pymongo/synchronous/pool.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939

4040
from bson import DEFAULT_CODEC_OPTIONS
4141
from pymongo import _csot, helpers_shared
42-
from pymongo._asyncio_executor import _PYMONGO_EXECUTOR
4342
from pymongo.common import (
4443
MAX_BSON_SIZE,
4544
MAX_MESSAGE_SIZE,
@@ -880,7 +879,7 @@ def _configured_socket(address: _Address, options: PoolOptions) -> Union[socket.
880879
else:
881880
loop = asyncio.get_running_loop()
882881
ssl_sock = loop.run_in_executor(
883-
_PYMONGO_EXECUTOR,
882+
None,
884883
functools.partial(ssl_context.wrap_socket, sock, server_hostname=host), # type: ignore[assignment, misc]
885884
)
886885
else:
@@ -891,9 +890,7 @@ def _configured_socket(address: _Address, options: PoolOptions) -> Union[socket.
891890
ssl_sock = ssl_context.a_wrap_socket(sock) # type: ignore[assignment, misc]
892891
else:
893892
loop = asyncio.get_running_loop()
894-
ssl_sock = loop.run_in_executor(
895-
_PYMONGO_EXECUTOR, ssl_context.wrap_socket, sock
896-
) # type: ignore[assignment, misc]
893+
ssl_sock = loop.run_in_executor(None, ssl_context.wrap_socket, sock) # type: ignore[assignment, misc]
897894
except _CertificateError:
898895
sock.close()
899896
# Raise _CertificateError directly like we do after match_hostname

0 commit comments

Comments
 (0)