ConcurrentRunner.join timeout defaults to None, not 0

Author: NoahStapp

test/asynchronous/helpers.py

@@ -40,7 +40,7 @@
 except ImportError:
     HAVE_IPADDRESS = False
 from functools import wraps
-from typing import Any, Callable, Dict, Generator, no_type_check
+from typing import Any, Callable, Dict, Generator, Optional, no_type_check
 from unittest import SkipTest
 
 from bson.son import SON
@@ -395,7 +395,7 @@ def __init__(self, **kwargs):
         async def start(self):
             self.task = create_task(self.run(), name=self.name)
 
-        async def join(self, timeout: float | None = 0):  # type: ignore[override]
+        async def join(self, timeout: Optional[float] = None):  # type: ignore[override]
             if self.task is not None:
                 await asyncio.wait([self.task], timeout=timeout)
 

test/asynchronous/test_load_balancer.py

@@ -186,7 +186,7 @@ async def lock_pool(self):
 
     async def wait(self, event: Event, timeout: int):
         if _IS_SYNC:
-            return event.wait(timeout)
+            return event.wait(timeout)  # type: ignore[call-arg]
         else:
             try:
                 await asyncio.wait_for(event.wait(), timeout=timeout)

test/helpers.py

@@ -40,7 +40,7 @@
 except ImportError:
     HAVE_IPADDRESS = False
 from functools import wraps
-from typing import Any, Callable, Dict, Generator, no_type_check
+from typing import Any, Callable, Dict, Generator, Optional, no_type_check
 from unittest import SkipTest
 
 from bson.son import SON
@@ -395,7 +395,7 @@ def __init__(self, **kwargs):
         def start(self):
             self.task = create_task(self.run(), name=self.name)
 
-        def join(self, timeout: float | None = 0):  # type: ignore[override]
+        def join(self, timeout: Optional[float] = None):  # type: ignore[override]
             if self.task is not None:
                 asyncio.wait([self.task], timeout=timeout)
 

test/test_load_balancer.py

@@ -186,7 +186,7 @@ def lock_pool(self):
 
     def wait(self, event: Event, timeout: int):
         if _IS_SYNC:
-            return event.wait(timeout)
+            return event.wait(timeout)  # type: ignore[call-arg]
         else:
             try:
                 asyncio.wait_for(event.wait(), timeout=timeout)