Skip to content

Commit 9df90f0

Browse files
committed
fix kms_setup
1 parent fdc7118 commit 9df90f0

File tree

3 files changed

+27
-20
lines changed

3 files changed

+27
-20
lines changed

.evergreen/scripts/kms_tester.py

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
CSFLE_FOLDER = f"{DRIVERS_TOOLS}/.evergreen/csfle"
99

1010

11-
def setup_azure_vm(base_env: dict[str, str]) -> None:
11+
def _setup_azure_vm(base_env: dict[str, str]) -> None:
1212
LOGGER.info("Setting up Azure VM...")
1313
env = base_env.copy()
1414
env["AZUREKMS_SRC"] = TMP_DRIVER_FILE
@@ -24,7 +24,7 @@ def setup_azure_vm(base_env: dict[str, str]) -> None:
2424
LOGGER.info("Setting up Azure VM... done.")
2525

2626

27-
def setup_gcp_vm(base_env: dict[str, str]) -> None:
27+
def _setup_gcp_vm(base_env: dict[str, str]) -> None:
2828
LOGGER.info("Setting up GCP VM...")
2929
env = base_env.copy()
3030
env["GCPKMS_SRC"] = TMP_DRIVER_FILE
@@ -33,14 +33,14 @@ def setup_gcp_vm(base_env: dict[str, str]) -> None:
3333

3434
env = base_env.copy()
3535
env["GCPKMS_CMD"] = "tar xf mongo-python-driver.tgz"
36-
run_command("{CSFLE_FOLDER}/gcpkms/run-command.sh", env=env)
36+
run_command(f"{CSFLE_FOLDER}/gcpkms/run-command.sh", env=env)
3737

3838
env["GCPKMS_CMD"] = "bash ./.evergreen/just.sh setup-test kms gcp-remote"
39-
run_command("{CSFLE_FOLDER}/gcpkms/run-command.sh", env=env)
39+
run_command(f"{CSFLE_FOLDER}/gcpkms/run-command.sh", env=env)
4040
LOGGER.info("Setting up GCP VM...")
4141

4242

43-
def create_archive():
43+
def _create_archive():
4444
run_command("git add .", cwd=ROOT)
4545
run_command('git commit -m "add files"', check=False, cwd=ROOT)
4646
run_command(f"git archive -o {TMP_DRIVER_FILE} HEAD", cwd=ROOT)
@@ -68,26 +68,23 @@ def setup_kms(sub_test_name: str) -> None:
6868
if sub_test_type == "remote":
6969
return
7070

71-
if sub_test_target == "azure":
72-
os.environ["AZUREKMS_VMNAME_PREFIX"] = "PYTHON_DRIVER"
73-
74-
run_command(f"{CSFLE_FOLDER}/{sub_test_target}kms/setup-secrets.sh")
75-
7671
if success:
77-
create_archive()
78-
72+
_create_archive()
73+
if sub_test_target == "azure":
74+
os.environ["AZUREKMS_VMNAME_PREFIX"] = "PYTHON_DRIVER"
7975
run_command(f"{CSFLE_FOLDER}/{sub_test_target}kms/setup.sh")
80-
config = read_env(f"{CSFLE_FOLDER}/gcpkms/secrets-export.sh")
76+
config = read_env(f"{CSFLE_FOLDER}/{sub_test_target}/secrets-export.sh")
8177
base_env = os.environ.copy()
8278
for key, value in config.items():
8379
base_env[key] = str(value)
8480

8581
if sub_test_target == "azure":
86-
setup_azure_vm(base_env)
82+
_setup_azure_vm(base_env)
8783
else:
88-
setup_gcp_vm(base_env)
84+
_setup_gcp_vm(base_env)
8985

9086
if sub_test_target == "azure":
87+
run_command(f"{CSFLE_FOLDER}/{sub_test_target}kms/setup-secrets.sh")
9188
config = read_env(f"{CSFLE_FOLDER}/{sub_test_target}kms/secrets-export.sh")
9289
write_env("KEY_NAME", config["AZUREKMS_KEYNAME"])
9390
write_env("KEY_VAULT_ENDPOINT", config["AZUREKMS_KEYVAULTENDPOINT"])
@@ -108,5 +105,9 @@ def test_kms_vm(sub_test_name: str) -> None:
108105
run_command(cmd, env=env)
109106

110107

108+
def teardown_kms(sub_test_name: str) -> None:
109+
run_command(f"bash {CSFLE_FOLDER}/{sub_test_name}kms/teardown.sh")
110+
111+
111112
if __name__ == "__main__":
112113
setup_kms()

.evergreen/scripts/teardown-tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ ROOT_DIR="$(dirname $SCRIPT_DIR)"
88
pushd $ROOT_DIR > /dev/null
99

1010
# Try to source the env file.
11-
if [ -f $SCRIPT_DIR/scripts/env.sh ]; then
11+
if [ -f $SCRIPT_DIR/env.sh ]; then
1212
echo "Sourcing env inputs"
1313
. $SCRIPT_DIR/env.sh
1414
else
1515
echo "Not sourcing env inputs"
1616
fi
1717

1818
# Handle test inputs.
19-
if [ -f $SCRIPT_DIR/scripts/test-env.sh ]; then
19+
if [ -f $SCRIPT_DIR/test-env.sh ]; then
2020
echo "Sourcing test inputs"
2121
. $SCRIPT_DIR/test-env.sh
2222
else

.evergreen/scripts/teardown_tests.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
import os
44

5-
from utils import DRIVERS_TOOLS, run_command
5+
from utils import DRIVERS_TOOLS, LOGGER, run_command
66

7-
TEST_NAME = os.environ.get("TEST_NAME")
7+
TEST_NAME = os.environ.get("TEST_NAME", "unconfigured")
88
SUB_TEST_NAME = os.environ.get("SUB_TEST_NAME")
99

10+
LOGGER.info(f"Tearing down tests of type '{TEST_NAME}'...")
11+
1012
# Shut down csfle servers if applicable
1113
if TEST_NAME == "encryption":
1214
run_command(f"bash {DRIVERS_TOOLS}/.evergreen/csfle/stop-servers.sh")
@@ -17,4 +19,8 @@
1719

1820
# Tear down kms VM if applicable.
1921
elif TEST_NAME == "kms" and SUB_TEST_NAME in ["azure", "gcp"]:
20-
run_command(f"bash {DRIVERS_TOOLS}/.evergreen/csfle/{SUB_TEST_NAME}kms/teardown.sh")
22+
from kms_tester import teardown_kms
23+
24+
teardown_kms(SUB_TEST_NAME)
25+
26+
LOGGER.info(f"Tearing down tests of type '{TEST_NAME}'... done.")

0 commit comments

Comments
 (0)