Merge branch 'master' of github.com:mongodb/mongo-python-driver into PYTHON-5157

Author: blink1073

.evergreen/config.yml

@@ -262,7 +262,7 @@ functions:
       params:
         include_expansions_in_env: [AUTH, SSL, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY,
           AWS_SESSION_TOKEN, COVERAGE, PYTHON_BINARY, LIBMONGOCRYPT_URL, MONGODB_URI,
-          DISABLE_TEST_COMMANDS, GREEN_FRAMEWORK, NO_EXT, COMPRESSORS, MONGODB_API_VERSION]
+          DISABLE_TEST_COMMANDS, GREEN_FRAMEWORK, NO_EXT, COMPRESSORS, MONGODB_API_VERSION, DEBUG_LOG]
         binary: bash
         working_dir: "src"
         args: [.evergreen/just.sh, setup-tests, "${TEST_NAME}", "${SUB_TEST_NAME}"]

.evergreen/run-tests.sh

@@ -38,6 +38,6 @@ fi
 PIP_QUIET=0 uv run ${UV_ARGS} --with pip pip list
 
 # Start the test runner.
-uv run ${UV_ARGS} .evergreen/scripts/run_tests.py
+uv run ${UV_ARGS} .evergreen/scripts/run_tests.py "$@"
 
 popd

.evergreen/scripts/run_tests.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import json
+import logging
 import os
 import platform
 import shutil
@@ -111,8 +112,11 @@ def run() -> None:
         run_command(f"{DRIVERS_TOOLS}/.evergreen/auth_aws/aws_setup.sh ecs")
         return
 
+    if os.environ.get("DEBUG_LOG"):
+        TEST_ARGS.extend(f"-o log_cli_level={logging.DEBUG} -o log_cli=1".split())
+
     # Run local tests.
-    ret = pytest.main(TEST_ARGS)
+    ret = pytest.main(TEST_ARGS + sys.argv[:1])
     if ret != 0:
         sys.exit(ret)
 

.evergreen/scripts/setup_tests.py

@@ -26,7 +26,7 @@
 )
 
 # Passthrough environment variables.
-PASS_THROUGH_ENV = ["GREEN_FRAMEWORK", "NO_EXT", "MONGODB_API_VERSION"]
+PASS_THROUGH_ENV = ["GREEN_FRAMEWORK", "NO_EXT", "MONGODB_API_VERSION", "DEBUG_LOG"]
 
 # Map the test name to a test suite.
 TEST_SUITE_MAP = {

.pre-commit-config.yaml

@@ -6,6 +6,7 @@ repos:
   - id: check-added-large-files
   - id: check-case-conflict
   - id: check-toml
+  - id: check-json
   - id: check-yaml
     exclude: template.yaml
   - id: debug-statements

CONTRIBUTING.md

@@ -224,6 +224,12 @@ the pages will re-render and the browser will automatically refresh.
 - Run the tests with `just run-tests`.
 - When done, run `just teardown-tests` to clean up.
 
+## Enable Debug Logs
+- Use `-o log_cli_level="DEBUG" -o log_cli=1` with `just test` or `pytest`.
+- Add `log_cli_level = "DEBUG` and `log_cli = 1` to the `tool.pytest.ini_options` section in `pyproject.toml` for Evergreen patches or to enable debug logs by default on your machine.
+- You can also set `DEBUG_LOG=1` and run either `just setup-tests` or `just-test`.
+- For evergreen patch builds, you can use `evergreen patch --param DEBUG_LOG=1` to enable debug logs for the patch.
+
 ## Re-sync Spec Tests
 
 If you would like to re-sync the copy of the specification tests in the

bson/binary.py

@@ -450,6 +450,10 @@ def from_vector(
                 raise ValueError(f"padding does not apply to {dtype=}")
         elif dtype == BinaryVectorDtype.PACKED_BIT:  # pack ints in [0, 255] as unsigned uint8
             format_str = "B"
+            if 0 <= padding > 7:
+                raise ValueError(f"{padding=}. It must be in [0,1, ..7].")
+            if padding and not vector:
+                raise ValueError("Empty vector with non-zero padding.")
         elif dtype == BinaryVectorDtype.FLOAT32:  # pack floats as float32
             format_str = "f"
             if padding:

doc/changelog.rst

@@ -199,7 +199,7 @@ PyMongo 4.9 brings a number of improvements including:
   unction-as-a-service (FaaS) like AWS Lambda, Google Cloud Functions, and Microsoft Azure Functions.
   On some FaaS systems, there is a ``fork()`` operation at function
   startup.  By delaying the connection to the first operation, we avoid a deadlock.  See
-  `Is PyMongo Fork-Safe`_ for more information.
+  :ref:`pymongo-fork-safe` for more information.
 
 
 Issues Resolved
@@ -208,7 +208,6 @@ Issues Resolved
 See the `PyMongo 4.9 release notes in JIRA`_ for the list of resolved issues
 in this release.
 
-.. _Is PyMongo Fork-Safe: https://www.mongodb.com/docs/languages/python/pymongo-driver/current/troubleshooting/#forking-a-process-causes-a-deadlock
 .. _PyMongo 4.9 release notes in JIRA: https://jira.mongodb.org/secure/ReleaseNote.jspa?projectId=10004&version=39940
 
 

pymongo/asynchronous/topology.py

@@ -236,7 +236,7 @@ async def open(self) -> None:
             warnings.warn(  # type: ignore[call-overload] # noqa: B028
                 "AsyncMongoClient opened before fork. May not be entirely fork-safe, "
                 "proceed with caution. See PyMongo's documentation for details: "
-                "https://www.mongodb.com/docs/languages/python/pymongo-driver/current/troubleshooting/#forking-a-process-causes-a-deadlock",
+                "https://dochub.mongodb.org/core/pymongo-fork-deadlock",
                 **kwargs,
             )
             async with self._lock:

pymongo/synchronous/topology.py

@@ -236,7 +236,7 @@ def open(self) -> None:
             warnings.warn(  # type: ignore[call-overload] # noqa: B028
                 "MongoClient opened before fork. May not be entirely fork-safe, "
                 "proceed with caution. See PyMongo's documentation for details: "
-                "https://www.mongodb.com/docs/languages/python/pymongo-driver/current/troubleshooting/#forking-a-process-causes-a-deadlock",
+                "https://dochub.mongodb.org/core/pymongo-fork-deadlock",
                 **kwargs,
             )
             with self._lock: