Skip to content

Commit ce05c69

Browse files
committed
Address review
1 parent 396b076 commit ce05c69

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

pymongo/read_preferences.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,6 @@ def document(self) -> dict[str, Any]:
149149
if self.__max_staleness != -1:
150150
doc["maxStalenessSeconds"] = self.__max_staleness
151151
if self.__hedge not in (None, {}):
152-
warnings.warn(
153-
"The read preference 'hedge' option is deprecated in PyMongo 4.12+ because hedged reads are deprecated in MongoDB version 8.0+. Support for 'hedge' will be removed in PyMongo 5.0.",
154-
DeprecationWarning,
155-
stacklevel=2,
156-
)
157152
doc["hedge"] = self.__hedge
158153
return doc
159154

@@ -194,7 +189,9 @@ def max_staleness(self) -> int:
194189

195190
@property
196191
def hedge(self) -> Optional[_Hedge]:
197-
"""The read preference ``hedge`` parameter.
192+
"""**DEPRECATED** - The read preference 'hedge' option is deprecated in PyMongo 4.12+ because hedged reads are deprecated in MongoDB version 8.0+. Support for 'hedge' will be removed in PyMongo 5.0.
193+
194+
The read preference ``hedge`` parameter.
198195
199196
A dictionary that configures how the server will perform hedged reads.
200197
It consists of the following keys:
@@ -329,7 +326,7 @@ class PrimaryPreferred(_ServerMode):
329326
replication before it will no longer be selected for operations.
330327
Default -1, meaning no maximum. If it is set, it must be at least
331328
90 seconds.
332-
:param hedge: The :attr:`~hedge` to use if the primary is not available.
329+
:param hedge: **DEPRECATED** - The :attr:`~hedge` for this read preference.
333330
334331
.. versionchanged:: 3.11
335332
Added ``hedge`` parameter.
@@ -371,7 +368,7 @@ class Secondary(_ServerMode):
371368
replication before it will no longer be selected for operations.
372369
Default -1, meaning no maximum. If it is set, it must be at least
373370
90 seconds.
374-
:param hedge: The :attr:`~hedge` for this read preference.
371+
:param hedge: **DEPRECATED** - The :attr:`~hedge` for this read preference.
375372
376373
.. versionchanged:: 3.11
377374
Added ``hedge`` parameter.
@@ -414,7 +411,7 @@ class SecondaryPreferred(_ServerMode):
414411
replication before it will no longer be selected for operations.
415412
Default -1, meaning no maximum. If it is set, it must be at least
416413
90 seconds.
417-
:param hedge: The :attr:`~hedge` for this read preference.
414+
:param hedge: **DEPRECATED** - The :attr:`~hedge` for this read preference.
418415
419416
.. versionchanged:: 3.11
420417
Added ``hedge`` parameter.
@@ -458,7 +455,7 @@ class Nearest(_ServerMode):
458455
replication before it will no longer be selected for operations.
459456
Default -1, meaning no maximum. If it is set, it must be at least
460457
90 seconds.
461-
:param hedge: The :attr:`~hedge` for this read preference.
458+
:param hedge: **DEPRECATED** - The :attr:`~hedge` for this read preference.
462459
463460
.. versionchanged:: 3.11
464461
Added ``hedge`` parameter.

0 commit comments

Comments
 (0)