cleanup

Author: sleepyStick

pymongo/asynchronous/topology.py

@@ -567,6 +567,7 @@ async def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
         if td_old.topology_type not in SRV_POLLING_TOPOLOGIES:
             return
         self._description = _updated_topology_description_srv_polling(self._description, seedlist)
+
         await self._update_servers()
 
         if self._publish_tp:
@@ -982,6 +983,7 @@ def _create_pool_for_monitor(self, address: _Address) -> Pool:
             pause_enabled=False,
             server_api=options.server_api,
         )
+
         return self._settings.pool_class(
             address, monitor_pool_options, handshake=False, client_id=self._topology_id
         )

pymongo/synchronous/topology.py

@@ -567,6 +567,7 @@ def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
         if td_old.topology_type not in SRV_POLLING_TOPOLOGIES:
             return
         self._description = _updated_topology_description_srv_polling(self._description, seedlist)
+
         self._update_servers()
 
         if self._publish_tp:
@@ -980,6 +981,7 @@ def _create_pool_for_monitor(self, address: _Address) -> Pool:
             pause_enabled=False,
             server_api=options.server_api,
         )
+
         return self._settings.pool_class(
             address, monitor_pool_options, handshake=False, client_id=self._topology_id
         )

test/asynchronous/test_client.py

@@ -903,7 +903,6 @@ async def test_repr(self):
             connect=False,
             document_class=SON,
         )
-        await client.aconnect()
         the_repr = repr(client)
         self.assertIn("AsyncMongoClient(host=", the_repr)
         self.assertIn("document_class=bson.son.SON, tz_aware=False, connect=False, ", the_repr)
@@ -925,7 +924,6 @@ async def test_repr(self):
             wtimeoutms=100,
             connect=False,
         )
-        await client.aconnect()
         the_repr = repr(client)
         self.assertIn("AsyncMongoClient(host=", the_repr)
         self.assertIn("document_class=dict, tz_aware=False, connect=False, ", the_repr)
@@ -1623,8 +1621,7 @@ def init(self, *args):
     async def test_small_heartbeat_frequency_ms(self):
         uri = "mongodb://example/?heartbeatFrequencyMS=499"
         with self.assertRaises(ConfigurationError) as context:
-            client = AsyncMongoClient(uri)
-            await client.aconnect()
+            AsyncMongoClient(uri)
 
         self.assertIn("heartbeatFrequencyMS", str(context.exception))
 

test/asynchronous/test_dns.py

@@ -141,6 +141,7 @@ async def run_test(self):
                     # Our test certs don't support the SRV hosts used in these
                     # tests.
                     copts["tlsAllowInvalidHostnames"] = True
+
                 client = self.simple_client(uri, **copts)
                 if client._options.connect:
                     await client.aconnect()

test/asynchronous/unified_format.py

@@ -1290,7 +1290,6 @@ def check_events(self, spec):
                 )
 
             for idx, expected_event in enumerate(events):
-                print(expected_event, actual_events[idx])
                 self.match_evaluator.match_event(expected_event, actual_events[idx])
 
             if has_server_connection_id:
@@ -1345,8 +1344,6 @@ def format_logs(log_list):
                 ignore_logs = client.get("ignoreMessages", [])
                 if ignore_logs:
                     actual_logs = self.process_ignore_messages(ignore_logs, actual_logs)
-                print(f"{ignore_logs=}")
-                print(f"{actual_logs=}")
 
                 if client.get("ignoreExtraMessages", False):
                     actual_logs = actual_logs[: len(client["messages"])]
@@ -1357,8 +1354,6 @@ def format_logs(log_list):
                 )
                 for expected_msg, actual_msg in zip(client["messages"], actual_logs):
                     expected_data, actual_data = expected_msg.pop("data"), actual_msg.pop("data")
-                    print(f"{expected_data=}")
-                    print(f"{actual_data=}")
                     if "failureIsRedacted" in expected_msg:
                         self.assertIn("failure", actual_data)
                         should_redact = expected_msg.pop("failureIsRedacted")

test/test_client.py

@@ -878,7 +878,6 @@ def test_repr(self):
             connect=False,
             document_class=SON,
         )
-        client._connect()
         the_repr = repr(client)
         self.assertIn("MongoClient(host=", the_repr)
         self.assertIn("document_class=bson.son.SON, tz_aware=False, connect=False, ", the_repr)
@@ -900,7 +899,6 @@ def test_repr(self):
             wtimeoutms=100,
             connect=False,
         )
-        client._connect()
         the_repr = repr(client)
         self.assertIn("MongoClient(host=", the_repr)
         self.assertIn("document_class=dict, tz_aware=False, connect=False, ", the_repr)
@@ -1580,8 +1578,7 @@ def init(self, *args):
     def test_small_heartbeat_frequency_ms(self):
         uri = "mongodb://example/?heartbeatFrequencyMS=499"
         with self.assertRaises(ConfigurationError) as context:
-            client = MongoClient(uri)
-            client._connect()
+            MongoClient(uri)
 
         self.assertIn("heartbeatFrequencyMS", str(context.exception))
 

test/test_dns.py

@@ -141,6 +141,7 @@ def run_test(self):
                     # Our test certs don't support the SRV hosts used in these
                     # tests.
                     copts["tlsAllowInvalidHostnames"] = True
+
                 client = self.simple_client(uri, **copts)
                 if client._options.connect:
                     client._connect()

test/unified_format.py

@@ -1277,7 +1277,6 @@ def check_events(self, spec):
                 )
 
             for idx, expected_event in enumerate(events):
-                print(expected_event, actual_events[idx])
                 self.match_evaluator.match_event(expected_event, actual_events[idx])
 
             if has_server_connection_id:
@@ -1332,8 +1331,6 @@ def format_logs(log_list):
                 ignore_logs = client.get("ignoreMessages", [])
                 if ignore_logs:
                     actual_logs = self.process_ignore_messages(ignore_logs, actual_logs)
-                print(f"{ignore_logs=}")
-                print(f"{actual_logs=}")
 
                 if client.get("ignoreExtraMessages", False):
                     actual_logs = actual_logs[: len(client["messages"])]
@@ -1344,8 +1341,6 @@ def format_logs(log_list):
                 )
                 for expected_msg, actual_msg in zip(client["messages"], actual_logs):
                     expected_data, actual_data = expected_msg.pop("data"), actual_msg.pop("data")
-                    print(f"{expected_data=}")
-                    print(f"{actual_data=}")
                     if "failureIsRedacted" in expected_msg:
                         self.assertIn("failure", actual_data)
                         should_redact = expected_msg.pop("failureIsRedacted")