PYTHON-2099 Make ExceededTimeLimit a retryable writes error

Reinstate DuplicateKey code assertions.

Author: ShaneHarvey

pymongo/helpers.py

@@ -50,6 +50,7 @@
     6,     # HostUnreachable
     89,    # NetworkTimeout
     9001,  # SocketException
+    262,   # ExceededTimeLimit
 ])
 _UUNDER = u"_"
 

test/retryable_writes/insertOne-serverErrors.json

@@ -575,6 +575,54 @@
         }
       }
     },
+    {
+      "description": "InsertOne succeeds after ExceededTimeLimit",
+      "failPoint": {
+        "configureFailPoint": "failCommand",
+        "mode": {
+          "times": 1
+        },
+        "data": {
+          "failCommands": [
+            "insert"
+          ],
+          "writeConcernError": {
+            "code": 262,
+            "closeConnection": false
+          }
+        }
+      },
+      "operation": {
+        "name": "insertOne",
+        "arguments": {
+          "document": {
+            "_id": 3,
+            "x": 33
+          }
+        }
+      },
+      "outcome": {
+        "result": {
+          "insertedId": 3
+        },
+        "collection": {
+          "data": [
+            {
+              "_id": 1,
+              "x": 11
+            },
+            {
+              "_id": 2,
+              "x": 22
+            },
+            {
+              "_id": 3,
+              "x": 33
+            }
+          ]
+        }
+      }
+    },
     {
       "description": "InsertOne fails after Interrupted",
       "failPoint": {

test/transactions-convenient-api/callback-retry.json

@@ -235,7 +235,8 @@
             "errorLabelsOmit": [
               "TransientTransactionError",
               "UnknownTransactionCommitResult"
-            ]
+            ],
+            "errorContains": "E11000"
           }
         }
       ],

test/transactions/abort.json

@@ -458,7 +458,8 @@
             "errorLabelsOmit": [
               "TransientTransactionError",
               "UnknownTransactionCommitResult"
-            ]
+            ],
+            "errorContains": "E11000"
           }
         },
         {

test/transactions/error-labels.json

@@ -42,7 +42,8 @@
             "errorLabelsOmit": [
               "TransientTransactionError",
               "UnknownTransactionCommitResult"
-            ]
+            ],
+            "errorContains": "E11000"
           }
         },
         {

test/utils_spec_runner.py

@@ -32,7 +32,9 @@
                      operations)
 from pymongo.command_cursor import CommandCursor
 from pymongo.cursor import Cursor
-from pymongo.errors import (OperationFailure, PyMongoError)
+from pymongo.errors import (BulkWriteError,
+                            OperationFailure,
+                            PyMongoError)
 from pymongo.read_concern import ReadConcern
 from pymongo.read_preferences import ReadPreference
 from pymongo.results import _WriteResult, BulkWriteResult
@@ -375,8 +377,12 @@ def run_operations(self, sessions, collection, ops,
                     self.run_operation(sessions, collection, op.copy())
 
                 if expect_error_message(expected_result):
+                    if isinstance(context.exception, BulkWriteError):
+                        errmsg = str(context.exception.details).lower()
+                    else:
+                        errmsg = str(context.exception).lower()
                     self.assertIn(expected_result['errorContains'].lower(),
-                                  str(context.exception).lower())
+                                  errmsg)
                 if expect_error_code(expected_result):
                     self.assertEqual(expected_result['errorCodeName'],
                                      context.exception.details.get('codeName'))