RUST-1440 Bump clippy version to 1.63 (#729)

Author: abr-egn

.evergreen/check-clippy.sh

@@ -6,7 +6,7 @@ source ./.evergreen/configure-rust.sh
 source ./.evergreen/feature-combinations.sh
 
 # Pin clippy to the latest version. This should be updated when new versions of Rust are released.
-CLIPPY_VERSION=1.61.0
+CLIPPY_VERSION=1.63.0
 
 rustup install $CLIPPY_VERSION
 

src/client/csfle/state_machine.rs

@@ -140,7 +140,7 @@ impl CryptExecutor {
                             )
                             .await?;
                             stream.write_all(kms_ctx.message()?).await?;
-                            let mut buf = vec![];
+                            let mut buf = vec![0];
                             while kms_ctx.bytes_needed() > 0 {
                                 let buf_size = kms_ctx.bytes_needed().try_into().map_err(|e| {
                                     Error::internal(format!("buffer size overflow: {}", e))

src/client/options/mod.rs

@@ -7,7 +7,7 @@ use std::{
     cmp::Ordering,
     collections::HashSet,
     convert::TryFrom,
-    fmt::{self, Display, Formatter},
+    fmt::{self, Display, Formatter, Write},
     hash::{Hash, Hasher},
     path::PathBuf,
     str::FromStr,
@@ -2153,10 +2153,11 @@ impl ConnectionString {
                 });
                 let mut message = format!("{} is an invalid option", other);
                 if jaro_winkler >= 0.84 {
-                    message.push_str(&format!(
+                    let _ = write!(
+                        message,
                         ". An option with a similar name exists: {}",
                         option
-                    ));
+                    );
                 }
                 return Err(ErrorKind::InvalidArgument { message }.into());
             }

src/cursor/mod.rs

@@ -427,10 +427,9 @@ impl GetMoreProvider for ImplicitSessionGetMoreProvider {
         match self {
             Self::Idle(ref mut session) => Box::pin(async move {
                 let get_more = GetMore::new(info, pinned_connection.handle());
-                let get_more_result = client
+                client
                     .execute_operation(get_more, session.as_mut().map(|b| b.as_mut()))
-                    .await;
-                get_more_result
+                    .await
             }),
             Self::Executing(_fut) => Box::pin(async {
                 Err(Error::internal(

src/lib.rs

@@ -297,7 +297,8 @@
     allow(
         clippy::unreadable_literal,
         clippy::cognitive_complexity,
-        clippy::float_cmp
+        clippy::float_cmp,
+        clippy::derive_partial_eq_without_eq
     )
 )]
 #![cfg_attr(docsrs, feature(doc_cfg))]

src/test/spec/unified_runner/test_file.rs

@@ -1,4 +1,4 @@
-use std::{sync::Arc, time::Duration};
+use std::{fmt::Write, sync::Arc, time::Duration};
 
 use semver::{Version, VersionReq};
 use serde::{Deserialize, Deserializer};
@@ -212,7 +212,7 @@ pub(crate) fn merge_uri_options(given_uri: &str, uri_options: Option<&Document>)
         let value = value.to_string();
         // to_string() wraps quotations around Bson strings
         let value = value.trim_start_matches('\"').trim_end_matches('\"');
-        uri.push_str(&format!("{}={}&", &key, value));
+        let _ = write!(uri, "{}={}&", &key, value);
     }
 
     // remove the trailing '&' from the URI (or '?' if no options are present)