RUST-396 Parse responses with command errors into Errors in run_command (#174)

Author: patrickfreed

src/client/executor.rs

@@ -181,12 +181,7 @@ impl Client {
                         session.advance_cluster_time(cluster_time)
                     }
                 }
-
-                if !op.handles_command_errors() {
-                    response.validate().map(|_| response)
-                } else {
-                    Ok(response)
-                }
+                response.validate().map(|_| response)
             }
             err => err,
         };

src/operation/mod.rs

@@ -62,12 +62,6 @@ pub(crate) trait Operation {
         None
     }
 
-    /// Whether or not the operation has special handling for command errors, or whether they should
-    /// just be propogated to the user immediately.
-    fn handles_command_errors(&self) -> bool {
-        false
-    }
-
     /// Whether or not this operation will request acknowledgment from the server.
     fn is_acknowledged(&self) -> bool {
         self.write_concern()

src/operation/run_command/mod.rs

@@ -69,10 +69,6 @@ impl Operation for RunCommand {
         Ok(response.raw_response)
     }
 
-    fn handles_command_errors(&self) -> bool {
-        true
-    }
-
     fn selection_criteria(&self) -> Option<&SelectionCriteria> {
         self.selection_criteria.as_ref()
     }

src/test/client.rs

@@ -467,7 +467,7 @@ async fn scram_missing_user_options() {
 
 #[cfg_attr(feature = "tokio-runtime", tokio::test)]
 #[cfg_attr(feature = "async-std-runtime", async_std::test)]
-async fn saslprep_options() {
+async fn saslprep() {
     let client = TestClient::new().await;
 
     if client.server_version_lt(4, 0) || !client.auth_enabled() {
@@ -497,35 +497,6 @@ async fn saslprep_options() {
     auth_test_options("IX", "I\u{00AD}X", None, true).await;
     auth_test_options("\u{2168}", "IV", None, true).await;
     auth_test_options("\u{2168}", "I\u{00AD}V", None, true).await;
-}
-
-#[cfg_attr(feature = "tokio-runtime", tokio::test)]
-#[cfg_attr(feature = "async-std-runtime", async_std::test)]
-async fn saslprep_uri() {
-    let client = TestClient::new().await;
-
-    if client.server_version_lt(4, 0) || !client.auth_enabled() {
-        return;
-    }
-
-    client
-        .create_user(
-            "IX",
-            "IX",
-            &[Bson::from("root")],
-            &[AuthMechanism::ScramSha256],
-        )
-        .await
-        .unwrap();
-    client
-        .create_user(
-            "\u{2168}",
-            "\u{2163}",
-            &[Bson::from("root")],
-            &[AuthMechanism::ScramSha256],
-        )
-        .await
-        .unwrap();
 
     auth_test_uri("IX", "IX", None, true).await;
     auth_test_uri("IX", "I%C2%ADX", None, true).await;