SERVER-34583 Clean up transaction error codes.

Author: mtrussotto

src/mongo/base/error_codes.err

@@ -241,7 +241,7 @@ error_code("DNSRecordTypeMismatch", 240)
 error_code("ConversionFailure", 241)
 error_code("CannotCreateCollection", 242)
 error_code("IncompatibleWithUpgradedServer", 243)
-error_code("TransactionAborted", 244)
+error_code("NOT_YET_AVAILABLE_TransactionAborted", 244)
 error_code("BrokenPromise", 245)
 error_code("SnapshotUnavailable", 246)
 error_code("ProducerConsumerQueueBatchTooLarge", 247)

src/mongo/db/session.cpp

@@ -959,7 +959,7 @@ void Session::_commitTransaction(stdx::unique_lock<stdx::mutex> lk, OperationCon
         lk.lock();
         // It's possible some other thread aborted the transaction (e.g. through killSession) while
         // the opObserver was running.  If that happened, the commit should be reported as failed.
-        uassert(ErrorCodes::TransactionAborted,
+        uassert(ErrorCodes::NoSuchTransaction,
                 str::stream() << "Transaction " << opCtx->getTxnNumber()
                               << " aborted while attempting to commit",
                 _txnState == MultiDocumentTransactionState::kInProgress &&
@@ -1044,7 +1044,7 @@ void Session::_checkIsActiveTransaction(WithLock, TxnNumber txnNumber, bool chec
                           << " is now active.",
             txnNumber == _activeTxnNumber);
 
-    uassert(ErrorCodes::TransactionAborted,
+    uassert(ErrorCodes::NoSuchTransaction,
             str::stream() << "Transaction " << txnNumber << " has been aborted.",
             !checkAbort || _txnState != MultiDocumentTransactionState::kAborted);
 }

src/mongo/db/session_test.cpp

@@ -1058,7 +1058,7 @@ TEST_F(SessionTest, ConcurrencyOfAddTransactionOperationAndAbort) {
     auto operation = repl::OplogEntry::makeInsertOperation(kNss, kUUID, BSON("TestValue" << 0));
     ASSERT_THROWS_CODE(session.addTransactionOperation(opCtx(), operation),
                        AssertionException,
-                       ErrorCodes::TransactionAborted);
+                       ErrorCodes::NoSuchTransaction);
 }
 
 TEST_F(SessionTest, ConcurrencyOfAddTransactionOperationAndMigration) {
@@ -1108,7 +1108,7 @@ TEST_F(SessionTest, ConcurrencyOfEndTransactionAndRetrieveOperationsAndAbort) {
     // An endTransactionAndRetrieveOperations() after an abort should uassert.
     ASSERT_THROWS_CODE(session.endTransactionAndRetrieveOperations(opCtx()),
                        AssertionException,
-                       ErrorCodes::TransactionAborted);
+                       ErrorCodes::NoSuchTransaction);
 }
 
 TEST_F(SessionTest, ConcurrencyOfEndTransactionAndRetrieveOperationsAndMigration) {
@@ -1157,7 +1157,7 @@ TEST_F(SessionTest, ConcurrencyOfCommitTransactionAndAbort) {
 
     // An commitTransaction() after an abort should uassert.
     ASSERT_THROWS_CODE(
-        session.commitTransaction(opCtx()), AssertionException, ErrorCodes::TransactionAborted);
+        session.commitTransaction(opCtx()), AssertionException, ErrorCodes::NoSuchTransaction);
 }
 
 TEST_F(SessionTest, ConcurrencyOfCommitTransactionAndMigration) {