SERVER-43399 Log more in DeleteOpIsIdBased test

Also clean up unused function in repltests.cpp.

Author: ajdavis

src/mongo/db/storage/wiredtiger/wiredtiger_oplog_manager.cpp

@@ -140,8 +140,8 @@ void WiredTigerOplogManager::waitForAllEarlierOplogWritesToBeVisible(
         currentLatestVisibleTimestamp = newLatestVisibleTimestamp;
         RecordId latestVisible = RecordId(currentLatestVisibleTimestamp);
         if (latestVisible < waitingFor) {
-            LOG(2) << "Operation is waiting for " << waitingFor << "; latestVisible is "
-                   << Timestamp(currentLatestVisibleTimestamp);
+            LOG(2) << "Operation is waiting for " << Timestamp(waitingFor.repr())
+                   << "; latestVisible is " << Timestamp(currentLatestVisibleTimestamp);
         }
         return latestVisible >= waitingFor;
     });

src/mongo/dbtests/repltests.cpp

@@ -47,13 +47,17 @@
 #include "mongo/db/repl/replication_coordinator_mock.h"
 #include "mongo/db/s/op_observer_sharding_impl.h"
 #include "mongo/dbtests/dbtests.h"
+#include "mongo/logger/logger.h"
 #include "mongo/transport/transport_layer_asio.h"
 #include "mongo/util/log.h"
 
 using namespace mongo::repl;
 
 namespace ReplTests {
 
+using mongo::logger::globalLogDomain;
+using mongo::logger::LogComponent;
+using mongo::logger::LogSeverity;
 using std::endl;
 using std::string;
 using std::stringstream;
@@ -258,25 +262,6 @@ class Base {
             }
         }
     }
-    void printAll(const char* ns) {
-        Lock::GlobalWrite lk(&_opCtx);
-        OldClientContext ctx(&_opCtx, ns);
-        NamespaceString nss(ns);
-
-        Database* db = ctx.db();
-        Collection* coll = CollectionCatalog::get(&_opCtx).lookupCollectionByNamespace(nss);
-        if (!coll) {
-            WriteUnitOfWork wunit(&_opCtx);
-            coll = db->createCollection(&_opCtx, nss);
-            wunit.commit();
-        }
-
-        auto cursor = coll->getCursor(&_opCtx);
-        ::mongo::log() << "all for " << ns << endl;
-        while (auto record = cursor->next()) {
-            ::mongo::log() << record->data.releaseToBson() << endl;
-        }
-    }
     // These deletes don't get logged.
     void deleteAll(const char* ns) const {
         ::mongo::writeConflictRetry(&_opCtx, "deleteAll", ns, [&] {
@@ -1312,11 +1297,22 @@ class ReplayArrayFieldNotAppended : public Base {
 
 class DeleteOpIsIdBased : public Base {
 public:
+    DeleteOpIsIdBased() : _oldSeverity(globalLogDomain()->getMinimumLogSeverity()) {
+        // TODO (SERVER-43399): This is temporary to help diagnose a rare failure.
+        globalLogDomain()->setMinimumLoggedSeverity(LogComponent::kDefault, LogSeverity::Debug(2));
+    }
+
+    ~DeleteOpIsIdBased() {
+        globalLogDomain()->setMinimumLoggedSeverity(LogComponent::kDefault, _oldSeverity);
+    }
+
     void run() {
         // Replication is not supported by mobile SE.
         if (mongo::storageGlobalParams.engine == "mobile") {
             return;
         }
+
+        // These inserts don't write oplog entries.
         insert(BSON("_id" << 0 << "a" << 10));
         insert(BSON("_id" << 1 << "a" << 11));
         insert(BSON("_id" << 3 << "a" << 10));
@@ -1325,12 +1321,16 @@ class DeleteOpIsIdBased : public Base {
         insert(BSON("_id" << 0 << "a" << 11));
         insert(BSON("_id" << 2 << "a" << 10));
         insert(BSON("_id" << 3 << "a" << 10));
-
+        // Now the collection has _ids 0, 1, 2, 3. Apply the delete oplog entries for _id 0 and 3.
         applyAllOperations();
+        // _id 1 and 2 remain.
         ASSERT_EQUALS(2U, _client.count(nss(), BSONObj()));
         ASSERT(!one(BSON("_id" << 1)).isEmpty());
         ASSERT(!one(BSON("_id" << 2)).isEmpty());
     }
+
+private:
+    LogSeverity _oldSeverity;
 };
 
 class All : public OldStyleSuiteSpecification {