SERVER-83391 Robustify tests affected by the background listIndex command in replica-set suites

RuoxinXu · Evergreen Agent · commit a23fbbe04835 · 2023-11-21T19:39:17.000Z
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/bulk_write_causally_consistent_jscore_passthrough.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/bulk_write_causally_consistent_jscore_passthrough.yml
@@ -65,6 +65,7 @@ selector:
   - src/mongo/db/modules/enterprise/jstests/fle2/basic_delete.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   - assumes_read_preference_unchanged
   - does_not_support_causal_consistency
   - requires_collstats
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/bulk_write_replica_sets_jscore_passthrough.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/bulk_write_replica_sets_jscore_passthrough.yml
@@ -64,6 +64,7 @@ selector:
   - src/mongo/db/modules/enterprise/jstests/fle2/basic_delete.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/change_streams_pre_images_replica_sets_kill_secondary_jscore_passthrough.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/change_streams_pre_images_replica_sets_kill_secondary_jscore_passthrough.yml
@@ -51,6 +51,7 @@ selector:
   - jstests/core/**/exhaust.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   - requires_emptycapped
   - incompatible_with_preimages_by_default
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check.yml
@@ -46,6 +46,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_continuous_new_new_old.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_continuous_new_new_old.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_continuous_new_old_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_continuous_new_old_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_continuous_old_new_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_continuous_old_new_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_lts_new_new_old.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_lts_new_new_old.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_lts_new_old_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_lts_new_old_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_lts_old_new_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/multiversion_sanity_check_last_lts_old_new_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   include_with_any_tags:
   - multiversion_sanity_check
   roots:
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_continuous_new_new_old.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_continuous_new_new_old.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_continuous_new_old_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_continuous_new_old_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_continuous_old_new_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_continuous_old_new_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_lts_new_new_old.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_lts_new_new_old.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_lts_new_old_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_lts_new_old_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_lts_old_new_new.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_jscore_passthrough_last_lts_old_new_new.yml
@@ -48,6 +48,7 @@ selector:
   - jstests/core/txns/prepare_conflict.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   roots:
   - jstests/core/**/*.js
   - jstests/fle2/**/*.js
diff --git a/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_kill_secondaries_jscore_passthrough.yml b/buildscripts/resmokeconfig/matrix_suites/generated_suites/replica_sets_kill_secondaries_jscore_passthrough.yml
@@ -41,6 +41,7 @@ selector:
   - jstests/core/**/exhaust.js
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  - requires_profiling
   - requires_emptycapped
   roots:
   - jstests/core/*.js
diff --git a/buildscripts/resmokeconfig/suites/replica_sets_jscore_passthrough.yml b/buildscripts/resmokeconfig/suites/replica_sets_jscore_passthrough.yml
@@ -39,6 +39,10 @@ selector:
 
   exclude_with_any_tags:
   - assumes_standalone_mongod
+  # After SERVER-80339, the server runs a "listIndexes" command on the background, which could show
+  # up during profiling. Some profiling tests expect a certain command other than this "listIndexes"
+  # command.
+  - requires_profiling
 
 executor:
   archive:
diff --git a/jstests/core/operation_latency_histogram.js b/jstests/core/operation_latency_histogram.js
@@ -59,21 +59,21 @@ var numRecords = 100;
 for (var i = 0; i < numRecords; i++) {
     assert.commandWorked(testColl.insert({_id: i}));
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, numRecords, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, numRecords, 0);
 
 // Update
 for (var i = 0; i < numRecords; i++) {
     assert.commandWorked(testColl.update({_id: i}, {x: i}));
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, numRecords, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, numRecords, 0);
 
 // Find
 var cursors = [];
 for (var i = 0; i < numRecords; i++) {
     cursors[i] = testColl.find({x: {$gte: i}}).batchSize(2);
     assert.eq(cursors[i].next()._id, i);
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, numRecords, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, numRecords, 0, 0);
 
 // GetMore
 for (var i = 0; i < numRecords / 2; i++) {
@@ -83,46 +83,46 @@ for (var i = 0; i < numRecords / 2; i++) {
     assert.eq(cursors[i].next()._id, i + 3);
     assert.eq(cursors[i].next()._id, i + 4);
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, numRecords, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, numRecords, 0, 0);
 
 // KillCursors
 // The last cursor has no additional results, hence does not need to be closed.
 for (var i = 0; i < numRecords - 1; i++) {
     cursors[i].close();
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, numRecords - 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, numRecords - 1);
 
 // Remove
 for (var i = 0; i < numRecords; i++) {
     assert.commandWorked(testColl.remove({_id: i}));
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, numRecords, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, numRecords, 0);
 
 // Upsert
 for (var i = 0; i < numRecords; i++) {
     assert.commandWorked(testColl.update({_id: i}, {x: i}, {upsert: 1}));
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, numRecords, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, numRecords, 0);
 
 // Aggregate
 for (var i = 0; i < numRecords; i++) {
     testColl.aggregate([{$match: {x: i}}, {$group: {_id: "$x"}}]);
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, numRecords, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, numRecords, 0, 0);
 
 // Count
 for (var i = 0; i < numRecords; i++) {
     testColl.count({x: i});
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, numRecords, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, numRecords, 0, 0);
 
 // FindAndModify
 testColl.findAndModify({query: {}, update: {pt: {type: "Point", coordinates: [0, 0]}}});
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 1, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 1, 0);
 
 // CreateIndex
 assert.commandWorked(testColl.createIndex({pt: "2dsphere"}));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // $geoNear aggregation stage
 assert.commandWorked(testDB.runCommand({
@@ -136,35 +136,35 @@ assert.commandWorked(testDB.runCommand({
     }],
     cursor: {},
 }));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 1, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 1, 0, 0);
 
 // GetIndexes
 testColl.getIndexes();
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // Reindex (Only standalone mode supports the reIndex command.)
 const hello = db.runCommand({hello: 1});
 const isStandalone = !FixtureHelpers.isMongos(db) && !hello.hasOwnProperty('setName');
 if (isStandalone) {
     assert.commandWorked(testColl.reIndex());
-    lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+    lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 }
 
 // DropIndex
 assert.commandWorked(testColl.dropIndex({pt: "2dsphere"}));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // Explain
 testColl.explain().find().next();
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // CollStats
 assert.commandWorked(testDB.runCommand({collStats: testColl.getName()}));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // CollMod
 assert.commandWorked(testDB.runCommand({collStats: testColl.getName(), validationLevel: "off"}));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // Compact
 // Use force:true in case we're in replset.
@@ -173,23 +173,23 @@ var commandResult = testDB.runCommand({compact: testColl.getName(), force: true}
 if (!commandResult.ok) {
     assert.commandFailedWithCode(commandResult, ErrorCodes.CommandNotSupported);
 }
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // DataSize
 testColl.dataSize();
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // PlanCache
 testColl.getPlanCache().clear();
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 1);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 1);
 
 // Commands which occur on the database only should not effect the collection stats.
 assert.commandWorked(testDB.serverStatus());
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 0);
 
 assert.commandWorked(testColl.runCommand("whatsmyuri"));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 0);
 
 // Test non-command.
 assert.commandFailed(testColl.runCommand("IHopeNobodyEverMakesThisACommand"));
-lastHistogram = assertHistogramDiffEq(testColl, lastHistogram, 0, 0, 0);
+lastHistogram = assertHistogramDiffEq(testDB, testColl, lastHistogram, 0, 0, 0);
diff --git a/jstests/core/top.js b/jstests/core/top.js
diff --git a/jstests/core/views/views_stats.js b/jstests/core/views/views_stats.js
diff --git a/jstests/libs/stats.js b/jstests/libs/stats.js
