SERVER-41469 Enforce w:1 for creation of transactions table on step-up

Author: jasonjhchan

src/mongo/db/SConscript

@@ -1793,6 +1793,7 @@ envWithAsio.CppUnitTest(
         'repl/mock_repl_coord_server_fixture',
         'repl/oplog_interface_local',
         'repl/repl_coordinator_interface',
+        'repl/storage_interface_impl',
         'repl/replmocks',
         'server_options_servers',
         'service_context',

src/mongo/db/op_observer_impl_test.cpp

@@ -42,7 +42,7 @@
 #include "mongo/db/repl/oplog_interface_local.h"
 #include "mongo/db/repl/repl_client_info.h"
 #include "mongo/db/repl/replication_coordinator_mock.h"
-#include "mongo/db/repl/storage_interface_mock.h"
+#include "mongo/db/repl/storage_interface_impl.h"
 #include "mongo/db/service_context_d_test_fixture.h"
 #include "mongo/db/session_catalog_mongod.h"
 #include "mongo/db/storage/ephemeral_for_test/ephemeral_for_test_recovery_unit.h"
@@ -65,7 +65,8 @@ class OpObserverTest : public ServiceContextMongoDTest {
 
         auto service = getServiceContext();
         auto opCtx = cc().makeOperationContext();
-        repl::StorageInterface::set(service, std::make_unique<repl::StorageInterfaceMock>());
+        // onStepUp() relies on the storage interface to create the config.transactions table.
+        repl::StorageInterface::set(service, std::make_unique<repl::StorageInterfaceImpl>());
 
         // Set up ReplicationCoordinator and create oplog.
         repl::ReplicationCoordinator::set(

src/mongo/db/repl/do_txn_test.cpp

@@ -41,7 +41,6 @@
 #include "mongo/db/repl/repl_client_info.h"
 #include "mongo/db/repl/replication_coordinator_mock.h"
 #include "mongo/db/repl/storage_interface_impl.h"
-#include "mongo/db/repl/storage_interface_mock.h"
 #include "mongo/db/s/op_observer_sharding_impl.h"
 #include "mongo/db/service_context_d_test_fixture.h"
 #include "mongo/db/session_catalog_mongod.h"
@@ -156,6 +155,9 @@ void DoTxnTest::setUp() {
     auto replCoord = ReplicationCoordinator::get(_opCtx.get());
     ASSERT_OK(replCoord->setFollowerMode(MemberState::RS_PRIMARY));
 
+    // onStepUp() relies on the storage interface to create the config.transactions table.
+    repl::StorageInterface::set(service, std::make_unique<StorageInterfaceImpl>());
+
     // Set up session catalog
     MongoDSessionCatalog::onStepUp(_opCtx.get());
 
@@ -173,11 +175,6 @@ void DoTxnTest::setUp() {
     // collections.
     _storage = std::make_unique<StorageInterfaceImpl>();
 
-    // We also need to give replication a StorageInterface for checking out the transaction.
-    // The test storage engine doesn't support the necessary call (getPointInTimeReadTimestamp()),
-    // so we use a mock.
-    repl::StorageInterface::set(service, std::make_unique<StorageInterfaceMock>());
-
     // Set up the transaction and session.
     _opCtx->setLogicalSessionId(makeLogicalSessionIdForTest());
     _opCtx->setTxnNumber(0);  // TxnNumber can always be 0 because we have a new session.

src/mongo/db/s/SConscript

@@ -384,6 +384,7 @@ env.CppUnitTest(
         '$BUILD_DIR/mongo/db/ops/write_ops_exec',
         '$BUILD_DIR/mongo/db/query/query_request',
         '$BUILD_DIR/mongo/db/repl/mock_repl_coord_server_fixture',
+        '$BUILD_DIR/mongo/db/repl/storage_interface_impl',
         '$BUILD_DIR/mongo/s/catalog/dist_lock_manager_mock',
         '$BUILD_DIR/mongo/s/catalog/sharding_catalog_client_impl',
         '$BUILD_DIR/mongo/s/catalog/sharding_catalog_client_mock',

src/mongo/db/s/session_catalog_migration_destination_test.cpp

@@ -42,6 +42,7 @@
 #include "mongo/db/ops/write_ops_exec.h"
 #include "mongo/db/ops/write_ops_gen.h"
 #include "mongo/db/repl/oplog_entry.h"
+#include "mongo/db/repl/storage_interface_impl.h"
 #include "mongo/db/s/migration_session_id.h"
 #include "mongo/db/s/session_catalog_migration_destination.h"
 #include "mongo/db/server_options.h"
@@ -131,7 +132,9 @@ class SessionCatalogMigrationDestinationTest : public ShardServerTestFixture {
             RemoteCommandTargeterMock::get(donorShard->getTargeter())
                 ->setFindHostReturnValue(kDonorConnStr.getServers()[0]);
         }
-
+        // onStepUp() relies on the storage interface to create the config.transactions table.
+        repl::StorageInterface::set(getServiceContext(),
+                                    std::make_unique<repl::StorageInterfaceImpl>());
         MongoDSessionCatalog::onStepUp(operationContext());
         LogicalSessionCache::set(getServiceContext(), std::make_unique<LogicalSessionCacheNoop>());
     }

src/mongo/db/session_catalog_mongod.cpp

@@ -41,6 +41,7 @@
 #include "mongo/db/namespace_string.h"
 #include "mongo/db/operation_context.h"
 #include "mongo/db/ops/write_ops.h"
+#include "mongo/db/repl/storage_interface_impl.h"
 #include "mongo/db/service_context.h"
 #include "mongo/db/session_txn_record_gen.h"
 #include "mongo/db/sessions_collection.h"
@@ -175,23 +176,11 @@ int removeSessionsTransactionRecords(OperationContext* opCtx,
 }
 
 void createTransactionTable(OperationContext* opCtx) {
-    const size_t initialExtentSize = 0;
-    const bool capped = false;
-    const bool maxSize = 0;
-    BSONObj result;
-
-    DBDirectClient client(opCtx);
-
-    if (client.createCollection(NamespaceString::kSessionTransactionsTableNamespace.ns(),
-                                initialExtentSize,
-                                capped,
-                                maxSize,
-                                &result)) {
-        return;
-    }
-
-    const auto status = getStatusFromCommandResult(result);
-
+    auto serviceCtx = opCtx->getServiceContext();
+    CollectionOptions options;
+    auto status =
+        repl::StorageInterface::get(serviceCtx)
+            ->createCollection(opCtx, NamespaceString::kSessionTransactionsTableNamespace, options);
     if (status == ErrorCodes::NamespaceExists) {
         return;
     }

src/mongo/db/transaction_participant_retryable_writes_test.cpp

@@ -41,6 +41,7 @@
 #include "mongo/db/repl/oplog.h"
 #include "mongo/db/repl/oplog_entry.h"
 #include "mongo/db/repl/optime.h"
+#include "mongo/db/repl/storage_interface_impl.h"
 #include "mongo/db/server_options.h"
 #include "mongo/db/server_transactions_metrics.h"
 #include "mongo/db/service_context.h"
@@ -167,10 +168,9 @@ class TransactionParticipantRetryableWritesTest : public MockReplCoordServerFixt
 protected:
     void setUp() {
         MockReplCoordServerFixture::setUp();
-
-        MongoDSessionCatalog::onStepUp(opCtx());
-
         const auto service = opCtx()->getServiceContext();
+        repl::StorageInterface::set(service, std::make_unique<repl::StorageInterfaceImpl>());
+        MongoDSessionCatalog::onStepUp(opCtx());
 
         const auto opObserverRegistry = dynamic_cast<OpObserverRegistry*>(service->getOpObserver());
         opObserverRegistry->addObserver(std::make_unique<OpObserverMock>());

src/mongo/db/transaction_participant_test.cpp

@@ -42,6 +42,8 @@
 #include "mongo/db/repl/oplog.h"
 #include "mongo/db/repl/oplog_entry.h"
 #include "mongo/db/repl/optime.h"
+#include "mongo/db/repl/storage_interface_impl.h"
+#include "mongo/db/repl/storage_interface_mock.h"
 #include "mongo/db/server_transactions_metrics.h"
 #include "mongo/db/service_context.h"
 #include "mongo/db/session_catalog_mongod.h"
@@ -226,9 +228,18 @@ class TxnParticipantTest : public MockReplCoordServerFixture {
 protected:
     void setUp() override {
         MockReplCoordServerFixture::setUp();
+        const auto service = opCtx()->getServiceContext();
+        auto _storageInterfaceImpl = std::make_unique<repl::StorageInterfaceImpl>();
+
+        // onStepUp() relies on the storage interface to create the config.transactions table.
+        repl::StorageInterface::set(service, std::move(_storageInterfaceImpl));
         MongoDSessionCatalog::onStepUp(opCtx());
 
-        const auto service = opCtx()->getServiceContext();
+        // We use the mocked storage interface here since StorageInterfaceImpl does not support
+        // getPointInTimeReadTimestamp().
+        auto _storageInterfaceMock = std::make_unique<repl::StorageInterfaceMock>();
+        repl::StorageInterface::set(service, std::move(_storageInterfaceMock));
+
         OpObserverRegistry* opObserverRegistry =
             dynamic_cast<OpObserverRegistry*>(service->getOpObserver());
         auto mockObserver = std::make_unique<OpObserverMock>();
@@ -1520,6 +1531,9 @@ TEST_F(TxnParticipantTest, ReacquireLocksForPreparedTransactionsOnStepUp) {
 
     // Step-up will restore the locks of prepared transactions.
     ASSERT(opCtx()->writesAreReplicated());
+    const auto service = opCtx()->getServiceContext();
+    // onStepUp() relies on the storage interface to create the config.transactions table.
+    repl::StorageInterface::set(service, std::make_unique<repl::StorageInterfaceImpl>());
     MongoDSessionCatalog::onStepUp(opCtx());
     {
         auto sessionCheckout = checkOutSession({});