SERVER-83240 Create aggregation passthrough suite with unsharded collections placed on random shards

Author: jordist

buildscripts/resmokeconfig/suites/aggregation_unsplittable_collections_on_random_shard_passthrough.yml

@@ -0,0 +1,70 @@
+test_kind: js_test
+
+selector:
+  roots:
+  - jstests/aggregation/**/*.js
+  exclude_files:
+  - jstests/aggregation/extras/*.js
+  - jstests/aggregation/data/*.js
+  # TODO SERVER-32311: These tests use getAggPlanStage(), which can't handle sharded explain output.
+  - jstests/aggregation/match_swapping_renamed_fields.js
+  - jstests/aggregation/use_query_project_and_sort.js
+  - jstests/aggregation/use_query_projection.js
+  - jstests/aggregation/use_query_sort.js
+
+  # TODO: SERVER-83220 (Failing due to incorrect pushdown of $lookup for non-collocated collections).
+  # Reenable:
+  - jstests/aggregation/sources/facet/inner_lookup.js
+  - jstests/aggregation/sources/lookup/lookup_equijoin_semantics_inlj.js
+  - jstests/aggregation/sources/lookup/lookup_equijoin_semantics_nlj.js
+  - jstests/aggregation/sources/lookup/lookup_equijoin_semantics_hj.js
+  - jstests/aggregation/sources/lookup/lookup_collation.js
+  - jstests/aggregation/sources/lookup/lookup_foreign_collation.js
+  - jstests/aggregation/dbref.js
+
+  # TODO: SERVER-83351 (failing due to incorrect explain expectations). Reenable:
+  - jstests/aggregation/explain_writing_aggs.js
+  - jstests/aggregation/sources/unionWith/unionWith_explain.js
+  - jstests/aggregation/sources/indexStats/verify_index_stats_output.js
+  - jstests/aggregation/sources/lookup/lookup_single_solution_cache.js
+  - jstests/aggregation/spill_to_disk.js
+
+  # TODO: SERVER-83443 Reenable:
+  - jstests/aggregation/sources/lookup/lookup_contains_text.js
+
+  exclude_with_any_tags:
+  - assumes_against_mongod_not_mongos
+  - assumes_no_implicit_index_creation
+  - cannot_create_unique_index_when_using_hashed_shard_key
+  - requires_profiling
+
+  # This passthrough implicitly creates the accessed collections. Do not run tests where collections
+  # can't be created on `getCollection` call. (TODO SERVER-83396 Remove this).
+  - assumes_no_implicit_collection_creation_on_get_collection
+  - assumes_no_implicit_collection_creation_after_drop
+
+executor:
+  archive:
+    hooks:
+      - CheckReplDBHash
+      - CheckMetadataConsistencyInBackground
+      - ValidateCollections
+  config:
+    shell_options:
+      eval: await import("jstests/libs/override_methods/implicitly_create_unsplittable_collections_on_random_shards.js")
+  hooks:
+  - class: CheckReplDBHash
+  - class: CheckMetadataConsistencyInBackground
+  - class: ValidateCollections
+  - class: CheckOrphansDeleted
+  - class: CleanEveryN
+    n: 20
+  fixture:
+    class: ShardedClusterFixture
+    num_shards: 2
+    mongos_options:
+      set_parameters:
+        enableTestCommands: 1
+    mongod_options:
+      set_parameters:
+        enableTestCommands: 1

etc/evergreen_yml_components/definitions.yml

@@ -5524,6 +5524,16 @@ tasks:
   - func: "do setup"
   - func: "run tests"
 
+- <<: *gen_task_template
+  name: aggregation_unsplittable_collections_on_random_shard_passthrough
+  # TODO SERVER-83445 Enable on non-all-feature-flag variants.
+  tags: ["unsplittable_collections"]
+  depends_on:
+  - name: aggregation
+  commands:
+  - func: "do setup"
+  - func: "run tests"
+
 - <<: *task_template
   name: aggregation_column_store_index_passthrough
   # TODO SERVER-75026 Remove the 'feature_flag_guarded' tag and ensure this suite is run on all
@@ -6462,6 +6472,7 @@ tasks:
 
 - <<: *gen_task_template
   name: unsplittable_collections_created_on_any_shard_jscore_passthrough_gen
+  # TODO SERVER-83445 Enable on non-all-feature-flag variants.
   tags: ["unsplittable_collections"]
   commands:
   - func: "generate resmoke tasks"

jstests/aggregation/accumulators/internal_js_reduce_with_scope.js

@@ -3,7 +3,7 @@
 //
 // Do not run in sharded passthroughs since 'runtimeConstants' is disallowed on mongos.
 // @tags: [
-//   assumes_unsharded_collection,
+//   assumes_against_mongod_not_mongos,
 //   requires_scripting,
 // ]
 import {resultsEq} from "jstests/aggregation/extras/utils.js";
@@ -47,4 +47,4 @@ const expectedResults = [
 ];
 
 const res = assert.commandWorked(db.runCommand(command));
-assert(resultsEq(res.cursor.firstBatch, expectedResults, res.cursor));
+assert(resultsEq(res.cursor.firstBatch, expectedResults, res.cursor));

jstests/aggregation/expressions/internal_js_emit_with_scope.js

@@ -3,7 +3,7 @@
 //
 // Do not run in sharded passthroughs since 'runtimeConstants' is disallowed on mongos.
 // @tags: [
-//   assumes_unsharded_collection,
+//   assumes_against_mongod_not_mongos,
 //   requires_scripting,
 // ]
 import {resultsEq} from "jstests/aggregation/extras/utils.js";