SERVER-40496 Include namespace in configureFailpoint commands in transactions_snapshot_errors_subsequent_statements.js and transactions_writes_not_retryable.js

Author: JamesHeppenstall

jstests/sharding/libs/sharded_transactions_helpers.js

@@ -42,16 +42,29 @@ function getCoordinatorFailpoints() {
     return coordinatorFailpointDataArr.map(failpoint => Object.assign({}, failpoint));
 }
 
-function setFailCommandOnShards(st, mode, commands, code, numShards) {
+function setFailCommandOnShards(st, mode, commands, code, numShards, ns) {
     for (let i = 0; i < numShards; i++) {
         const shardConn = st["rs" + i].getPrimary();
         // Sharding tests require failInternalCommands: true, since the mongos appears to mongod to
         // be an internal client.
-        assert.commandWorked(shardConn.adminCommand({
-            configureFailPoint: "failCommand",
-            mode: mode,
-            data: {errorCode: code, failCommands: commands, failInternalCommands: true}
-        }));
+        if (ns) {
+            assert.commandWorked(shardConn.adminCommand({
+                configureFailPoint: "failCommand",
+                mode: mode,
+                data: {
+                    namespace: ns,
+                    errorCode: code,
+                    failCommands: commands,
+                    failInternalCommands: true
+                }
+            }));
+        } else {
+            assert.commandWorked(shardConn.adminCommand({
+                configureFailPoint: "failCommand",
+                mode: mode,
+                data: {errorCode: code, failCommands: commands, failInternalCommands: true}
+            }));
+        }
     }
 }
 

jstests/sharding/transactions_snapshot_errors_subsequent_statements.js

@@ -59,7 +59,7 @@ function runTest(st, collName, errorCode, isSharded) {
         assert.commandWorked(sessionDB.runCommand({find: collName, filter: {_id: 15}}));
 
         // Verify the command must fail on a snapshot error from a subsequent statement.
-        setFailCommandOnShards(st, {times: 1}, [commandName], errorCode, 1);
+        setFailCommandOnShards(st, {times: 1}, [commandName], errorCode, 1, ns);
         const res = assert.commandFailedWithCode(sessionDB.runCommand(commandBody), errorCode);
         assert.eq(res.errorLabels, ["TransientTransactionError"]);
 

jstests/sharding/transactions_writes_not_retryable.js

@@ -20,7 +20,12 @@ function runTest(st, session, sessionDB, writeCmdName, writeCmd, isSharded) {
     assert.commandWorked(st.rs0.getPrimary().adminCommand({
         configureFailPoint: "failCommand",
         mode: {times: 1},
-        data: {errorCode: retryableError, failCommands: [writeCmdName], failInternalCommands: true}
+        data: {
+            namespace: ns,
+            errorCode: retryableError,
+            failCommands: [writeCmdName],
+            failInternalCommands: true
+        }
     }));
 
     session.startTransaction();
@@ -36,7 +41,12 @@ function runTest(st, session, sessionDB, writeCmdName, writeCmd, isSharded) {
     assert.commandWorked(st.rs0.getPrimary().adminCommand({
         configureFailPoint: "failCommand",
         mode: {times: 1},
-        data: {closeConnection: true, failCommands: [writeCmdName], failInternalCommands: true}
+        data: {
+            namespace: ns,
+            closeConnection: true,
+            failCommands: [writeCmdName],
+            failInternalCommands: true
+        }
     }));
 
     session.startTransaction();