chore: remove test tags (#4089)

Author: fmenezes

.github/workflows/code-health.yml

@@ -50,6 +50,7 @@ jobs:
           go install github.com/mattn/[email protected]
       - run: make unit-test
       - name: Send coverage
+        if: matrix.os == 'ubuntu-latest'
         env:
           COVERALLS_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
         run: goveralls -parallel -coverprofile="$COVERAGE" -ignore=test/* -service=github

.github/workflows/update-e2e-tests.yml

@@ -13,53 +13,53 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        tags:
-          - atlas,autogeneration
-          - atlas,backup,compliancepolicy
-          - atlas,backup,flex
-          - atlas,backup,exports,buckets
-          - atlas,backup,exports,jobs
-          - atlas,backup,restores
-          - atlas,backup,schedule
-          - atlas,backup,snapshot
-          - atlas,clusters,file
-          - atlas,clusters,flags
-          - atlas,clusters,flex
-          - atlas,clusters,m0
-          - atlas,clusters,sharded
-          - atlas,clusters,upgrade
-          - atlas,datafederation,db
-          - atlas,datafederation,privatenetwork
-          - atlas,datafederation,querylimits
-          # - atlas,decrypt # requires live calls to GCP/AWS/Azure
-          # - atlas,deployments,atlasclusters # one assertion connects to DB (needs live mode)
-          # - atlas,deployments,local,auth,deprecated # needs docker to run
-          # - atlas,deployments,local,auth,new # needs docker to run
-          # - atlas,deployments,local,nocli # needs docker to run
-          # - atlas,deployments,local,noauth # needs docker to run
-          - atlas,generic
-          - atlas,interactive
-          - atlas,ldap
-          - atlas,livemigrations
-          - atlas,logs
-          - atlas,metrics
-          - atlas,networking
-          - atlas,onlinearchive
-          - atlas,performanceAdvisor
-          - atlas,plugin,install
-          - atlas,plugin,run
-          - atlas,plugin,uninstall
-          - atlas,plugin,update
-          - atlas,processes
-          - atlas,search
-          - atlas,search_nodes
-          - atlas,serverless,instance
-          - atlas,streams
-          - atlas,streams_with_cluster
-          - atlas,clusters,iss
+        packages:
+          - atlas/autogeneration
+          - atlas/backup/compliancepolicy
+          - atlas/backup/flex
+          - atlas/backup/exports/buckets
+          - atlas/backup/exports/jobs
+          - atlas/backup/restores
+          - atlas/backup/schedule
+          - atlas/backup/snapshot
+          - atlas/clusters/file
+          - atlas/clusters/flags
+          - atlas/clusters/flex
+          - atlas/clusters/m0
+          - atlas/clusters/sharded
+          - atlas/clusters/upgrade
+          - atlas/datafederation/db
+          - atlas/datafederation/privatenetwork
+          - atlas/datafederation/querylimits
+          - atlas/decrypt
+          - atlas/deployments/atlasclusters
+          - atlas/deployments/local/auth/deprecated
+          - atlas/deployments/local/auth/new
+          - atlas/deployments/local/nocli
+          - atlas/deployments/local/noauth
+          - atlas/generic
+          - atlas/interactive
+          - atlas/ldap
+          - atlas/livemigrations
+          - atlas/logs
+          - atlas/metrics
+          - atlas/networking
+          - atlas/onlinearchive
+          - atlas/performanceAdvisor
+          - atlas/plugin/install
+          - atlas/plugin/run
+          - atlas/plugin/uninstall
+          - atlas/plugin/update
+          - atlas/processes
+          - atlas/search
+          - atlas/search_nodes
+          - atlas/serverless/instance
+          - atlas/streams
+          - atlas/streams_with_cluster
+          - atlas/clusters/iss
+          - atlas/iam
           - brew
           - config
-          - atlas,iam
           - kubernetes
     steps:
       - uses: GitHubSecurityLab/actions-permissions/monitor@v1
@@ -78,7 +78,7 @@ jobs:
       - run: make e2e-test
         env:
           TEST_CMD: gotestsum --junitfile e2e-tests.xml --format standard-verbose --
-          E2E_TAGS: ${{ matrix.tags }}
+          E2E_TEST_PACKAGES: ./test/e2e/{{ matrix.packages }}..
           MONGODB_ATLAS_ORG_ID: ${{ secrets.MONGODB_ATLAS_ORG_ID }}
           MONGODB_ATLAS_PROJECT_ID: ${{ secrets.MONGODB_ATLAS_PROJECT_ID }}
           MONGODB_ATLAS_PUBLIC_API_KEY: ${{ secrets.MONGODB_ATLAS_PUBLIC_API_KEY }}
@@ -101,13 +101,14 @@ jobs:
           E2E_TIMEOUT: 3h
       - name: set artifact name
         if: always()
+        id: set-artifact-name
         run: |
-          echo "NAME=snapshots_${{ matrix.tags }}" | sed "s|,|_|g" >> "$GITHUB_ENV"
+          echo "NAME=snapshots_${{ matrix.packages }}" | sed "s|/|_|g" >> "$GITHUB_OUTPUT"
       - name: upload artifact
         if: always()
         uses: actions/[email protected]
         with:
-          name: ${{ env.NAME }}
+          name: ${{ steps.set-artifact-name.outputs.NAME }}
           path: test/e2e/testdata/.snapshots
           include-hidden-files: true
       - name: Test Summary
@@ -135,7 +136,7 @@ jobs:
       - run: make e2e-test
         env:
           TEST_CMD: gotestsum --junitfile e2e-tests.xml --format standard-verbose --
-          E2E_TAGS: atlas,cleanup
+          E2E_TEST_PACKAGES: ./test/internal..
           MONGODB_ATLAS_ORG_ID: ${{ secrets.MONGODB_ATLAS_ORG_ID }}
           MONGODB_ATLAS_PROJECT_ID: ${{ secrets.MONGODB_ATLAS_PROJECT_ID }}
           MONGODB_ATLAS_PUBLIC_API_KEY: ${{ secrets.MONGODB_ATLAS_PUBLIC_API_KEY }}
@@ -154,7 +155,6 @@ jobs:
           AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
           GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }}
           E2E_TIMEOUT: 3h
-          E2E_TEST_PACKAGES: ./test/internal..
       - name: Test Summary
         if: always()
         uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86

CONTRIBUTING.md

@@ -67,10 +67,8 @@ The following is a short list of commands that can be run in the root of the pro
 - Run `make` to see a list of available targets.
 - Run `make test` to run all unit tests.
 - Run `make lint` to validate against our linting rules.
-- Run `E2E_TAGS=e2e,atlas make e2e-test` will run end-to-end tests against an Atlas instance,
+- Run `make e2e-test` will run end-to-end tests,
   please make sure to have set `MCLI_*` variables pointing to that instance.
-- Run `E2E_TAGS=cloudmanager,remote,generic make e2e-test` will run end-to-end tests against a Cloud Manager instance.<br />
-  Please remember to: (a) have a running automation agent, and (b) set MCLI\_\* variables to point to your Cloud Manager instance.
 - Run `make build` to generate a local binary in the `./bin` folder.
 
 We provide a git pre-commit hook to format and check the code, to install it run `make link-git-hooks`.

Makefile

@@ -26,7 +26,6 @@ DEBUG_FLAGS=all=-N -l
 
 TEST_CMD?=go test
 E2E_TEST_PACKAGES?=./test/e2e..
-E2E_TAGS?=e2e
 E2E_TIMEOUT?=60m
 E2E_PARALLEL?=1
 E2E_EXTRA_ARGS?=
@@ -175,11 +174,11 @@ build-debug: ## Generate a binary in ./bin for debugging atlascli
 e2e-test: build-debug ## Run E2E tests
 # the target assumes the MCLI_* environment variables are exported
 	@echo "==> Running E2E tests..."
-	$(TEST_CMD) -v -p 1 -parallel $(E2E_PARALLEL) -v -timeout $(E2E_TIMEOUT) -tags="$(E2E_TAGS)" ${E2E_TEST_PACKAGES}. $(E2E_EXTRA_ARGS)
+	$(TEST_CMD) -v -p 1 -parallel $(E2E_PARALLEL) -v -timeout $(E2E_TIMEOUT) ${E2E_TEST_PACKAGES}. $(E2E_EXTRA_ARGS)
 
 .PHONY: e2e-test-snapshots
 e2e-test-snapshots: build-debug ## Run E2E tests
-	UPDATE_SNAPSHOTS=false E2E_SKIP_CLEANUP=true DO_NOT_TRACK=1 $(TEST_CMD) -v -timeout $(E2E_TIMEOUT) -tags="e2eSnap" ${E2E_TEST_PACKAGES}. $(E2E_EXTRA_ARGS)
+	UPDATE_SNAPSHOTS=false E2E_SKIP_CLEANUP=true DO_NOT_TRACK=1 $(TEST_CMD) -v -timeout $(E2E_TIMEOUT) ${E2E_TEST_PACKAGES}. $(E2E_EXTRA_ARGS)
 	go tool covdata textfmt -i $(GOCOVERDIR) -o $(COVERAGE)
 
 .PHONY: unit-test