CLOUDP-100613: When no profile file exists the version checker fails (#865)

Author: fmenezes

internal/cli/root/builder.go

@@ -34,14 +34,13 @@ import (
 	"github.com/mongodb/mongocli/internal/config"
 	"github.com/mongodb/mongocli/internal/flag"
 	"github.com/mongodb/mongocli/internal/search"
-	"github.com/mongodb/mongocli/internal/store"
 	"github.com/mongodb/mongocli/internal/usage"
 	"github.com/mongodb/mongocli/internal/version"
 	"github.com/spf13/cobra"
 )
 
 type BuilderOpts struct {
-	store store.ReleaseVersionDescriber
+	store version.ReleaseVersionDescriber
 }
 
 // rootBuilder conditionally adds children commands as needed.
@@ -60,17 +59,15 @@ func Builder(profile *string, argsWithoutProg []string) *cobra.Command {
 		Annotations: map[string]string{
 			"toc": "true",
 		},
-		PersistentPostRunE: func(cmd *cobra.Command, args []string) error {
+		PersistentPostRun: func(cmd *cobra.Command, args []string) {
 			w := cmd.ErrOrStderr()
 			if shouldSkipPrintNewVersion(w) {
-				return nil
+				return
 			}
-			opts := &BuilderOpts{}
-			err := opts.initStore()
-			if err != nil {
-				return err
+			opts := &BuilderOpts{
+				store: version.NewReleaseVersionDescriber(),
 			}
-			return opts.printNewVersionAvailable(w)
+			_ = opts.printNewVersionAvailable(w)
 		},
 	}
 	rootCmd.SetVersionTemplate(formattedVersion())
@@ -233,9 +230,3 @@ To disable this alert, run "mongocli config set skip_update_check true".
 	}
 	return nil
 }
-
-func (opts *BuilderOpts) initStore() error {
-	var err error
-	opts.store, err = store.New(store.UnauthenticatedPreset(config.Default()))
-	return err
-}

internal/cli/root/builder_test.go

@@ -25,7 +25,6 @@ import (
 
 	"github.com/golang/mock/gomock"
 	"github.com/mongodb/mongocli/internal/mocks"
-	"github.com/mongodb/mongocli/internal/store"
 	"github.com/mongodb/mongocli/internal/version"
 )
 
@@ -126,22 +125,22 @@ func TestBuilder(t *testing.T) {
 func TestOutputOpts_printNewVersionAvailable(t *testing.T) {
 	tests := []struct {
 		currentVersion string
-		latestVersion  *store.ReleaseInformation
+		latestVersion  *version.ReleaseInformation
 		wantPrint      bool
 	}{
 		{
 			currentVersion: "v1.0.0",
-			latestVersion:  &store.ReleaseInformation{Version: "v2.0.0", PublishedAt: time.Now()},
+			latestVersion:  &version.ReleaseInformation{Version: "v2.0.0", PublishedAt: time.Now()},
 			wantPrint:      true,
 		},
 		{
 			currentVersion: "v1.0.0",
-			latestVersion:  &store.ReleaseInformation{Version: "v1.0.0", PublishedAt: time.Now()},
+			latestVersion:  &version.ReleaseInformation{Version: "v1.0.0", PublishedAt: time.Now()},
 			wantPrint:      false,
 		},
 		{
 			currentVersion: "v1.0.0-123",
-			latestVersion:  &store.ReleaseInformation{Version: "v1.0.0", PublishedAt: time.Now()},
+			latestVersion:  &version.ReleaseInformation{Version: "v1.0.0", PublishedAt: time.Now()},
 			wantPrint:      false,
 		},
 	}

internal/mocks/mock_release_version.go

@@ -12,15 +12,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package store
+package version
 
 import (
+	"context"
 	"time"
 
 	"github.com/google/go-github/v38/github"
 )
 
-//go:generate mockgen -destination=../mocks/mock_release_version.go -package=mocks github.com/mongodb/mongocli/internal/store ReleaseVersionDescriber
+//go:generate mockgen -destination=../mocks/mock_release_version.go -package=mocks github.com/mongodb/mongocli/internal/version ReleaseVersionDescriber
 
 type ReleaseVersionDescriber interface {
 	LatestVersion() (*ReleaseInformation, error)
@@ -31,8 +32,16 @@ type ReleaseInformation struct {
 	PublishedAt time.Time
 }
 
+func NewReleaseVersionDescriber() ReleaseVersionDescriber {
+	return &releaseVersionFetcher{ctx: context.Background()}
+}
+
+type releaseVersionFetcher struct {
+	ctx context.Context
+}
+
 // LatestVersion encapsulates the logic to manage different cloud providers.
-func (s *Store) LatestVersion() (*ReleaseInformation, error) {
+func (s *releaseVersionFetcher) LatestVersion() (*ReleaseInformation, error) {
 	client := github.NewClient(nil)
 	release, _, err := client.Repositories.GetLatestRelease(s.ctx, "mongodb", "mongocli")
 	if err != nil {