CLOUDP-66571: add tests to profile (#229)

Author: robcarlan-mlab

.githooks/pre-commit

@@ -10,7 +10,7 @@ done
 
 if [[ -n "${STAGED_GO_FILES}" ]]; then
     set -o errexit
-    go test -race ./internal...
+    go test --tags="unit integration" -race ./internal...
     make fix-lint
     set +o errexit
 fi

Makefile

@@ -12,6 +12,8 @@ VERSION=$(shell git describe --always --tags)
 LINKER_FLAGS=-X github.com/mongodb/mongocli/internal/version.Version=${VERSION}
 
 TEST_CMD?=go test
+UNIT_TAGS?=unit
+INTEGRATION_TAGS?=integration
 E2E_TAGS?=e2e
 E2E_BINARY?=../../bin/${BINARY_NAME}
 
@@ -35,9 +37,7 @@ fmt: ## Format code
 	@scripts/fmt.sh
 
 .PHONY: test
-test: ## Run tests
-	@echo "==> Running tests..."
-	${TEST_CMD} -race -cover -count=1 -coverprofile ${COVERAGE} ./internal...
+test: unit-test integration-test
 
 .PHONY: lint
 lint: ## Run linter
@@ -72,6 +72,16 @@ e2e-test: build ## Run E2E tests
 	# the target assumes the MCLI-* environment variables are exported
 	${TEST_CMD} -v -p 1 -parallel 1 -timeout 15m -tags="${E2E_TAGS}" ./e2e...
 
+.PHONY: integration-test
+integration-test: ## Run integration tests
+	@echo "==> Running integration tests..."
+	${TEST_CMD} --tags="${INTEGRATION_TAGS}" -count=1 ./internal...
+
+.PHONY: unit-test
+unit-test: ## Run unit-tests
+	@echo "==> Running unit tests..."
+	${TEST_CMD} --tags="${UNIT_TAGS}" -race -cover -count=1 -coverprofile ${COVERAGE} ./internal...
+
 .PHONY: install
 install: ## Install a binary in $GOPATH/bin
 	@echo "==> Installing to $(INSTALL_PATH)"

build/ci/evergreen.yml

@@ -341,7 +341,7 @@ tasks:
     commands:
       - func: "clone"
       - func: "build"
-  - name: unit_test
+  - name: test
     tags: ["code_health"]
     commands:
       - func: "clone"

cmd/mongocli/mongocli.go

@@ -97,21 +97,21 @@ func init() {
 
 	profile := rootCmd.PersistentFlags().StringP(flag.Profile, flag.ProfileShort, "", usage.Profile)
 	cobra.OnInitialize(func() {
-		initConfig(profile)
+		initConfig(*profile)
 	})
 }
 
 // initConfig reads in config file and ENV variables if set.
-func initConfig(profileName *string) {
+func initConfig(profileName string) {
 	if err := config.Load(); err != nil {
 		log.Fatalf("Error loading config: %v", err)
 	}
 
 	availableProfiles := config.List()
-	if *profileName != "" {
+	if profileName != "" {
 		config.SetName(profileName)
 	} else if len(availableProfiles) == 1 {
-		config.SetName(&availableProfiles[0])
+		config.SetName(availableProfiles[0])
 	}
 }
 

e2e/atlas/alert_settings_test.go

@@ -11,6 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
 // +build e2e atlas,generic
 
 package atlas_test

go.mod

@@ -19,6 +19,7 @@ require (
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/spf13/viper v1.7.0
+	github.com/stretchr/testify v1.6.1
 	go.mongodb.org/atlas v0.3.1-0.20200715182911-bdd98ee452e6
 	go.mongodb.org/ops-manager v0.7.1-0.20200716111014-0e6b5a319279
 	golang.org/x/crypto v0.0.0-20191108234033-bd318be0434a // indirect

internal/cli/agents/upgrade_test.go

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// +build unit
+
 package agents
 
 import (

internal/cli/alerts/acknowledge_test.go

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// +build unit
+
 package alerts
 
 import (

internal/cli/alerts/describe_test.go

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// +build unit
+
 package alerts
 
 import (

internal/cli/alerts/global_list_test.go

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// +build unit
+
 package alerts
 
 import (