task: enable intrange check (#3838)

Author: Gustavo Bazan

.golangci.yml

@@ -24,6 +24,7 @@ linters:
     - govet
     - importas
     - ineffassign
+    - intrange
     - makezero
     - misspell
     - mnd

internal/cli/streams/privatelink/list_test.go

@@ -28,17 +28,17 @@ import (
 )
 
 func getPrivateLinkConnections() []atlasv2.StreamsPrivateLinkConnection {
-	var connections []atlasv2.StreamsPrivateLinkConnection
+	connections := make([]atlasv2.StreamsPrivateLinkConnection, 5)
 
-	for i := 0; i < 5; i++ {
+	for i := range 5 {
 		conn := atlasv2.NewStreamsPrivateLinkConnection()
 		conn.SetId(fmt.Sprintf("testId%d", i))
 		conn.SetProvider("Azure")
 		conn.SetRegion("US_EAST_2")
 		conn.SetServiceEndpointId("/subscriptions/fd01adff-b37e-4693-8497-83ecf183a145/resourceGroups/test-rg/providers/Microsoft.EventHub/namespaces/test-namespace")
 		conn.SetDnsDomain("test-namespace.servicebus.windows.net")
 
-		connections = append(connections, *conn)
+		connections[i] = *conn
 	}
 
 	return connections

internal/telemetry/read_answer.go

@@ -35,7 +35,7 @@ func listFields(target reflect.Value) []fieldValue {
 	targetType := target.Type()
 	numFields := targetType.NumField()
 	ret := make([]fieldValue, numFields)
-	for i := 0; i < numFields; i++ {
+	for i := range numFields {
 		ret[i] = fieldValue{
 			field: targetType.Field(i),
 			value: target.Field(i),

test/e2e/projectsettings/project_settings_test.go

@@ -68,7 +68,7 @@ func TestProjectSettings(t *testing.T) {
 	t.Run("Update", func(t *testing.T) {
 		var settings atlasv2.GroupSettings
 
-		for i := 0; i < 10; i++ { // try again for 10 seconds
+		for range 10 { // try again for 10 seconds
 			cmd := exec.Command(cliPath,
 				projectsEntity,
 				settingsEntity,

test/internal/helper.go

@@ -734,7 +734,7 @@ func deleteAllPrivateEndpoints(t *testing.T, cliPath, projectID, provider string
 	}
 
 	done := false
-	for attempt := 0; attempt < 10; attempt++ {
+	for range 10 {
 		privateEndpoints = listPrivateEndpointsByProject(t, cliPath, projectID, provider)
 		if len(privateEndpoints) == 0 {
 			t.Logf("all %s private endpoints successfully deleted", provider)
@@ -760,7 +760,7 @@ func deleteAllStreams(t *testing.T, cliPath, projectID string) {
 	}
 
 	done := false
-	for attempt := 0; attempt < 10; attempt++ {
+	for range 10 {
 		streams = listStreamsByProject(t, cliPath, projectID)
 		if streams.GetTotalCount() == 0 {
 			t.Logf("all streams successfully deleted")

tools/cmd/templates-checker/templateparsing/validation.go

@@ -176,7 +176,7 @@ func getTemplateFields(namedTypeInfo *types.Named) (map[string]types.Type, error
 	structStructure := make(map[string]types.Type)
 
 	// Add fields and embedded fields
-	for i := 0; i < structInfo.NumFields(); i++ {
+	for i := range structInfo.NumFields() {
 		field := structInfo.Field(i)
 		fieldName := field.Name()
 		lowerCaseFieldName := strings.ToLower(fieldName)
@@ -204,7 +204,7 @@ func getTemplateFields(namedTypeInfo *types.Named) (map[string]types.Type, error
 	}
 
 	// Add method names
-	for i := 0; i < namedTypeInfo.NumMethods(); i++ {
+	for i := range namedTypeInfo.NumMethods() {
 		method := namedTypeInfo.Method(i)
 
 		// Only check public fields