chore: move e2e tests into code_health (#3828)

Author: fmenezes

.github/workflows/code-health.yml

@@ -360,3 +360,28 @@ jobs:
           platforms: linux/amd64,linux/arm64
           tags: mongodb/atlas:test
           file: Dockerfile
+  e2e-tests:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - uses: GitHubSecurityLab/actions-permissions/monitor@v1
+        with:
+          config: ${{ vars.PERMISSIONS_CONFIG }}
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Install Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
+      - run: go install gotest.tools/gotestsum@latest
+      - run: make e2e-test-snapshots
+        env:
+          TEST_CMD: gotestsum --junitfile e2e-tests.xml --format standard-verbose --
+      - name: Test Summary
+        if: always()
+        uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86
+        with:
+          paths: e2e-tests.xml

.github/workflows/e2e-tests.yml

@@ -199,9 +199,6 @@ linters:
       - linters:
           - gocyclo
         path: e2e
-      - linters:
-          - mnd
-        path: internal/test/fixture
     paths:
       - third_party$
       - builtin$

.golangci.yml

@@ -19,7 +19,8 @@ ATLAS_INSTALL_PATH="${GOPATH}/bin/$(ATLAS_BINARY_NAME)"
 
 LOCALDEV_IMAGE?=docker.io/mongodb/mongodb-atlas-local
 LINKER_FLAGS=-s -w -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.GitCommit=${GIT_SHA} -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.Version=${ATLAS_VERSION} -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/options.LocalDevImage=${LOCALDEV_IMAGE}
-ATLAS_E2E_BINARY?=../../bin/${ATLAS_BINARY_NAME}
+ATLAS_E2E_BINARY?=$(abspath bin/${ATLAS_BINARY_NAME})
+export SNAPSHOTS_DIR?=$(abspath test/e2e/testdata/.snapshots)
 
 DEBUG_FLAGS=all=-N -l
 
@@ -163,6 +164,10 @@ e2e-test: build-debug ## Run E2E tests
 	@echo "==> Running E2E tests..."
 	$(TEST_CMD) -v -p 1 -parallel $(E2E_PARALLEL) -v -timeout $(E2E_TIMEOUT) -tags="$(E2E_TAGS)" ./test/e2e... $(E2E_EXTRA_ARGS)
 
+.PHONY: e2e-test-snapshots
+e2e-test-snapshots: build-debug ## Run E2E tests
+	UPDATE_SNAPSHOTS=false E2E_SKIP_CLEANUP=true DO_NOT_TRACK=1 $(TEST_CMD) -v -timeout $(E2E_TIMEOUT) -tags="e2eSnap" ./test/e2e... $(E2E_EXTRA_ARGS)
+
 .PHONY: unit-test
 unit-test: build-debug ## Run unit-tests
 	@echo "==> Running unit tests..."

Makefile

@@ -11,9 +11,9 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//go:build e2e || (atlas && generic)
+//go:build e2e || e2eSnap || (atlas && generic)
 
-package e2e
+package accesslists
 
 import (
 	"encoding/json"
@@ -29,6 +29,10 @@ import (
 	atlasv2 "go.mongodb.org/atlas-sdk/v20250312001/admin"
 )
 
+const (
+	accessListEntity = "accessList"
+)
+
 func TestAccessList(t *testing.T) {
 	g := internal.NewAtlasE2ETestGenerator(t, internal.WithSnapshot())
 	g.GenerateProject("accessList")

test/e2e/access_lists_test.go test/e2e/accesslists/access_lists_test.gotest/e2e/access_lists_test.go renamed to test/e2e/accesslists/access_lists_test.go

@@ -11,9 +11,9 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//go:build e2e || (atlas && logs)
+//go:build e2e || e2eSnap || (atlas && logs)
 
-package e2e
+package accesslogs
 
 import (
 	"encoding/json"
@@ -26,6 +26,10 @@ import (
 	atlasv2 "go.mongodb.org/atlas-sdk/v20250312001/admin"
 )
 
+const (
+	accessLogsEntity = "accessLogs"
+)
+
 func TestAccessLogs(t *testing.T) {
 	g := internal.NewAtlasE2ETestGenerator(t, internal.WithSnapshot())
 	req := require.New(t)

test/e2e/access_logs_test.go test/e2e/accesslogs/access_logs_test.gotest/e2e/access_logs_test.go renamed to test/e2e/accesslogs/access_logs_test.go

@@ -11,9 +11,9 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//go:build e2e || (atlas && generic)
+//go:build e2e || e2eSnap || (atlas && generic)
 
-package e2e
+package accessroles
 
 import (
 	"encoding/json"
@@ -27,6 +27,12 @@ import (
 	atlasv2 "go.mongodb.org/atlas-sdk/v20250312001/admin"
 )
 
+const (
+	awsEntity            = "aws"
+	cloudProvidersEntity = "cloudProviders"
+	accessRolesEntity    = "accessRoles"
+)
+
 const aws = "AWS"
 
 func TestAccessRoles(t *testing.T) {

test/e2e/access_roles_test.go test/e2e/accessroles/access_roles_test.gotest/e2e/access_roles_test.go renamed to test/e2e/accessroles/access_roles_test.go

@@ -11,9 +11,9 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-//go:build e2e || (atlas && generic)
+//go:build e2e || e2eSnap || (atlas && generic)
 
-package e2e
+package alerts
 
 import (
 	"encoding/json"
@@ -28,6 +28,10 @@ import (
 	atlasv2 "go.mongodb.org/atlas-sdk/v20250312001/admin"
 )
 
+const (
+	alertsEntity = "alerts"
+)
+
 const (
 	closed = "CLOSED"
 )

test/e2e/alerts_test.go test/e2e/alerts/alerts_test.gotest/e2e/alerts_test.go renamed to test/e2e/alerts/alerts_test.go

@@ -12,9 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-//go:build e2e || (atlas && generic)
+//go:build e2e || e2eSnap || (atlas && generic)
 
-package e2e
+package alertsettings
 
 import (
 	"encoding/json"
@@ -30,6 +30,17 @@ import (
 	"go.mongodb.org/atlas-sdk/v20250312001/admin"
 )
 
+const (
+	alertsEntity   = "alerts"
+	settingsEntity = "settings"
+
+	// AlertConfig constants.
+	group         = "GROUP"
+	eventTypeName = "NO_PRIMARY"
+	intervalMin   = 5
+	delayMin      = 0
+)
+
 func TestAlertConfig(t *testing.T) {
 	g := internal.NewAtlasE2ETestGenerator(t, internal.WithSnapshot())
 	var alertID string

test/e2e/alert_settings_test.go …e2e/alertsettings/alert_settings_test.gotest/e2e/alert_settings_test.go renamed to test/e2e/alertsettings/alert_settings_test.go test/e2e/alert_settings_test.go renamed to test/e2e/alertsettings/alert_settings_test.go

@@ -12,9 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-//go:build e2e || (iam && atlas)
+//go:build e2e || e2eSnap || (iam && atlas)
 
-package e2e
+package atlasorgapikeyaccesslist
 
 import (
 	"encoding/json"
@@ -30,6 +30,12 @@ import (
 	atlasv2 "go.mongodb.org/atlas-sdk/v20250312001/admin"
 )
 
+const (
+	orgEntity              = "org"
+	apiKeysEntity          = "apikeys"
+	apiKeyAccessListEntity = "accessLists"
+)
+
 var errNoAPIKey = errors.New("the apiKey ID is empty")
 
 func TestAtlasOrgAPIKeyAccessList(t *testing.T) {
@@ -41,7 +47,7 @@ func TestAtlasOrgAPIKeyAccessList(t *testing.T) {
 	require.NoError(t, e)
 
 	t.Cleanup(func() {
-		require.NoError(t, deleteOrgAPIKey(apiKeyID))
+		require.NoError(t, internal.DeleteOrgAPIKey(apiKeyID))
 	})
 
 	n := g.MemoryRand("rand", 255)
@@ -159,18 +165,3 @@ func createOrgAPIKey() (string, error) {
 
 	return "", errNoAPIKey
 }
-
-func deleteOrgAPIKey(id string) error {
-	cliPath, err := internal.AtlasCLIBin()
-	if err != nil {
-		return err
-	}
-	cmd := exec.Command(cliPath,
-		orgEntity,
-		apiKeysEntity,
-		"rm",
-		id,
-		"--force")
-	cmd.Env = os.Environ()
-	return cmd.Run()
-}