CLOUDP-285714: Remove apiKey field from PagerDuty Atlas CLI (#3408)

danielz117 · web-flow · commit c12986f342f1 · 2024-12-03T14:13:36.000-05:00
diff --git a/internal/cli/alerts/settings/validator.go b/internal/cli/alerts/settings/validator.go
@@ -91,8 +91,8 @@ func validateOpsGenie(opts *ConfigOpts) error {
 }
 
 func validatePagerDuty(opts *ConfigOpts) error {
-	if opts.apiKey == "" {
-		return fmt.Errorf("--%s is required when --%s is PAGER_DUTY", flag.APIKey, flag.NotificationType)
+	if opts.notificationServiceKey == "" || opts.notificationRegion == "" {
+		return fmt.Errorf("--%s and --%s are required when --%s is PAGER_DUTY", flag.NotificationServiceKey, flag.NotificationRegion, flag.NotificationType)
 	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ func validateOpsGenie(opts *ConfigOpts) error {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`func validatePagerDuty(opts *ConfigOpts) error {`
`94`		`- if opts.apiKey == "" {`
`95`		`- return fmt.Errorf("--%s is required when --%s is PAGER_DUTY", flag.APIKey, flag.NotificationType)`
	`94`	`+ if opts.notificationServiceKey == "" \|\| opts.notificationRegion == "" {`
	`95`	`+ return fmt.Errorf("--%s and --%s are required when --%s is PAGER_DUTY", flag.NotificationServiceKey, flag.NotificationRegion, flag.NotificationType)`
`96`	`96`	`}`
`97`	`97`	`return nil`
`98`	`98`	`}`