chore: auto set test vars (#4115)

Author: fmenezes

CONTRIBUTING.md

@@ -117,7 +117,7 @@ To debug e2e tests.
 
 Update e2e profiles by running `make add-e2e-profiles`.
 
-Add needed env vars by:
+Add optional env vars by:
 
 ```shell 
 touch .vscode/settings.json
@@ -129,8 +129,6 @@ Review and replace the atlas settings.
 ```json
 {
   "go.testEnvVars": {
-    "ATLAS_E2E_BINARY": "${workspaceFolder}/bin/atlas", // required
-    "SNAPSHOTS_DIR": "${workspaceFolder}/test/e2e/testdata/.snapshots", // required
     "TEST_MODE": "live", // optional default is 'live'
     "GOCOVERDIR": "${workspaceFolder}/cov", // optional used for coverage counting
     "MONGODB_ATLAS_SKIP_UPDATE_CHECK": "yes", // optional but recommended

Makefile

@@ -19,8 +19,6 @@ ATLAS_INSTALL_PATH="${GOPATH}/bin/$(ATLAS_BINARY_NAME)"
 
 LOCALDEV_IMAGE?=docker.io/mongodb/mongodb-atlas-local
 LINKER_FLAGS=-s -w -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.GitCommit=${GIT_SHA} -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.Version=${ATLAS_VERSION} -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/options.LocalDevImage=${LOCALDEV_IMAGE}
-ATLAS_E2E_BINARY?=$(abspath bin/${ATLAS_BINARY_NAME})
-export SNAPSHOTS_DIR?=$(abspath test/e2e/testdata/.snapshots)
 
 DEBUG_FLAGS=all=-N -l
 
@@ -39,7 +37,6 @@ endif
 export TERM := linux-m
 export GO111MODULE := on
 export GOTOOLCHAIN := local
-export ATLAS_E2E_BINARY
 
 .PHONY: pre-commit
 pre-commit:  ## Run pre-commit hook

test/internal/atlas_e2e_test_generator.go

@@ -32,7 +32,6 @@ import (
 	"os"
 	"os/exec"
 	"path"
-	"path/filepath"
 	"regexp"
 	"slices"
 	"strconv"
@@ -460,15 +459,12 @@ func (g *AtlasE2ETestGenerator) RunCommand(args ...string) ([]byte, error) {
 func (g *AtlasE2ETestGenerator) snapshotBaseDir() string {
 	g.t.Helper()
 
-	if os.Getenv("SNAPSHOTS_DIR") == "" {
-		g.t.Fatal("missing env var SNAPSHOTS_DIR")
-	}
-	dir, err := filepath.Abs(os.Getenv("SNAPSHOTS_DIR"))
+	snapshotsDir, err := snapshotBasePath()
 	if err != nil {
 		g.t.Fatal(err)
 	}
 
-	return dir
+	return snapshotsDir
 }
 
 func (g *AtlasE2ETestGenerator) snapshotDir() string {

test/internal/env.go

@@ -154,17 +154,32 @@ func GCPCredentials() (string, error) {
 	return credentials, nil
 }
 
+func repoPath() (string, error) {
+	wd, err := os.Getwd()
+	if err != nil {
+		return "", err
+	}
+
+	parts := strings.Split(wd, "/test/")
+
+	return parts[0], nil
+}
+
 func AtlasCLIBin() (string, error) {
-	path := os.Getenv("ATLAS_E2E_BINARY")
-	cliPath, err := filepath.Abs(path)
+	repo, err := repoPath()
 	if err != nil {
-		return "", fmt.Errorf("%w: invalid bin path %q", err, path)
+		return "", err
 	}
 
-	if _, err := os.Stat(cliPath); err != nil {
-		return "", fmt.Errorf("%w: invalid bin %q", err, path)
+	return filepath.Join(repo, "bin", "atlas"), nil
+}
+
+func snapshotBasePath() (string, error) {
+	repo, err := repoPath()
+	if err != nil {
+		return "", err
 	}
-	return cliPath, nil
+	return filepath.Join(repo, "test", "e2e", "testdata", ".snapshots"), nil
 }
 
 func ProfileData() (map[string]string, error) {