task: some store clean ups from ops manager references (#2714)

Author: Gustavo Bazan

internal/cli/atlas/projects/describe_test.go

@@ -34,7 +34,7 @@ func TestDescribe_Run(t *testing.T) {
 	}
 	mockStore.
 		EXPECT().
-		Project(gomock.Eq("5a0a1e7e0f2912c554080adc")).
+		Project("5a0a1e7e0f2912c554080adc").
 		Return(expected, nil).
 		Times(1)
 

internal/cli/default_setter_opts.go

@@ -148,7 +148,7 @@ func (opts *DefaultSetterOpts) ProjectExists(id string) bool {
 }
 
 // AskProject will try to construct a select based on fetched projects.
-// If it fails or there are no projects to show we fallback to ask for project by ID.
+// If it fails or there are no projects to show we fall back to ask for project by ID.
 // If only one project, select it by default without prompting the user.
 func (opts *DefaultSetterOpts) AskProject() error {
 	ids, names, err := opts.projects()

internal/kubernetes/operator/install.go

@@ -142,7 +142,6 @@ func (i *Install) Run(ctx context.Context, orgID string) error {
 
 func (i *Install) ensureProject(orgID, projectName string) (*admin.Group, error) {
 	project, err := i.atlasStore.ProjectByName(projectName)
-
 	if err == nil {
 		return project, nil
 	}

internal/prompt/config.go

@@ -43,7 +43,6 @@ func NewProjectIDInput() survey.Prompt {
 
 func AccessQuestions() []*survey.Question {
 	helpLink := "Please provide your API keys. To create new keys, see the documentation: https://docs.atlas.mongodb.com/configure-api-access/"
-
 	q := []*survey.Question{
 		{
 			Name: "publicAPIKey",

internal/store/atlas/store.go

@@ -33,8 +33,6 @@ import (
 )
 
 const (
-	yes                   = "yes"
-	responseHeaderTimeout = 1 * time.Minute
 	telemetryTimeout      = 1 * time.Second
 	tlsHandshakeTimeout   = 5 * time.Second
 	timeout               = 5 * time.Second

internal/store/default_mongodb_version.go

@@ -20,7 +20,7 @@ type DefaultVersionGetter interface {
 	DefaultMongoDBVersion() (string, error)
 }
 
-// CreateCloudProviderAccessRole encapsulates the logic to manage different cloud providers.
+// DefaultMongoDBVersion encapsulates the logic to manage different cloud providers.
 func (s *Store) DefaultMongoDBVersion() (string, error) {
 	result, _, err := s.client.DefaultMongoDBMajorVersion.Get(s.ctx)
 	return result, err

internal/store/live_migration.go

@@ -45,7 +45,7 @@ func (s *Store) CreateValidation(groupID string, liveMigration *atlasv2.LiveMigr
 	return result, err
 }
 
-// StartLiveMigrationCutover encapsulate the logic to manage different cloud providers.
+// CreateLiveMigrationCutover encapsulate the logic to manage different cloud providers.
 func (s *Store) CreateLiveMigrationCutover(groupID, liveMigrationID string) error {
 	if s.service == config.CloudGovService {
 		return fmt.Errorf("%w: %s", errUnsupportedService, s.service)

internal/store/peering_connections.go

@@ -74,13 +74,13 @@ func (s *Store) PeeringConnections(projectID string, opts *atlas.ContainersListO
 	return result.GetResults(), nil
 }
 
-// PeeringConnections encapsulates the logic to manage different cloud providers.
+// PeeringConnection encapsulates the logic to manage different cloud providers.
 func (s *Store) PeeringConnection(projectID, peerID string) (*atlasv2.BaseNetworkPeeringConnectionSettings, error) {
 	result, _, err := s.clientv2.NetworkPeeringApi.GetPeeringConnection(s.ctx, projectID, peerID).Execute()
 	return result, err
 }
 
-// DeletePrivateEndpoint encapsulates the logic to manage different cloud providers.
+// DeletePeeringConnection encapsulates the logic to manage different cloud providers.
 func (s *Store) DeletePeeringConnection(projectID, peerID string) error {
 	_, _, err := s.clientv2.NetworkPeeringApi.DeletePeeringConnection(s.ctx, projectID, peerID).Execute()
 	return err

internal/store/projects.go

@@ -100,7 +100,7 @@ func (s *Store) ProjectUsers(projectID string, opts *atlas.ListOptions) ([]atlas
 	return result, err
 }
 
-// DeleteProject encapsulates the logic to manage different cloud providers.
+// DeleteUserFromProject encapsulates the logic to manage different cloud providers.
 func (s *Store) DeleteUserFromProject(projectID, userID string) error {
 	_, err := s.client.Projects.RemoveUserFromProject(s.ctx, projectID, userID)
 	return err

internal/store/serverless_instances.go

@@ -58,7 +58,7 @@ func (s *Store) ServerlessInstances(projectID string, listOps *atlas.ListOptions
 	return result, err
 }
 
-// ServerlessInstance encapsulates the logic to manage different cloud providers.
+// GetServerlessInstance encapsulates the logic to manage different cloud providers.
 func (s *Store) GetServerlessInstance(projectID, clusterName string) (*atlasv2.ServerlessInstanceDescription, error) {
 	if s.service == config.CloudGovService {
 		return nil, fmt.Errorf("%w: %s", errUnsupportedService, s.service)
@@ -67,7 +67,7 @@ func (s *Store) GetServerlessInstance(projectID, clusterName string) (*atlasv2.S
 	return result, err
 }
 
-// Used by Kubernetes v1 ServerlessInstance encapsulates the logic to manage different cloud providers.
+// ServerlessInstance Used by Kubernetes v1 ServerlessInstance encapsulates the logic to manage different cloud providers.
 func (s *Store) ServerlessInstance(projectID, clusterName string) (*atlas.Cluster, error) {
 	if s.service == config.CloudGovService {
 		return nil, fmt.Errorf("%w: %s", errUnsupportedService, s.service)