Force reply with AtlasDeploymentReady type (#1366)

Signed-off-by: jose.vazquez <[email protected]>

Author: josvazg

pkg/controller/atlasdeployment/atlasdeployment_controller.go

@@ -234,7 +234,7 @@ func (r *AtlasDeploymentReconciler) checkDeploymentIsManaged(
 
 	if err != nil {
 		result := workflow.Terminate(workflow.Internal, fmt.Sprintf("unable to resolve ownership for deletion protection: %s", err))
-		workflowCtx.SetConditionFromResult(status.DatabaseUserReadyType, result)
+		workflowCtx.SetConditionFromResult(status.DeploymentReadyType, result)
 		log.Error(result.GetMessage())
 
 		return result
@@ -245,7 +245,7 @@ func (r *AtlasDeploymentReconciler) checkDeploymentIsManaged(
 			workflow.AtlasDeletionProtection,
 			"unable to reconcile Deployment due to deletion protection being enabled. see https://dochub.mongodb.org/core/ako-deletion-protection for further information",
 		)
-		workflowCtx.SetConditionFromResult(status.DatabaseUserReadyType, result)
+		workflowCtx.SetConditionFromResult(status.DeploymentReadyType, result)
 		log.Error(result.GetMessage())
 
 		return result

pkg/controller/atlasdeployment/atlasdeployment_controller_test.go

@@ -143,6 +143,10 @@ func TestProtectedAdvancedDeploymentManagedInAtlas(t *testing.T) {
 			if tc.expectedErr == "" {
 				assert.True(t, result.IsOk())
 			} else {
+				assert.NotNil(t, te.workflowCtx.LastCondition())
+				if te.workflowCtx.LastCondition() != nil {
+					assert.Equal(t, status.DeploymentReadyType, te.workflowCtx.LastCondition().Type)
+				}
 				assert.Regexp(t, regexp.MustCompile(tc.expectedErr), result.GetMessage())
 			}
 		})
@@ -189,6 +193,10 @@ func TestProtectedServerlessManagedInAtlas(t *testing.T) {
 			if tc.expectedErr == "" {
 				assert.True(t, result.IsOk())
 			} else {
+				assert.NotNil(t, te.workflowCtx.LastCondition())
+				if te.workflowCtx.LastCondition() != nil {
+					assert.Equal(t, status.DeploymentReadyType, te.workflowCtx.LastCondition().Type)
+				}
 				assert.Regexp(t, regexp.MustCompile(tc.expectedErr), result.GetMessage())
 			}
 		})