Fixup unit tests

Author: josvazg

internal/controller/customresource/protection_test.go

@@ -216,7 +216,6 @@ func TestPatchLastConfigApplied(t *testing.T) {
 		{
 			title: "spec without changes is a noop",
 			object: &akov2.AtlasProject{
-				TypeMeta:   metav1.TypeMeta{Kind: "AtlasProject", APIVersion: "atlas.mongodb.com"},
 				ObjectMeta: metav1.ObjectMeta{Name: "test-project", Namespace: "ns", Annotations: map[string]string{}},
 				Spec: akov2.AtlasProjectSpec{
 					Name:                "atlas-project-name",
@@ -243,7 +242,6 @@ func TestPatchLastConfigApplied(t *testing.T) {
 		{
 			title: "cleared spec is applied with no other changes",
 			object: &akov2.AtlasProject{
-				TypeMeta:   metav1.TypeMeta{Kind: "AtlasProject", APIVersion: "atlas.mongodb.com"},
 				ObjectMeta: metav1.ObjectMeta{Name: "test-project", Namespace: "ns", Annotations: map[string]string{}},
 				Spec: akov2.AtlasProjectSpec{
 					Name:                "atlas-project-name",
@@ -309,7 +307,7 @@ func TestPatchLastConfigAppliedErrors(t *testing.T) {
 			title:        "empty struct cannot be patched",
 			object:       &akov2.AtlasProject{},
 			spec:         &struct{}{},
-			wantErrorMsg: "failed to patch resource:  \"\" is invalid: metadata.name: Required value: name is required",
+			wantErrorMsg: "is invalid: metadata.name: Required value: name is required",
 		},
 	} {
 		t.Run(tc.title, func(t *testing.T) {

pkg/controller/state/reconciler_test.go

@@ -239,6 +239,7 @@ func TestReconcile(t *testing.T) {
 
 	basePod := &dummyObject{
 		Pod: corev1.Pod{
+			TypeMeta: metav1.TypeMeta{Kind: "Pod", APIVersion: "v1"},
 			ObjectMeta: metav1.ObjectMeta{
 				Name:       "mypod",
 				Namespace:  "default",
@@ -295,13 +296,6 @@ func TestReconcile(t *testing.T) {
 			},
 			wantErr: "failed to manage finalizers: simulated patch error",
 		},
-		{
-			name:        "check state",
-			existingObj: basePod,
-			handleState: func(ctx context.Context, do *dummyObject) (Result, error) {
-				return Result{NextState: "Initial"}, nil
-			},
-		},
 	}
 
 	for _, tc := range tests {