add small test

Author: roothorp

Makefile

@@ -642,7 +642,7 @@ tools/githubjobs/githubjobs: tools/githubjobs/*.go
 	cd tools/githubjobs && go build .
 
 tools/scandeprecation/scandeprecation: tools/scandeprecation/*.go
-	cd tools/scandeprecation && go build .
+	cd tools/scandeprecation && go test . && go build .
 
 
 .PHONY: slack-deprecations

tools/scandeprecation/scan_deprecations.go

@@ -47,22 +47,12 @@ func main() {
 	out.WriteString("|Type|Java Method|Date|\n|------|------|------|\n")
 
 	for scanner.Scan() {
-		example := scanner.Text()
-		// Non-JSON logs mean we split by tabs
-		split := strings.Split(example, "\t")
-
-		// Last element is the JSON "body" of the log line
-		example = split[len(split)-1]
-		example = strings.Replace(example, "***", "{", 1)
-		example = strings.Replace(example, "***", "}", 1)
-
-		res := DeprecationResponse{}
-		err = json.Unmarshal([]byte(example), &res)
+		line, err := parseLogLine(scanner.Text())
 		if err != nil {
-			log.Warn("failed to unmarshal JSON", zap.Error(err))
+			log.Warn(err.Error())
 			continue
 		}
-		responses = append(responses, res)
+		responses = append(responses, line)
 	}
 
 	// Quit out if there is no deprecations logged
@@ -91,3 +81,19 @@ func main() {
 	// Print to stdout
 	fmt.Println(out.String())
 }
+
+func parseLogLine(line string) (DeprecationResponse, error) {
+	// Non-JSON logs mean we split by tabs
+	split := strings.Split(line, "\t")
+	fmt.Println(split)
+
+	// Last element is the JSON "body" of the log line
+	line = split[len(split)-1]
+	line = strings.Replace(line, "***", "{", 1)
+	line = strings.Replace(line, "***", "}", 1)
+
+	res := DeprecationResponse{}
+	err := json.Unmarshal([]byte(line), &res)
+
+	return res, err
+}

tools/scandeprecation/scan_deprecations_test.go

@@ -0,0 +1,22 @@
+package main
+
+import "testing"
+
+const testLogLine = `2025-07-21T14:41:06.118Z	WARN	controllers.AtlasDeployment.deprecated	sunset	***"type": "sunset", "date": "Thu, 12 Mar 2026 00:00:00 GMT", "javaMethod": "ApiAtlasSearchDeploymentResource::getSearchDeployment", "path": "/api/atlas/v2/groups/687e4d839dc4c25a9d96f39d/clusters/search-nodes-test/search/deployment", "method": "GET"***`
+
+func TestParseLogLine(t *testing.T) {
+	out, err := parseLogLine(testLogLine)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if out.Type != "sunset" && out.Date != "Thu, 12 Mar 2026 00:00:00 GMT" && out.JavaMethod != "ApiAtlasSearchDeploymentResource::getSearchDeployment" {
+		t.Errorf("parseLogLine did not output expected struct")
+	}
+}
+
+func TestParseLogLineErrors(t *testing.T) {
+	_, err := parseLogLine("abd123")
+	if err == nil {
+		t.Errorf("parseLogLine() did not return an error")
+	}
+}