Skip to content

Commit 4e0c910

Browse files
committed
fix breaking changes
1 parent bd14dba commit 4e0c910

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

api/v1/project_teams.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ type Team struct {
4444
func (in *Team) ToAtlas(teamID string) admin.TeamRole {
4545
roleNames := make([]string, 0, len(in.Roles))
4646
result := admin.TeamRole{
47-
TeamId: &teamID,
48-
RoleNames: &roleNames,
47+
TeamId: teamID,
48+
RoleNames: roleNames,
4949
}
5050

5151
for _, role := range in.Roles {

internal/translation/teams/conversion.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ func TeamRolesToAtlas(atlasTeams []AssignedTeam) []admin.TeamRole {
117117

118118
for _, team := range atlasTeams {
119119
result := admin.TeamRole{
120-
TeamId: pointer.MakePtrOrNil(team.TeamID),
121-
RoleNames: &team.Roles,
120+
TeamId: team.TeamID,
121+
RoleNames: team.Roles,
122122
}
123123
teams = append(teams, result)
124124
}

internal/translation/teams/teams.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ func (tm *TeamsAPI) UpdateRoles(ctx context.Context, at *AssignedTeam, projectID
135135
roles = append(roles, string(role))
136136
}
137137

138-
_, _, err := tm.teamsAPI.UpdateGroupTeam(ctx, projectID, at.TeamID, &admin.TeamRole{RoleNames: &roles}).Execute()
138+
_, _, err := tm.teamsAPI.UpdateGroupTeam(ctx, projectID, at.TeamID, &admin.TeamRole{RoleNames: roles}).Execute()
139139
return err
140140
}
141141

internal/translation/teams/teams_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@ func TestTeamsAPI_ListProjectTeams(t *testing.T) {
7171
Return(&admin.PaginatedTeamRole{
7272
Results: &[]admin.TeamRole{
7373
{
74-
RoleNames: &[]string{"role1", "role2"},
75-
TeamId: &testTeamID1,
74+
RoleNames: []string{"role1", "role2"},
75+
TeamId: testTeamID1,
7676
},
7777
{
78-
RoleNames: &[]string{"role3", "role4"},
79-
TeamId: &testTeamID2,
78+
RoleNames: []string{"role3", "role4"},
79+
TeamId: testTeamID2,
8080
},
8181
},
8282
}, &http.Response{}, nil)
@@ -242,8 +242,8 @@ func TestTeamsAPI_Assign(t *testing.T) {
242242
Return(&admin.PaginatedTeamRole{
243243
Results: &[]admin.TeamRole{
244244
{
245-
RoleNames: &[]string{"role1", "role2"},
246-
TeamId: &testTeamID1,
245+
RoleNames: []string{"role1", "role2"},
246+
TeamId: testTeamID1,
247247
},
248248
},
249249
}, &http.Response{}, nil)
@@ -461,8 +461,8 @@ func TestTeamsAPI_UpdateRoles(t *testing.T) {
461461
Return(&admin.PaginatedTeamRole{
462462
Results: &[]admin.TeamRole{
463463
{
464-
RoleNames: &[]string{"role1", "role2"},
465-
TeamId: &testTeamID1,
464+
RoleNames: []string{"role1", "role2"},
465+
TeamId: testTeamID1,
466466
},
467467
},
468468
}, &http.Response{}, nil)

0 commit comments

Comments
 (0)