Skip to content

Commit 56385e2

Browse files
authored
CLOUDP-363397: Remove old SDK badge and references (#2984)
* CLOUDP-363397: Remove old SDK badge and references * Remove also related comments to the old SDK
1 parent b247184 commit 56385e2

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# MongoDB Atlas Operator
22

33
[![MongoDB Atlas Operator](https://github.com/mongodb/mongodb-atlas-kubernetes/workflows/Test/badge.svg)](https://github.com/mongodb/mongodb-atlas-kubernetes/actions/workflows/test.yml?query=branch%3Amain)
4-
[![MongoDB Atlas Go Client](https://img.shields.io/badge/Powered%20by%20-go--client--mongodb--atlas-%2313AA52)](https://github.com/mongodb/go-client-mongodb-atlas)
54

65
The MongoDB Atlas Operator provides a native integration between the Kubernetes orchestration platform and MongoDB Atlas
76
— the only multi-cloud document database service that gives you the versatility you need to build sophisticated and

docs/testing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ For Kubernetes, the [operator-runtime library has a fake package](https://pkg.go
6060

6161
### Atlas
6262

63-
For Atlas, the operator currently uses the [go-client-mongodb-atlas](https://github.com/mongodb/go-client-mongodb-atlas#go-client-mongodb-atlas). This [client main struct is composed of a set of interfaces](https://pkg.go.dev/go.mongodb.org/[email protected]/mongodbatlas#Client), one per Service behind Atlas. A simple way to mock such a client for unit tests, that will probably only call a couple of API endpoints from Atlas at a time, is to replace those service implementations by the mock:
63+
For Atlas, the operator currently uses the [Atlas Go SDK](https://github.com/mongodb/atlas-sdk-go). This [client main struct is composed of a set of interfaces](https://pkg.go.dev/go.mongodb.org/[email protected]/mongodbatlas#Client), one per Service behind Atlas. A simple way to mock such a client for unit tests, that will probably only call a couple of API endpoints from Atlas at a time, is to replace those service implementations by the mock:
6464

6565
- The mock is an struct that implements the Service interface by calling methods set in that struct for each of the interface methods defined. [See sample below](#sample-snippets).
6666
- Under `test/atlas` you should find all mocked services already being unit tested using this approach.

test/int/deployment_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,6 @@ var _ = Describe("AtlasDeployment", Label("int", "AtlasDeployment", "deployment-
619619
checkAtlasState(func(c *admin.ClusterDescription20240805) {
620620
// Expect(*c.DiskSizeGB).To(BeEquivalentTo(prevDiskSize)) // todo: find out if this should still work for advanced clusters
621621

622-
// check whether https://github.com/mongodb/go-client-mongodb-atlas/issues/140 is fixed
623622
Expect(c.GetReplicationSpecs()[0].GetRegionConfigs()[0].ElectableSpecs.DiskSizeGB).To(BeAssignableToTypeOf(pointer.MakePtr[float64](0)), "DiskSizeGB is no longer a *float64, please check the spec!")
624623
})
625624
})
@@ -691,7 +690,6 @@ var _ = Describe("AtlasDeployment", Label("int", "AtlasDeployment", "deployment-
691690
checkAtlasState(func(c *admin.ClusterDescription20240805) {
692691
Expect(int(c.GetReplicationSpecs()[0].GetRegionConfigs()[0].ElectableSpecs.GetDiskSizeGB())).To(BeEquivalentTo(*createdDeployment.Spec.DeploymentSpec.DiskSizeGB))
693692

694-
// check whether https://github.com/mongodb/go-client-mongodb-atlas/issues/140 is fixed
695693
Expect(c.GetReplicationSpecs()[0].GetRegionConfigs()[0].ElectableSpecs.DiskSizeGB).To(BeAssignableToTypeOf(pointer.MakePtr[float64](0)), "DiskSizeGB is no longer a *float64, please check the spec!")
696694
})
697695
})

0 commit comments

Comments
 (0)