Fix network peering test names (#749)

Author: Sugar-pack

test/e2e/actions/networkpeer/azure.go

@@ -9,6 +9,7 @@ import (
 )
 
 const AzureResourceGroupName = "atlas-operator-test"
+const AzureVPCName = "test-vnet"
 
 /*
 For network peering to work with Azure, it's necessary to fulfill the requirements described in the documentation. https://www.mongodb.com/docs/atlas/reference/api/vpc-create-peering-connection/#request-path-parameters

test/e2e/actions/networkpeer/gcp.go

@@ -8,6 +8,8 @@ import (
 	"google.golang.org/api/compute/v1"
 )
 
+const GCPVPCName = "network-peering-gcp-1-vpc"
+
 func CreateVPCForGCP(gcpProjectID string, vnetName string) error {
 	computeService, err := compute.NewService(context.Background())
 	if err != nil {

test/e2e/network_peering_test.go

@@ -102,7 +102,7 @@ var _ = Describe("NetworkPeering", Label("networkpeering"), func() {
 			).WithProject(data.DefaultProject()),
 			[]v1.NetworkPeer{
 				{
-					ProviderName:        "AWS",
+					ProviderName:        provider.ProviderAWS,
 					AccepterRegionName:  config.AWSRegionUS,
 					ContainerRegion:     config.AWSRegionUS,
 					RouteTableCIDRBlock: "10.0.0.0/24",
@@ -113,14 +113,14 @@ var _ = Describe("NetworkPeering", Label("networkpeering"), func() {
 		Entry("Test[networkpeering-aws-2]: User has project which was updated with AWS PrivateEndpoint",
 			Label("network-peering-aws-2"),
 			model.DataProvider(
-				"networkpeering-aws-1",
+				"networkpeering-aws-2",
 				model.NewEmptyAtlasKeyType().UseDefaulFullAccess(),
 				40000,
 				[]func(*model.TestDataProvider){},
 			).WithProject(data.DefaultProject()),
 			[]v1.NetworkPeer{
 				{
-					ProviderName:        "AWS",
+					ProviderName:        provider.ProviderAWS,
 					AccepterRegionName:  config.AWSRegionEU,
 					ContainerRegion:     config.AWSRegionUS,
 					RouteTableCIDRBlock: "10.0.0.0/24",
@@ -131,21 +131,21 @@ var _ = Describe("NetworkPeering", Label("networkpeering"), func() {
 		Entry("Test[networkpeering-aws-3]: User has project which was updated with AWS PrivateEndpoint",
 			Label("network-peering-aws-3"),
 			model.DataProvider(
-				"networkpeering-aws-1",
+				"networkpeering-aws-3",
 				model.NewEmptyAtlasKeyType().UseDefaulFullAccess(),
 				40000,
 				[]func(*model.TestDataProvider){},
 			).WithProject(data.DefaultProject()),
 			[]v1.NetworkPeer{
 				{
-					ProviderName:        "AWS",
+					ProviderName:        provider.ProviderAWS,
 					AccepterRegionName:  config.AWSRegionEU,
 					ContainerRegion:     config.AWSRegionUS,
 					RouteTableCIDRBlock: "192.168.0.0/16",
 					AtlasCIDRBlock:      "10.8.0.0/22",
 				},
 				{
-					ProviderName:        "AWS",
+					ProviderName:        provider.ProviderAWS,
 					AccepterRegionName:  config.AWSRegionUS,
 					RouteTableCIDRBlock: "10.0.0.0/24",
 					AtlasCIDRBlock:      "10.8.0.0/22",
@@ -155,36 +155,36 @@ var _ = Describe("NetworkPeering", Label("networkpeering"), func() {
 		Entry("Test[networkpeering-gcp-1]: User has project which was updated with GCP PrivateEndpoint",
 			Label("network-peering-gcp-1"),
 			model.DataProvider(
-				"networkpeering-aws-1",
+				"networkpeering-gcp-1",
 				model.NewEmptyAtlasKeyType().UseDefaulFullAccess(),
 				40000,
 				[]func(*model.TestDataProvider){},
 			).WithProject(data.DefaultProject()),
 			[]v1.NetworkPeer{
 				{
-					ProviderName:        "GCP",
+					ProviderName:        provider.ProviderGCP,
 					AccepterRegionName:  config.GCPRegion,
 					RouteTableCIDRBlock: "192.168.0.0/16",
 					AtlasCIDRBlock:      "10.8.0.0/18",
-					NetworkName:         newRandomVPCName("network-peering-gcp-1-vpc"),
+					NetworkName:         newRandomVPCName(networkpeer.GCPVPCName),
 					GCPProjectID:        cloud.GoogleProjectID,
 				},
 			},
 		),
 		Entry("Test[networkpeering-azure-1]: User has project which was updated with Azure PrivateEndpoint",
 			Label("network-peering-azure-1"),
 			model.DataProvider(
-				"networkpeering-aws-1",
+				"networkpeering-azure-1",
 				model.NewEmptyAtlasKeyType().UseDefaulFullAccess(),
 				40000,
 				[]func(*model.TestDataProvider){},
 			).WithProject(data.DefaultProject()),
 			[]v1.NetworkPeer{
 				{
-					ProviderName:        "AZURE",
+					ProviderName:        provider.ProviderAzure,
 					AccepterRegionName:  "US_EAST_2",
 					AtlasCIDRBlock:      "192.168.248.0/21",
-					VNetName:            newRandomVPCName("test-vnet"),
+					VNetName:            newRandomVPCName(networkpeer.AzureVPCName),
 					AzureSubscriptionID: os.Getenv(networkpeer.SubscriptionID),
 					ResourceGroupName:   networkpeer.AzureResourceGroupName,
 					AzureDirectoryID:    os.Getenv(networkpeer.DirectoryID),