return errors on reconciler registration

Author: s-urbaniak

internal/controller/registry.go

@@ -100,7 +100,9 @@ func (r *Registry) RegisterWithDryRunManager(mgr *dryrun.Manager, ap atlas.Provi
 }
 
 func (r *Registry) RegisterWithManager(mgr ctrl.Manager, skipNameValidation bool, ap atlas.Provider) error {
-	r.registerControllers(mgr, ap)
+	if err := r.registerControllers(mgr, ap); err != nil {
+		return fmt.Errorf("error registering controllers: %w", err)
+	}
 
 	for _, reconciler := range r.reconcilers {
 		if err := reconciler.SetupWithManager(mgr, skipNameValidation); err != nil {
@@ -110,9 +112,9 @@ func (r *Registry) RegisterWithManager(mgr ctrl.Manager, skipNameValidation bool
 	return nil
 }
 
-func (r *Registry) registerControllers(c cluster.Cluster, ap atlas.Provider) {
+func (r *Registry) registerControllers(c cluster.Cluster, ap atlas.Provider) error {
 	if len(r.reconcilers) > 0 {
-		return
+		return nil
 	}
 
 	var reconcilers []Reconciler
@@ -140,9 +142,8 @@ func (r *Registry) registerControllers(c cluster.Cluster, ap atlas.Provider) {
 		// Add experimental controllers here
 		reconcilers = append(reconcilers, connectionsecret.NewConnectionSecretReconciler(c, r.defaultPredicates(), ap, r.logger, r.globalSecretRef))
 		groupReconciler, err := group.NewGroupReconciler(c, ap, r.logger, r.globalSecretRef, r.deletionProtection, true, r.defaultPredicates())
-		// TODO(sur) remove this
 		if err != nil {
-			panic(err)
+			return fmt.Errorf("error creating group reconciler: %v", err)
 		}
 		reconcilers = append(reconcilers, newCtrlStateReconciler(groupReconciler, r.maxConcurrentReconciles))
 	}