Skip to content

Commit cd789da

Browse files
committed
fix controller registration
1 parent 41f7ff0 commit cd789da

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

internal/controller/registry.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ func NewRegistry(predicates []predicate.Predicate, deletionProtection bool, logg
9090
}
9191

9292
func (r *Registry) RegisterWithDryRunManager(mgr *dryrun.Manager, ap atlas.Provider) error {
93-
r.registerControllers(mgr, ap)
93+
if err := r.registerControllers(mgr, ap); err != nil {
94+
return fmt.Errorf("error registering controllers: %w", err)
95+
}
9496

9597
for _, reconciler := range r.reconcilers {
9698
mgr.SetupReconciler(reconciler)
@@ -143,12 +145,14 @@ func (r *Registry) registerControllers(c cluster.Cluster, ap atlas.Provider) err
143145
reconcilers = append(reconcilers, connectionsecret.NewConnectionSecretReconciler(c, r.defaultPredicates(), ap, r.logger, r.globalSecretRef))
144146
groupReconciler, err := group.NewGroupReconciler(c, ap, r.logger, r.globalSecretRef, r.deletionProtection, true, r.defaultPredicates())
145147
if err != nil {
146-
return fmt.Errorf("error creating group reconciler: %v", err)
148+
return fmt.Errorf("error creating group reconciler: %w", err)
147149
}
148150
reconcilers = append(reconcilers, newCtrlStateReconciler(groupReconciler, r.maxConcurrentReconciles))
149151
}
150152

151153
r.reconcilers = reconcilers
154+
155+
return nil
152156
}
153157

154158
// deprecatedPredicates are to be phased out in favor of defaultPredicates

0 commit comments

Comments
 (0)