Translation layer for upgrade flex cluster (#2432)

Author: helderjs

internal/mocks/translation/atlas_deployments_service.go

@@ -1244,3 +1244,22 @@ func flexUpdateToAtlas(flex *Flex) *admin.FlexClusterDescriptionUpdate20241113 {
 		TerminationProtectionEnabled: &flex.TerminationProtectionEnabled,
 	}
 }
+
+func flexUpgradeToAtlas(flex *Flex) *admin.AtlasTenantClusterUpgradeRequest20240805 {
+	cluster := flex.GetCustomResource().Spec.DeploymentSpec
+	return &admin.AtlasTenantClusterUpgradeRequest20240805{
+		ClusterType:                  pointer.MakePtrOrNil(cluster.ClusterType),
+		MongoDBMajorVersion:          pointer.MakePtrOrNil(cluster.MongoDBMajorVersion),
+		VersionReleaseSystem:         pointer.MakePtrOrNil(cluster.VersionReleaseSystem),
+		BackupEnabled:                cluster.BackupEnabled,
+		BiConnector:                  biConnectToAtlas(cluster.BiConnector),
+		EncryptionAtRestProvider:     pointer.MakePtrOrNil(cluster.EncryptionAtRestProvider),
+		Labels:                       labelsToAtlas(cluster.Labels),
+		Paused:                       cluster.Paused,
+		PitEnabled:                   cluster.PitEnabled,
+		ReplicationSpecs:             replicationSpecToAtlas(cluster.ReplicationSpecs, cluster.ClusterType, cluster.DiskSizeGB),
+		RootCertType:                 pointer.MakePtrOrNil(cluster.RootCertType),
+		Tags:                         tag.ToAtlas(cluster.Tags),
+		TerminationProtectionEnabled: pointer.MakePtrOrNil(cluster.TerminationProtectionEnabled),
+	}
+}

internal/mocks/translation/deployment_service.go

@@ -42,6 +42,7 @@ type DeploymentService interface {
 	CreateDeployment(ctx context.Context, deployment Deployment) (Deployment, error)
 	UpdateDeployment(ctx context.Context, deployment Deployment) (Deployment, error)
 	DeleteDeployment(ctx context.Context, deployment Deployment) error
+	UpgradeToDedicated(ctx context.Context, deployment Deployment) (Deployment, error)
 	ClusterWithProcessArgs(ctx context.Context, cluster *Cluster) error
 	UpdateProcessArgs(ctx context.Context, cluster *Cluster) error
 }
@@ -335,6 +336,24 @@ func (ds *ProductionAtlasDeployments) DeleteDeployment(ctx context.Context, depl
 	return nil
 }
 
+func (ds *ProductionAtlasDeployments) UpgradeToDedicated(ctx context.Context, deployment Deployment) (Deployment, error) {
+	switch d := deployment.(type) {
+	case *Cluster:
+		return nil, errors.New("upgrade from shared to dedicated is not supported")
+	case *Serverless:
+		return nil, errors.New("upgrade from serverless to dedicated is not supported")
+	case *Flex:
+		flex, _, err := ds.flexAPI.UpgradeFlexCluster(ctx, deployment.GetProjectID(), flexUpgradeToAtlas(d)).Execute()
+		if err != nil {
+			return nil, err
+		}
+
+		return flexFromAtlas(flex), nil
+	}
+
+	return nil, errors.New("unable to upgrade deployment: unknown type")
+}
+
 func (ds *ProductionAtlasDeployments) ClusterWithProcessArgs(ctx context.Context, cluster *Cluster) error {
 	config, _, err := ds.clustersAPI.GetClusterAdvancedConfiguration(ctx, cluster.GetProjectID(), cluster.GetName()).Execute()
 	if err != nil {

internal/translation/deployment/conversion.go

@@ -970,6 +970,100 @@ func TestUpdateProcessArgs(t *testing.T) {
 	}
 }
 
+func TestUpgradeCluster(t *testing.T) {
+	tests := map[string]struct {
+		deployment Deployment
+		apiMocker  func() (admin.ClustersApi, admin.ServerlessInstancesApi, admin.FlexClustersApi)
+		result     Deployment
+		err        error
+	}{
+		"should fail to upgrade shared cluster in atlas": {
+			deployment: &Cluster{},
+			apiMocker: func() (admin.ClustersApi, admin.ServerlessInstancesApi, admin.FlexClustersApi) {
+				clusterAPI := mockadmin.NewClustersApi(t)
+				serverlessInstanceAPI := mockadmin.NewServerlessInstancesApi(t)
+				flexAPI := mockadmin.NewFlexClustersApi(t)
+				return clusterAPI, serverlessInstanceAPI, flexAPI
+			},
+			err: errors.New("upgrade from shared to dedicated is not supported"),
+		},
+		"should fail to upgrade serverless instance in atlas": {
+			deployment: &Serverless{},
+			apiMocker: func() (admin.ClustersApi, admin.ServerlessInstancesApi, admin.FlexClustersApi) {
+				clusterAPI := mockadmin.NewClustersApi(t)
+				serverlessInstanceAPI := mockadmin.NewServerlessInstancesApi(t)
+				flexAPI := mockadmin.NewFlexClustersApi(t)
+				return clusterAPI, serverlessInstanceAPI, flexAPI
+			},
+			err: errors.New("upgrade from serverless to dedicated is not supported"),
+		},
+		"should fail to upgrade flex instance in atlas": {
+			deployment: &Flex{
+				ProjectID: "project-id",
+				customResource: &akov2.AtlasDeployment{
+					Spec: akov2.AtlasDeploymentSpec{
+						DeploymentSpec: &akov2.AdvancedDeploymentSpec{},
+					},
+				},
+			},
+			apiMocker: func() (admin.ClustersApi, admin.ServerlessInstancesApi, admin.FlexClustersApi) {
+				clusterAPI := mockadmin.NewClustersApi(t)
+				serverlessInstanceAPI := mockadmin.NewServerlessInstancesApi(t)
+				flexAPI := mockadmin.NewFlexClustersApi(t)
+				flexAPI.EXPECT().UpgradeFlexCluster(context.Background(), "project-id", mock.AnythingOfType("*admin.AtlasTenantClusterUpgradeRequest20240805")).
+					Return(admin.UpgradeFlexClusterApiRequest{ApiService: flexAPI})
+				flexAPI.EXPECT().UpgradeFlexClusterExecute(mock.AnythingOfType("admin.UpgradeFlexClusterApiRequest")).
+					Return(nil, &http.Response{}, errors.New("failed to upgrade flex cluster in atlas"))
+				return clusterAPI, serverlessInstanceAPI, flexAPI
+			},
+			err: errors.New("failed to upgrade flex cluster in atlas"),
+		},
+		"should upgrade flex instance in atlas": {
+			deployment: &Flex{
+				ProjectID: "project-id",
+				customResource: &akov2.AtlasDeployment{
+					Spec: akov2.AtlasDeploymentSpec{
+						DeploymentSpec: &akov2.AdvancedDeploymentSpec{},
+					},
+				},
+			},
+			apiMocker: func() (admin.ClustersApi, admin.ServerlessInstancesApi, admin.FlexClustersApi) {
+				clusterAPI := mockadmin.NewClustersApi(t)
+				serverlessInstanceAPI := mockadmin.NewServerlessInstancesApi(t)
+				flexAPI := mockadmin.NewFlexClustersApi(t)
+				flexAPI.EXPECT().UpgradeFlexCluster(context.Background(), "project-id", mock.AnythingOfType("*admin.AtlasTenantClusterUpgradeRequest20240805")).
+					Return(admin.UpgradeFlexClusterApiRequest{ApiService: flexAPI})
+				flexAPI.EXPECT().UpgradeFlexClusterExecute(mock.AnythingOfType("admin.UpgradeFlexClusterApiRequest")).
+					Return(
+						&admin.FlexClusterDescription20241113{GroupId: pointer.MakePtr("project-id")},
+						&http.Response{},
+						nil,
+					)
+				return clusterAPI, serverlessInstanceAPI, flexAPI
+			},
+			result: &Flex{
+				FlexSpec: &akov2.FlexSpec{
+					Tags:             []*akov2.TagSpec{},
+					ProviderSettings: &akov2.FlexProviderSettings{},
+				},
+				ProjectID:  "project-id",
+				Connection: &status.ConnectionStrings{},
+			},
+		},
+	}
+
+	for name, tt := range tests {
+		t.Run(name, func(t *testing.T) {
+			clusterAPI, serverlessInstanceAPI, flexAPI := tt.apiMocker()
+			service := NewAtlasDeployments(clusterAPI, serverlessInstanceAPI, nil, flexAPI, false)
+
+			result, err := service.UpgradeToDedicated(context.Background(), tt.deployment)
+			require.Equal(t, tt.err, err)
+			assert.Equal(t, tt.result, result)
+		})
+	}
+}
+
 func atlasAPIError(code string) *admin.GenericOpenAPIError {
 	err := admin.GenericOpenAPIError{}
 	err.SetModel(admin.ApiError{ErrorCode: code})