Fix S1033 - Unnecessary guard around call to delete

josvazg · josvazg · commit e6f38860a7fe · 2025-11-12T11:46:52.000+01:00
diff --git a/tools/openapi2crd/pkg/plugins/skipped_properties.go b/tools/openapi2crd/pkg/plugins/skipped_properties.go
@@ -18,7 +18,7 @@ package plugins
 import (
 	"slices"
 
-	configv1alpha1 "github.com/mongodb/mongodb-atlas-kubernetestools/openapi2crd/pkg/apis/config/v1alpha1"
+	configv1alpha1 "github.com/mongodb/mongodb-atlas-kubernetes/tools/openapi2crd/pkg/apis/config/v1alpha1"
 )
 
 type SkippedProperties struct{}
@@ -40,9 +40,7 @@ func (p *SkippedProperties) Process(req *PropertyProcessorRequest) error {
 	}
 
 	for _, s := range req.PropertyConfig.Filters.SkipProperties {
-		if _, ok := requiredPaths[s]; ok {
-			delete(requiredPaths, s)
-		}
+		delete(requiredPaths, s)
 	}
 
 	req.Property.Required = make([]string, 0, len(req.Property.Required))

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ package plugins`
`18`	`18`	`import (`
`19`	`19`	`"slices"`
`20`	`20`
`21`		`- configv1alpha1 "github.com/mongodb/mongodb-atlas-kubernetestools/openapi2crd/pkg/apis/config/v1alpha1"`
	`21`	`+ configv1alpha1 "github.com/mongodb/mongodb-atlas-kubernetes/tools/openapi2crd/pkg/apis/config/v1alpha1"`
`22`	`22`	`)`
`23`	`23`
`24`	`24`	`type SkippedProperties struct{}`
`@@ -40,9 +40,7 @@ func (p SkippedProperties) Process(req PropertyProcessorRequest) error {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`for _, s := range req.PropertyConfig.Filters.SkipProperties {`
`43`		`- if _, ok := requiredPaths[s]; ok {`
`44`		`- delete(requiredPaths, s)`
`45`		`- }`
	`43`	`+ delete(requiredPaths, s)`
`46`	`44`	`}`
`47`	`45`
`48`	`46`	`req.Property.Required = make([]string, 0, len(req.Property.Required))`