feat: add persistentVolumeClaimRetentionPolicy

Author: lenglet-k

pkg/kube/statefulset/merge_statefulset_test.go

@@ -60,13 +60,17 @@ func TestGetLabelSelectorRequirementByKey(t *testing.T) {
 }
 
 func TestMergeSpec(t *testing.T) {
+	var overridePersistentVolumeClaimRetentionPolicy appsv1.StatefulSetPersistentVolumeClaimRetentionPolicy
+	overridePersistentVolumeClaimRetentionPolicy.WhenDeleted = "Deleted"
+	overridePersistentVolumeClaimRetentionPolicy.WhenScaled = "Deleted"
 
 	original := New(
 		WithName("original"),
 		WithServiceName("original-svc-name"),
 		WithReplicas(3),
 		WithRevisionHistoryLimit(10),
 		WithPodManagementPolicyType(appsv1.OrderedReadyPodManagement),
+		WithPersistentVolumeClaimRetentionPolicy(appsv1.StatefulSetPersistentVolumeClaimRetentionPolicy{}),
 		WithSelector(&metav1.LabelSelector{
 			MatchLabels: map[string]string{
 				"a": "1",
@@ -95,6 +99,7 @@ func TestMergeSpec(t *testing.T) {
 		WithReplicas(5),
 		WithRevisionHistoryLimit(15),
 		WithPodManagementPolicyType(appsv1.ParallelPodManagement),
+		WithPersistentVolumeClaimRetentionPolicy(overridePersistentVolumeClaimRetentionPolicy),
 		WithSelector(&metav1.LabelSelector{
 			MatchLabels: map[string]string{
 				"a": "10",
@@ -124,6 +129,7 @@ func TestMergeSpec(t *testing.T) {
 		assert.Equal(t, int32(5), *mergedSpec.Replicas)
 		assert.Equal(t, int32(15), *mergedSpec.RevisionHistoryLimit)
 		assert.Equal(t, appsv1.ParallelPodManagement, mergedSpec.PodManagementPolicy)
+		assert.Equal(t, overridePersistentVolumeClaimRetentionPolicy, *mergedSpec.PersistentVolumeClaimRetentionPolicy)
 	})
 
 	matchLabels := mergedSpec.Selector.MatchLabels

pkg/kube/statefulset/statefulset.go

@@ -315,6 +315,12 @@ func WithObjectMetadata(labels map[string]string, annotations map[string]string)
 	}
 }
 
+func WithPersistentVolumeClaimRetentionPolicy(persistentVolumeClaimRetentionPolicy appsv1.StatefulSetPersistentVolumeClaimRetentionPolicy) Modification {
+	return func(set *appsv1.StatefulSet) {
+		set.Spec.PersistentVolumeClaimRetentionPolicy = &persistentVolumeClaimRetentionPolicy
+	}
+}
+
 func findVolumeClaimIndexByName(name string, pvcs []corev1.PersistentVolumeClaim) int {
 	for idx, pvc := range pvcs {
 		if pvc.Name == name {

pkg/util/merge/merge_statefulset.go

@@ -53,6 +53,13 @@ func StatefulSetSpecs(defaultSpec, overrideSpec appsv1.StatefulSetSpec) appsv1.S
 		mergedSpec.ServiceName = overrideSpec.ServiceName
 	}
 
+	if overrideSpec.PersistentVolumeClaimRetentionPolicy.WhenDeleted != "" {
+		mergedSpec.PersistentVolumeClaimRetentionPolicy.WhenDeleted = overrideSpec.PersistentVolumeClaimRetentionPolicy.WhenDeleted
+	}
+
+	if overrideSpec.PersistentVolumeClaimRetentionPolicy.WhenScaled != "" {
+		mergedSpec.PersistentVolumeClaimRetentionPolicy.WhenScaled = overrideSpec.PersistentVolumeClaimRetentionPolicy.WhenScaled
+	}
 	mergedSpec.Template = PodTemplateSpecs(defaultSpec.Template, overrideSpec.Template)
 	mergedSpec.VolumeClaimTemplates = VolumeClaimTemplates(defaultSpec.VolumeClaimTemplates, overrideSpec.VolumeClaimTemplates)
 	return mergedSpec