CLOUDP-79509: Added deleter interface (#547)

Author: Nikolas De Giorgis

pkg/kube/client/client.go

@@ -28,7 +28,7 @@ type Client interface {
 	// TODO: remove this function, add mongodb package which has GetAndUpdate function
 	GetAndUpdate(nsName types.NamespacedName, obj k8sClient.Object, updateFunc func()) error
 	configmap.GetUpdateCreateDeleter
-	service.GetUpdateCreator
+	service.GetUpdateCreateDeleter
 	secret.GetUpdateCreateDeleter
 	statefulset.GetUpdateCreateDeleter
 	pod.Getter
@@ -139,6 +139,17 @@ func (c client) CreateService(service corev1.Service) error {
 	return c.Create(context.TODO(), &service)
 }
 
+// DeleteService provides a thin wrapper around client.Client to delete corev1.Service types
+func (c client) DeleteService(objectKey k8sClient.ObjectKey) error {
+	svc := corev1.Service{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      objectKey.Name,
+			Namespace: objectKey.Namespace,
+		},
+	}
+	return c.Delete(context.TODO(), &svc)
+}
+
 // GetStatefulSet provides a thin wrapper and client.Client to access appsv1.StatefulSet types
 func (c client) GetStatefulSet(objectKey k8sClient.ObjectKey) (appsv1.StatefulSet, error) {
 	sts := appsv1.StatefulSet{}

pkg/kube/service/service.go

@@ -10,11 +10,20 @@ type Getter interface {
 }
 
 type Updater interface {
-	UpdateService(secret corev1.Service) error
+	UpdateService(service corev1.Service) error
 }
 
 type Creator interface {
-	CreateService(secret corev1.Service) error
+	CreateService(service corev1.Service) error
+}
+
+type Deleter interface {
+	DeleteService(objectKey client.ObjectKey) error
+}
+
+type GetDeleter interface {
+	Getter
+	Deleter
 }
 
 type GetUpdater interface {
@@ -28,6 +37,13 @@ type GetUpdateCreator interface {
 	Creator
 }
 
+type GetUpdateCreateDeleter interface {
+	Getter
+	Updater
+	Creator
+	Deleter
+}
+
 // Merge merges `source` into `dest`. Both arguments will remain unchanged
 // a new service will be created and returned.
 // The "merging" process is arbitrary and it only handle specific attributes