Add validation to ensure consistent replicas (#1263)

Signed-off-by: hoyhbx <[email protected]>

Author: hoyhbx

controllers/replicaset_controller_test.go

@@ -1184,6 +1184,19 @@ func TestCustomDataDir_Configuration(t *testing.T) {
 	}
 }
 
+func TestInconsistentReplicas(t *testing.T) {
+	mdb := newTestReplicaSet()
+	stsReplicas := new(int32)
+	*stsReplicas = 3
+	mdb.Spec.StatefulSetConfiguration.SpecWrapper.Spec.Replicas = stsReplicas
+	mdb.Spec.Members = 4
+
+	mgr := client.NewManager(&mdb)
+	r := NewReconciler(mgr)
+	_, err := r.Reconcile(context.TODO(), reconcile.Request{NamespacedName: types.NamespacedName{Namespace: mdb.Namespace, Name: mdb.Name}})
+	assert.NoError(t, err)
+}
+
 func assertVolumeMountPath(t *testing.T, mounts []corev1.VolumeMount, name, path string) {
 	for _, v := range mounts {
 		if v.Name == name {

controllers/validation/validation.go

@@ -37,6 +37,10 @@ func validateSpec(mdb mdbv1.MongoDBCommunity, log *zap.SugaredLogger) error {
 		return err
 	}
 
+	if err := validateStatefulSet(mdb); err != nil {
+		return err
+	}
+
 	return nil
 }
 
@@ -125,3 +129,13 @@ func validateAuthModeSpec(mdb mdbv1.MongoDBCommunity, log *zap.SugaredLogger) er
 
 	return nil
 }
+
+func validateStatefulSet(mdb mdbv1.MongoDBCommunity) error {
+	stsReplicas := mdb.Spec.StatefulSetConfiguration.SpecWrapper.Spec.Replicas
+
+	if stsReplicas != nil && *stsReplicas != int32(mdb.Spec.Members) {
+		return fmt.Errorf("spec.statefulset.spec.replicas has to be equal to spec.members")
+	}
+
+	return nil
+}