CLOUDP-309402: MEKO MCK migration + rename enterprise resources (#18)

# Summary

## Short Summary

This PR contains 2 main set of changes:

- A new upgrade test, from MEKO to MCK. It runs in single and multi
cluster mode. The test deploys a replicaset, and perform the upgrade
steps recommended for migration.
- A rename of most components created by the operator, such as service
accounts, to make the upgrade possible without conflict between old and
new resources. When the MCK helm chart is installed, new service
accounts are created and the operator updates the stateful sets so that
the pods use the new ones.

## List of changes

### Renaming
- Introduced many variables for resource names.
- Service Accounts, RBAC Resources, Services
- Operator name, deployment name
- Selectors and labels stay the same (`mongodb-enterprise-operator`)
because for some resources it is impossible to change them without
deleting it.
- Some components kept their old names such as config map and secrets
for multi-cluster.

### Tests
- New helper functions to install the new MCK operator, to handle the
two deployments.
- Updated all existing upgrade tests to handle both deployments running
concurrently (scale down first operator before installing the second
one). This means that our existing tests are all testing a MEKO to MCK
upgrade, and some specific ones are testing other paths, such as the
sharded cluster upgrade which is doing 1.27 -> MCK.
- New MEKO to MCK dedicated test, working in both single and multi
cluster setting. Deploys a replica set and ensure the migration happens
correctly.

## Note

It is hard to ensure the renaming is completely exhaustive. The upgrade
tests ensure we renamed necessary resources to ensure a smooth upgrade
with no conflicts. Follow up PRs are/will be opened to rename smaller
things like file names.

There is still one e2e test failing that we are currently investigating,
but we preferred to open the PR early for review.

## Proof of Work

E2E test

## Checklist
- [X] Have you linked a jira ticket and/or is the ticket in the title?
- [X] Have you checked whether your jira ticket required DOCSP changes?

---------

Co-authored-by: Yavor Georgiev <[email protected]>
Co-authored-by: Nam Nguyen <[email protected]>

Author: 3 people

.evergreen-tasks.yml

@@ -185,6 +185,11 @@ tasks:
     commands:
       - func: "e2e_test"
 
+  - name: e2e_meko_mck_upgrade
+    tags: [ "patch-run" ]
+    commands:
+      - func: "e2e_test"
+
   - name: e2e_olm_operator_upgrade
     # TODO: CLOUDP-310820 - After 1.0.0 release we need re-enable this
     disable: true

.evergreen.yml

@@ -793,6 +793,7 @@ task_groups:
       - e2e_operator_clusterwide
       - e2e_operator_multi_namespaces
       - e2e_operator_upgrade_appdb_tls
+      - e2e_meko_mck_upgrade
     <<: *teardown_group
 
   # e2e_operator_race_with_telemetry_task_group includes the tests for testing the operator with race detector enabled
@@ -820,6 +821,7 @@ task_groups:
       - e2e_operator_clusterwide
       - e2e_operator_multi_namespaces
       - e2e_operator_upgrade_appdb_tls
+      - e2e_meko_mck_upgrade
     <<: *teardown_group
 
   - name: e2e_multi_cluster_kind_task_group
@@ -887,6 +889,7 @@ task_groups:
       - e2e_tls_sc_additional_certs
       - e2e_tls_x509_configure_all_options_sc
       - e2e_tls_x509_sc
+      - e2e_meko_mck_upgrade
 
     <<: *teardown_group
 

Makefile

@@ -399,5 +399,9 @@ dockerfiles:
 prepare-local-e2e: reset-mco # prepares the local environment to run a local operator
 	scripts/dev/prepare_local_e2e_run.sh
 
+prepare-local-olm-e2e:
+	DIGEST_PINNING_ENABLED=false VERSION_ID=latest scripts/evergreen/operator-sdk/prepare-openshift-bundles-for-e2e.sh
+	scripts/dev/prepare_local_e2e_olm_run.sh
+
 prepare-operator-configmap: # prepares the local environment to run a local operator
 	source scripts/dev/set_env_context.sh && source scripts/funcs/printing && source scripts/funcs/operator_deployment && prepare_operator_config_map "$(kubectl config current-context)"

api/v1/mdb/mongodb_types.go

@@ -158,7 +158,7 @@ func (m *MongoDB) GetResourceName() string {
 
 func (m *MongoDB) GetOwnerLabels() map[string]string {
 	return map[string]string{
-		util.OperatorLabelName: util.OperatorName,
+		util.OperatorLabelName: util.OperatorLabelValue,
 		LabelResourceOwner:     m.Name,
 	}
 }

api/v1/mdbmulti/mongodb_multi_types.go

@@ -169,7 +169,7 @@ func (m *MongoDBMultiCluster) ObjectKey() client.ObjectKey {
 
 func (m *MongoDBMultiCluster) GetOwnerLabels() map[string]string {
 	return map[string]string{
-		util.OperatorLabelName: util.OperatorName,
+		util.OperatorLabelName: util.OperatorLabelValue,
 		LabelResourceOwner:     fmt.Sprintf("%s-%s", m.Namespace, m.Name),
 	}
 }

api/v1/om/appdb_types.go

@@ -128,7 +128,7 @@ func (m *AppDBSpec) ObjectKey() client.ObjectKey {
 
 func (m *AppDBSpec) GetOwnerLabels() map[string]string {
 	return map[string]string{
-		util.OperatorLabelName: util.OperatorName,
+		util.OperatorLabelName: util.OperatorLabelValue,
 		LabelResourceOwner:     m.OpsManagerName,
 	}
 }

api/v1/om/opsmanager_types.go

@@ -344,7 +344,7 @@ func (om *MongoDBOpsManager) AppDBStatefulSetObjectKey(memberClusterNum int) cli
 
 func (om *MongoDBOpsManager) GetOwnerLabels() map[string]string {
 	return map[string]string{
-		util.OperatorLabelName: util.OperatorName,
+		util.OperatorLabelName: util.OperatorLabelValue,
 		LabelResourceOwner:     om.Name,
 	}
 }

config/manager/manager.yaml

@@ -3,25 +3,25 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: mongodb-enterprise-operator
+  name: mongodb-kubernetes-operator
   namespace: mongodb
 spec:
   replicas: 1
   selector:
     matchLabels:
       app.kubernetes.io/component: controller
-      app.kubernetes.io/name: mongodb-enterprise-operator
-      app.kubernetes.io/instance: mongodb-enterprise-operator
+      app.kubernetes.io/name: mongodb-kubernetes-operator
+      app.kubernetes.io/instance: mongodb-kubernetes-operator
   template:
     metadata:
       labels:
         app.kubernetes.io/component: controller
-        app.kubernetes.io/name: mongodb-enterprise-operator
-        app.kubernetes.io/instance: mongodb-enterprise-operator
+        app.kubernetes.io/name: mongodb-kubernetes-operator
+        app.kubernetes.io/instance: mongodb-kubernetes-operator
     spec:
-      serviceAccountName: mongodb-enterprise-operator
+      serviceAccountName: mongodb-kubernetes-operator
       containers:
-        - name: mongodb-enterprise-operator
+        - name: mongodb-kubernetes-operator
           image: "quay.io/mongodb/mongodb-kubernetes:0.1.0"
           imagePullPolicy: Always
           args:
@@ -104,7 +104,7 @@ spec:
                 fieldRef:
                   fieldPath: metadata.name
             - name: OPERATOR_NAME
-              value: mongodb-enterprise-operator
+              value: mongodb-kubernetes-operator
             # Community Env Vars Start
             - name: MDB_COMMUNITY_AGENT_IMAGE
               value: "quay.io/mongodb/mongodb-agent-ubi:108.0.2.8729-1"

config/rbac/database-roles.yaml

@@ -3,28 +3,28 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: mongodb-enterprise-appdb
+  name: mongodb-kubernetes-appdb
   namespace: mongodb
 ---
 # Source: mongodb-kubernetes/templates/database-roles.yaml
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: mongodb-enterprise-database-pods
+  name: mongodb-kubernetes-database-pods
   namespace: mongodb
 ---
 # Source: mongodb-kubernetes/templates/database-roles.yaml
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: mongodb-enterprise-ops-manager
+  name: mongodb-kubernetes-ops-manager
   namespace: mongodb
 ---
 # Source: mongodb-kubernetes/templates/database-roles.yaml
 kind: Role
 apiVersion: rbac.authorization.k8s.io/v1
 metadata:
-  name: mongodb-enterprise-appdb
+  name: mongodb-kubernetes-appdb
   namespace: mongodb
 rules:
   - apiGroups:
@@ -46,13 +46,13 @@ rules:
 kind: RoleBinding
 apiVersion: rbac.authorization.k8s.io/v1
 metadata:
-  name: mongodb-enterprise-appdb
+  name: mongodb-kubernetes-appdb
   namespace: mongodb
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: mongodb-enterprise-appdb
+  name: mongodb-kubernetes-appdb
 subjects:
   - kind: ServiceAccount
-    name: mongodb-enterprise-appdb
+    name: mongodb-kubernetes-appdb
     namespace: mongodb

config/rbac/kustomization.yaml

@@ -11,6 +11,6 @@ patchesJson6902:
       version: v1
       group: rbac.authorization.k8s.io
       kind: RoleBinding
-      name: mongodb-enterprise-appdb
+      name: mongodb-kubernetes-appdb
     path: database-roles-patch-namespace.yaml