Skip to content

Commit 187d79d

Browse files
committed
Fix Preview Release Notes GH Action for forks
Use hardcoded values instead of repo variables because variables are not available in the PRs created from forks.
1 parent 8b5472b commit 187d79d

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/preview_release_notes.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,10 @@ jobs:
2929
id: generate_release_notes
3030
run: python -m scripts.release.release_notes -s $INITIAL_COMMIT_SHA -v $INITIAL_VERSION -o release_notes_tmp.md
3131
env:
32-
INITIAL_COMMIT_SHA: ${{ vars.RELEASE_INITIAL_COMMIT_SHA }}
33-
INITIAL_VERSION: ${{ vars.RELEASE_INITIAL_VERSION }}
32+
# We can not use environments set via GitHub UI because they will
33+
# not be available in the pull requests running from forks.
34+
INITIAL_COMMIT_SHA: 9ed5f98fc70c5b3442f633d2393265fb8a2aba0c
35+
INITIAL_VERSION: 1.3.0
3436
- name: Add disclaimer to release notes preview
3537
run: |
3638
echo -e "_:warning: (this preview might not be accurate if the PR is not rebased on current master branch)_\n" > release_notes_preview.md

0 commit comments

Comments
 (0)