@@ -324,7 +324,7 @@ func TestKubeConfigSecret_IsNotCreated_InMemberClusters(t *testing.T) {
324
324
memberClient := clientMap [memberCluster ]
325
325
kubeConfigSecret , err := memberClient .CoreV1 ().Secrets (flags .CentralClusterNamespace ).Get (ctx , KubeConfigSecretName , metav1.GetOptions {})
326
326
assert .True (t , errors .IsNotFound (err ))
327
- assert .Nil ( t , kubeConfigSecret )
327
+ assert .Equal ( t , & corev1. Secret {} , kubeConfigSecret )
328
328
}
329
329
}
330
330
@@ -756,7 +756,7 @@ func assertClusterRoleMembers(t *testing.T, ctx context.Context, clientMap map[s
756
756
assert .Equal (t , expectedClusterRole , * role )
757
757
} else {
758
758
assert .Error (t , err )
759
- assert .Nil ( t , role )
759
+ assert .Equal ( t , & rbacv1. ClusterRole {} , role )
760
760
}
761
761
}
762
762
}
@@ -785,7 +785,7 @@ func assertMemberRolesAreCorrect(t *testing.T, ctx context.Context, clientMap ma
785
785
assert .Equal (t , expectedRole , * role )
786
786
} else {
787
787
assert .Error (t , err )
788
- assert .Nil ( t , role )
788
+ assert .Equal ( t , & rbacv1. Role {} , role )
789
789
}
790
790
}
791
791
}
@@ -810,7 +810,8 @@ func assertCentralRolesAreCorrect(t *testing.T, ctx context.Context, clientMap m
810
810
cr , err := client .RbacV1 ().ClusterRoles ().Get (ctx , clusterRole .Name , metav1.GetOptions {})
811
811
812
812
assert .True (t , errors .IsNotFound (err ))
813
- assert .Nil (t , cr )
813
+ assert .Equal (t , & rbacv1.ClusterRole {}, cr )
814
+ // assert.Nil(t, cr)
814
815
815
816
expectedRole := buildCentralEntityRole (flags .CentralClusterNamespace )
816
817
role , err := client .RbacV1 ().Roles (flags .CentralClusterNamespace ).Get (ctx , expectedRole .Name , metav1.GetOptions {})
@@ -821,7 +822,7 @@ func assertCentralRolesAreCorrect(t *testing.T, ctx context.Context, clientMap m
821
822
assert .Equal (t , expectedRole , * role )
822
823
} else {
823
824
assert .Error (t , err )
824
- assert .Nil ( t , role )
825
+ assert .Equal ( t , & rbacv1. Role {} , role )
825
826
}
826
827
}
827
828
0 commit comments