Skip to content

Commit 2c0e62c

Browse files
Fix issues in go tests
1 parent 4cf7c05 commit 2c0e62c

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

pkg/kubectl-mongodb/common/common_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ func TestKubeConfigSecret_IsNotCreated_InMemberClusters(t *testing.T) {
324324
memberClient := clientMap[memberCluster]
325325
kubeConfigSecret, err := memberClient.CoreV1().Secrets(flags.CentralClusterNamespace).Get(ctx, KubeConfigSecretName, metav1.GetOptions{})
326326
assert.True(t, errors.IsNotFound(err))
327-
assert.Nil(t, kubeConfigSecret)
327+
assert.Equal(t, &corev1.Secret{}, kubeConfigSecret)
328328
}
329329
}
330330

@@ -756,7 +756,7 @@ func assertClusterRoleMembers(t *testing.T, ctx context.Context, clientMap map[s
756756
assert.Equal(t, expectedClusterRole, *role)
757757
} else {
758758
assert.Error(t, err)
759-
assert.Nil(t, role)
759+
assert.Equal(t, &rbacv1.ClusterRole{}, role)
760760
}
761761
}
762762
}
@@ -785,7 +785,7 @@ func assertMemberRolesAreCorrect(t *testing.T, ctx context.Context, clientMap ma
785785
assert.Equal(t, expectedRole, *role)
786786
} else {
787787
assert.Error(t, err)
788-
assert.Nil(t, role)
788+
assert.Equal(t, &rbacv1.Role{}, role)
789789
}
790790
}
791791
}
@@ -810,7 +810,8 @@ func assertCentralRolesAreCorrect(t *testing.T, ctx context.Context, clientMap m
810810
cr, err := client.RbacV1().ClusterRoles().Get(ctx, clusterRole.Name, metav1.GetOptions{})
811811

812812
assert.True(t, errors.IsNotFound(err))
813-
assert.Nil(t, cr)
813+
assert.Equal(t, &rbacv1.ClusterRole{}, cr)
814+
// assert.Nil(t, cr)
814815

815816
expectedRole := buildCentralEntityRole(flags.CentralClusterNamespace)
816817
role, err := client.RbacV1().Roles(flags.CentralClusterNamespace).Get(ctx, expectedRole.Name, metav1.GetOptions{})
@@ -821,7 +822,7 @@ func assertCentralRolesAreCorrect(t *testing.T, ctx context.Context, clientMap m
821822
assert.Equal(t, expectedRole, *role)
822823
} else {
823824
assert.Error(t, err)
824-
assert.Nil(t, role)
825+
assert.Equal(t, &rbacv1.Role{}, role)
825826
}
826827
}
827828

0 commit comments

Comments
 (0)