@@ -127,8 +127,7 @@ def test_no_changes_detected(self):
127
127
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
128
128
):
129
129
130
- has_changes , changed_agents = detect_ops_manager_changes ()
131
- self .assertFalse (has_changes )
130
+ changed_agents = detect_ops_manager_changes ()
132
131
self .assertEqual (changed_agents , [])
133
132
134
133
def test_new_ops_manager_version_added (self ):
@@ -144,8 +143,7 @@ def test_new_ops_manager_version_added(self):
144
143
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
145
144
):
146
145
147
- has_changes , changed_agents = detect_ops_manager_changes ()
148
- self .assertTrue (has_changes )
146
+ changed_agents = detect_ops_manager_changes ()
149
147
self .assertIn (("108.0.0.8694-1" , "100.10.0" ), changed_agents )
150
148
151
149
def test_ops_manager_version_modified (self ):
@@ -160,8 +158,7 @@ def test_ops_manager_version_modified(self):
160
158
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
161
159
):
162
160
163
- has_changes , changed_agents = detect_ops_manager_changes ()
164
- self .assertTrue (has_changes )
161
+ changed_agents = detect_ops_manager_changes ()
165
162
self .assertIn (("12.0.35.7911-1" , "100.10.0" ), changed_agents )
166
163
167
164
def test_cloud_manager_changed (self ):
@@ -174,8 +171,7 @@ def test_cloud_manager_changed(self):
174
171
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
175
172
):
176
173
177
- has_changes , changed_agents = detect_ops_manager_changes ()
178
- self .assertTrue (has_changes )
174
+ changed_agents = detect_ops_manager_changes ()
179
175
self .assertIn (("13.38.0.9600-1" , "100.12.2" ), changed_agents )
180
176
181
177
def test_cloud_manager_tools_changed (self ):
@@ -188,8 +184,7 @@ def test_cloud_manager_tools_changed(self):
188
184
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
189
185
):
190
186
191
- has_changes , changed_agents = detect_ops_manager_changes ()
192
- self .assertTrue (has_changes )
187
+ changed_agents = detect_ops_manager_changes ()
193
188
self .assertIn (("13.37.0.9590-1" , "100.13.0" ), changed_agents )
194
189
195
190
def test_ops_manager_version_removed (self ):
@@ -202,8 +197,8 @@ def test_ops_manager_version_removed(self):
202
197
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
203
198
):
204
199
205
- has_changes , changed_agents = detect_ops_manager_changes ()
206
- self .assertTrue ( has_changes )
200
+ changed_agents = detect_ops_manager_changes ()
201
+ self .assertEqual ( changed_agents , [] )
207
202
208
203
def test_both_om_and_cm_changed (self ):
209
204
"""Test detection when both OM version and cloud manager are changed"""
@@ -219,8 +214,7 @@ def test_both_om_and_cm_changed(self):
219
214
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
220
215
):
221
216
222
- has_changes , changed_agents = detect_ops_manager_changes ()
223
- self .assertTrue (has_changes )
217
+ changed_agents = detect_ops_manager_changes ()
224
218
self .assertIn (("108.0.0.8694-1" , "100.10.0" ), changed_agents )
225
219
self .assertIn (("13.38.0.9600-1" , "100.12.2" ), changed_agents )
226
220
self .assertEqual (len (changed_agents ), 2 )
@@ -232,8 +226,7 @@ def test_current_release_load_failure(self):
232
226
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = self .master_release_data ),
233
227
):
234
228
235
- has_changes , changed_agents = detect_ops_manager_changes ()
236
- self .assertFalse (has_changes )
229
+ changed_agents = detect_ops_manager_changes ()
237
230
self .assertEqual (changed_agents , [])
238
231
239
232
def test_base_release_load_failure_fail_safe (self ):
@@ -243,8 +236,7 @@ def test_base_release_load_failure_fail_safe(self):
243
236
patch ("detect_ops_manager_changes.load_release_json_from_master" , return_value = None ),
244
237
):
245
238
246
- has_changes , changed_agents = detect_ops_manager_changes ()
247
- self .assertTrue (has_changes )
239
+ changed_agents = detect_ops_manager_changes ()
248
240
self .assertEqual (changed_agents , [])
249
241
250
242
0 commit comments