fix shellcheck files and cleanup the logs

Author: nammn

.githooks/pre-commit

@@ -202,7 +202,7 @@ wait_for_all_background_jobs() {
       for failure in "${failures[@]}"; do
         echo -e "$failure"
       done
-      echo -e "${RED}To see the details look for the job's logs by it's prefixed name (e.g. \"shellcheck:\").${NO_COLOR}"
+      echo -e "${RED}To see the details look for the job's logs by it's prefixed name (e.g. \"shellcheck failed\").${NO_COLOR}"
       return 1
     fi
 
@@ -229,7 +229,6 @@ pre_commit() {
 # Function to run shellcheck on a single file
 run_shellcheck() {
   local file="$1"
-  echo "Running shellcheck on $file"
 
   local diff_output
   diff_output=$(shellcheck -f diff "$file" -e SC2154 -e SC1091 -e SC1090 -e SC2148 -o require-variable-braces -P "scripts" 2>&1)

scripts/dev/recreate_python_venv.sh

@@ -77,7 +77,8 @@ ensure_required_python() {
             # Install python3-venv package for Debian/Ubuntu systems if needed
             if command -v apt-get &> /dev/null; then
                 echo "Installing python3-venv package for venv support..." >&2
-                sudo apt-get update -qq && sudo apt-get install -y python3-venv || true
+                sudo apt-get update -qq || true
+                sudo apt-get install -y python3-venv || true
             fi
             return 0
         fi

scripts/minikube/setup_minikube.sh

@@ -29,7 +29,7 @@ EOF
 }
 
 # retrieve arch variable off the shell command line
-ARCH=${1-"$(detect_architecture)"}
+ARCH="$(detect_architecture)"
 
 echo "Setting up minikube host for architecture: ${ARCH}"
 
@@ -63,7 +63,7 @@ setup_local_registry_and_custom_image() {
 
       # Wait for registry to be ready
       echo "Waiting for registry to be ready..."
-      for i in {1..30}; do
+      for _ in {1..30}; do
         if curl -s http://localhost:5000/v2/_catalog >/dev/null 2>&1; then
           break
         fi