You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
telemetry: always install binding and if potentially skip role (#4165)
# Summary
- rolebinding has unique namespaced name and can always be installed
- role is unique and should be skipped if configured that way
## Proof of Work
```
(venv) ~/projects/ops-manager-kubernetes git:[fix-helm-chart]
helm template operator-2 helm_chart --set operator.telemetry.installClusterRole=false | rg clusterVersion
# ClusterRoleBinding for clusterVersionDetection
(venv) ~/projects/ops-manager-kubernetes git:[fix-helm-chart]
helm template operator-2 helm_chart| rg clusterVersion
# Additional ClusterRole for clusterVersionDetection
# ClusterRoleBinding for clusterVersionDetection
```
## Checklist
- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [ ] Have you checked whether your jira ticket required DOCSP changes?
- [ ] Have you checked for release_note changes?
## Reminder (Please remove this when merging)
- Please try to Approve or Reject Changes the PR, keep PRs in review as
short as possible
- Our Short Guide for PRs:
[Link](REDACTED)
- Remember the following Communication Standards - use comment prefixes
for clarity:
* **blocking**: Must be addressed before approval.
* **follow-up**: Can be addressed in a later PR or ticket.
* **q**: Clarifying question.
* **nit**: Non-blocking suggestions.
* **note**: Side-note, non-actionable. Example: Praise
* --> no prefix is considered a question
0 commit comments