apply viveks feedback

Author: nammn

.evergreen-functions.yml

@@ -539,7 +539,7 @@ functions:
           - version_id
         add_to_path:
           - ${workdir}/bin
-        binary: scripts/evergreen/e2e/build_e2e_image_ibm.sh
+        binary: scripts/evergreen/e2e/build_tests_image_ibm.sh
 
   pipeline:
     - *switch_context

changelog/20250820_feature_multi_arch_support.md

@@ -6,4 +6,4 @@ date: 2025-08-20
 
 # Multi-Architecture Support
 We've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
-existing x86_64 support. All core images (operator, agent, init containers, database, readiness probe) now support multiple architectures
+existing x86_64 support. All core images (operator, agent, init containers, database, readiness probe) now support multiple architectures.

docker/mongodb-agent/Dockerfile.atomic

@@ -88,14 +88,11 @@ COPY ./docker/mongodb-agent/setup-agent-files.sh /usr/local/bin/setup-agent-file
 COPY ./docker/mongodb-agent/dummy-probe.sh /usr/local/bin/dummy-probe.sh
 COPY ./docker/mongodb-agent/dummy-readinessprobe /usr/local/bin/dummy-readinessprobe
 
-# Set up directories and permissions (agent and tools are already extracted in downloader stages)
 RUN mkdir -p /var/lib/automation/config \
     && chmod -R +r /var/lib/automation/config
 
-# Create directories first
 RUN mkdir -p /tools /agent
 
-# Copy the extracted tools and agent from the downloader stages
 COPY --from=tools_downloader "/tools/" /tools/
 COPY --from=agent_downloader "/agent/" /agent/
 

scripts/dev/configure_container_auth.sh

@@ -87,7 +87,7 @@ remove_element() {
   rm "${tmpfile}"
 }
 
-container_login() {
+registry_login() {
   local username="$1"
   local registry="$2"
 
@@ -139,7 +139,7 @@ fi
 
 echo "$(aws --version)}"
 
-aws ecr get-login-password --region "us-east-1" | container_login "AWS" "268558157000.dkr.ecr.us-east-1.amazonaws.com"
+aws ecr get-login-password --region "us-east-1" | registry_login "AWS" "268558157000.dkr.ecr.us-east-1.amazonaws.com"
 
 # by default docker tries to store credentials in an external storage (e.g. OS keychain) - not in the config.json
 # We need to store it as base64 string in config.json instead so we need to remove the "credsStore" element
@@ -148,10 +148,10 @@ if [[ "${CONTAINER_RUNTIME}" == "docker" ]] && exec_cmd grep -q "credsStore" "${
   remove_element "credsStore"
 
   # login again to store the credentials into the config.json
-  aws ecr get-login-password --region "us-east-1" | container_login "AWS" "268558157000.dkr.ecr.us-east-1.amazonaws.com"
+  aws ecr get-login-password --region "us-east-1" | registry_login "AWS" "268558157000.dkr.ecr.us-east-1.amazonaws.com"
 fi
 
-aws ecr get-login-password --region "eu-west-1" | container_login "AWS" "268558157000.dkr.ecr.eu-west-1.amazonaws.com"
+aws ecr get-login-password --region "eu-west-1" | registry_login "AWS" "268558157000.dkr.ecr.eu-west-1.amazonaws.com"
 
 if [[ -n "${COMMUNITY_PRIVATE_PREVIEW_PULLSECRET_DOCKERCONFIGJSON:-}" ]]; then
   # log in to quay.io for the mongodb/mongodb-search-community private repo

scripts/dev/contexts/e2e_mdb_kind_ubi_cloudqa

@@ -9,7 +9,7 @@ source "${script_dir}/root-context"
 
 export ops_manager_version="cloud_qa"
 
-# This is required to be able to rebuild the om image and use that image which has been rebuild
+# This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY=268558157000.dkr.ecr.us-east-1.amazonaws.com/dev
 CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION

scripts/dev/contexts/e2e_operator_perf

@@ -8,7 +8,7 @@ script_dir=$(dirname "${script_name}")
 source "${script_dir}/root-context"
 source "${script_dir}/variables/om70"
 
-# This is required to be able to rebuild the om image and use that image which has been rebuild
+# This is required to be able to rebuild the om image and use that image which has been rebuilt
 export MDB_MAX_CONCURRENT_RECONCILES=10
 export MDB_DEFAULT_ARCHITECTURE=static
 export KUBE_ENVIRONMENT_NAME=performance

scripts/dev/contexts/e2e_operator_perf_large

@@ -8,7 +8,7 @@ script_dir=$(dirname "${script_name}")
 source "${script_dir}/root-context"
 source "${script_dir}/variables/om70"
 
-# This is required to be able to rebuild the om image and use that image which has been rebuild
+# This is required to be able to rebuild the om image and use that image which has been rebuilt
 export MDB_MAX_CONCURRENT_RECONCILES=10
 export MDB_DEFAULT_ARCHITECTURE=static
 export KUBE_ENVIRONMENT_NAME=performance

scripts/dev/contexts/e2e_operator_perf_one_thread

@@ -8,7 +8,7 @@ script_dir=$(dirname "${script_name}")
 source "${script_dir}/root-context"
 source "${script_dir}/variables/om70"
 
-# This is required to be able to rebuild the om image and use that image which has been rebuild
+# This is required to be able to rebuild the om image and use that image which has been rebuilt
 export MDB_MAX_CONCURRENT_RECONCILES=1
 export MDB_DEFAULT_ARCHITECTURE=static
 export KUBE_ENVIRONMENT_NAME=performance

scripts/dev/contexts/e2e_operator_perf_one_thread_large

@@ -8,7 +8,7 @@ script_dir=$(dirname "${script_name}")
 source "${script_dir}/root-context"
 source "${script_dir}/variables/om70"
 
-# This is required to be able to rebuild the om image and use that image which has been rebuild
+# This is required to be able to rebuild the om image and use that image which has been rebuilt
 export MDB_MAX_CONCURRENT_RECONCILES=1
 export MDB_DEFAULT_ARCHITECTURE=static
 export KUBE_ENVIRONMENT_NAME=performance

scripts/dev/contexts/e2e_operator_perf_thirty

@@ -8,7 +8,7 @@ script_dir=$(dirname "${script_name}")
 source "${script_dir}/root-context"
 source "${script_dir}/variables/om70"
 
-# This is required to be able to rebuild the om image and use that image which has been rebuild
+# This is required to be able to rebuild the om image and use that image which has been rebuilt
 export MDB_MAX_CONCURRENT_RECONCILES=30
 export MDB_DEFAULT_ARCHITECTURE=static
 export KUBE_ENVIRONMENT_NAME=performance