Skip to content

Commit 7615478

Browse files
committed
add logger
1 parent 365f97e commit 7615478

File tree

2 files changed

+31
-22
lines changed

2 files changed

+31
-22
lines changed

.evergreen.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,17 +1787,17 @@ buildvariants:
17871787
tags: [ "release_agent" ]
17881788
run_on:
17891789
- release-ubuntu2204-large # This is required for CISA attestation https://jira.mongodb.org/browse/DEVPROD-17780
1790-
# depends_on:
1791-
## - variant: init_test_run
1792-
## name: build_agent_images_ubi # this ensures the agent gets released to ECR as well
1793-
## - variant: e2e_multi_cluster_kind
1794-
## name: '*'
1795-
## - variant: e2e_static_multi_cluster_2_clusters
1796-
## name: '*'
1797-
## - variant: e2e_mdb_kind_ubi_cloudqa
1798-
## name: '*'
1799-
## - variant: e2e_static_mdb_kind_ubi_cloudqa
1800-
## name: '*'
1790+
depends_on:
1791+
- variant: init_test_run
1792+
name: build_agent_images_ubi # this ensures the agent gets released to ECR as well
1793+
- variant: e2e_multi_cluster_kind
1794+
name: '*'
1795+
- variant: e2e_static_multi_cluster_2_clusters
1796+
name: '*'
1797+
- variant: e2e_mdb_kind_ubi_cloudqa
1798+
name: '*'
1799+
- variant: e2e_static_mdb_kind_ubi_cloudqa
1800+
name: '*'
18011801
tasks:
18021802
- name: release_agent
18031803

scripts/release/detect_ops_manager_changes.py

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,29 @@
44
Relies on git origin/master vs local release.json
55
"""
66
import json
7-
import os
8-
import re
7+
import logging
98
import subprocess
109
import sys
1110
from typing import Dict, List, Optional, Tuple
1211

12+
logging.basicConfig(
13+
level=logging.INFO,
14+
format='%(asctime)s - %(name)s - %(levelname)s - %(message)s',
15+
handlers=[
16+
logging.StreamHandler(sys.stdout)
17+
]
18+
)
19+
logger = logging.getLogger(__name__)
20+
1321

1422
def get_content_from_git(commit: str, file_path: str) -> Optional[str]:
1523
try:
1624
result = subprocess.run(
1725
["git", "show", f"{commit}:{file_path}"], capture_output=True, text=True, check=True, timeout=30
1826
)
1927
return result.stdout
20-
except (subprocess.CalledProcessError, subprocess.TimeoutExpired):
28+
except (subprocess.CalledProcessError, subprocess.TimeoutExpired) as e:
29+
logger.error(f"Failed to get {file_path} from git commit {commit}: {e}")
2130
return None
2231

2332

@@ -26,13 +35,13 @@ def load_release_json_from_master() -> Optional[Dict]:
2635

2736
content = get_content_from_git(base_revision, "release.json")
2837
if not content:
29-
print(f"Could not retrieve release.json from {base_revision}")
38+
logger.error(f"Could not retrieve release.json from {base_revision}")
3039
return None
3140

3241
try:
3342
return json.loads(content)
3443
except json.JSONDecodeError as e:
35-
print(f"Invalid JSON in base release.json: {e}")
44+
logger.error(f"Invalid JSON in base release.json: {e}")
3645
return None
3746

3847

@@ -41,7 +50,7 @@ def load_current_release_json() -> Optional[Dict]:
4150
with open("release.json", "r") as f:
4251
return json.load(f)
4352
except (FileNotFoundError, json.JSONDecodeError) as e:
44-
print(f"Could not load current release.json: {e}")
53+
logger.error(f"Could not load current release.json: {e}")
4554
return None
4655

4756

@@ -97,7 +106,7 @@ def get_all_agents_for_rebuild() -> List[Tuple[str, str]]:
97106

98107
release_data = load_current_release_json()
99108
if not release_data:
100-
print("ERROR: Could not load release.json")
109+
logger.error("Could not load release.json")
101110
return []
102111

103112
ops_manager_mapping = extract_ops_manager_mapping(release_data)
@@ -122,21 +131,21 @@ def get_all_agents_for_rebuild() -> List[Tuple[str, str]]:
122131
tools_version = get_tools_version_for_agent(main_agent_version)
123132
agents.append((main_agent_version, tools_version))
124133

125-
return list(set(agents)) # Remove duplicates
134+
return list(set(agents))
126135

127136

128137
def detect_ops_manager_changes() -> List[Tuple[str, str]]:
129138
"""Returns (has_changes, changed_agents_list)"""
130-
print("=== Detecting OM Mapping Changes (Local vs Base) ===")
139+
logger.info("=== Detecting OM Mapping Changes (Local vs Base) ===")
131140

132141
current_release = load_current_release_json()
133142
if not current_release:
134-
print("ERROR: Could not load current local release.json")
143+
logger.error("Could not load current local release.json")
135144
return []
136145

137146
master_release = load_release_json_from_master()
138147
if not master_release:
139-
print("WARNING: Could not load base release.json, assuming changes exist")
148+
logger.warning("Could not load base release.json, assuming changes exist")
140149
return []
141150

142151
current_mapping = extract_ops_manager_mapping(current_release)

0 commit comments

Comments
 (0)